Skip to content

Fix test_sysuptime failure#16528

Merged
wangxin merged 1 commit intosonic-net:masterfrom
opcoder0:fix/telemetry-test-sysuptime
Jan 16, 2025
Merged

Fix test_sysuptime failure#16528
wangxin merged 1 commit intosonic-net:masterfrom
opcoder0:fix/telemetry-test-sysuptime

Conversation

@opcoder0
Copy link
Copy Markdown
Contributor

@opcoder0 opcoder0 commented Jan 15, 2025

Fix test_sysuptime fails with error

image

Summary:
Fixes # NA

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Fix broken test

How did you do it?

Fix format parsing before type conversion

How did you verify/test it?

Tested on 7050cx3

Any platform specific information?

None

Supported testbed topology if it's a new test case?

NA

Documentation

* The change strips comma (if present) from py_gnmicli proc/uptime output before
  converting to float
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@opcoder0 opcoder0 requested a review from wsycqyz January 15, 2025 11:50
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@wangxin wangxin merged commit e7cfb3e into sonic-net:master Jan 16, 2025
opcoder0 added a commit to opcoder0/sonic-mgmt that referenced this pull request Jan 17, 2025
nnelluri-cisco pushed a commit to nnelluri-cisco/sonic-mgmt that referenced this pull request Mar 15, 2025
* The change strips comma (if present) from py_gnmicli proc/uptime output before
  converting to float

What is the motivation for this PR?
Fix broken test

How did you do it?
Fix format parsing before type conversion

How did you verify/test it?
Tested on 7050cx3
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request May 16, 2025
* The change strips comma (if present) from py_gnmicli proc/uptime output before
  converting to float

What is the motivation for this PR?
Fix broken test

How did you do it?
Fix format parsing before type conversion

How did you verify/test it?
Tested on 7050cx3
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202411: #18461

bingwang-ms pushed a commit that referenced this pull request Jun 24, 2025
* The change strips comma (if present) from py_gnmicli proc/uptime output before
  converting to float

What is the motivation for this PR?
Fix broken test

How did you do it?
Fix format parsing before type conversion

How did you verify/test it?
Tested on 7050cx3

Co-authored-by: Sai Kiran <[email protected]>
@r12f
Copy link
Copy Markdown
Collaborator

r12f commented Jun 28, 2025

already in 202411.

sdszhang pushed a commit to sdszhang/sonic-mgmt that referenced this pull request Jun 30, 2025
Code sync sonic-net/sonic-mgmt:202411 => 202412

```
*   9be4331 (HEAD -> code-sync-202412, origin/code-sync-202412) r12f 250624:2357 - Merge remote-tracking branch 'base/202411' into code-sync-202412
|\
| * 859f834 (base/202411) mssonicbld 250625:0740 - Fix test_sysuptime failure (sonic-net#16528) (sonic-net#18461)
```

Co-authored-by: mssonicbld <[email protected]>
Co-authored-by: Sai Kiran <[email protected]>
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to msft-202503: Azure/sonic-mgmt.msft#552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants