Merged
Conversation
* The change strips comma (if present) from py_gnmicli proc/uptime output before converting to float
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xwjiang-ms
approved these changes
Jan 15, 2025
wangxin
approved these changes
Jan 16, 2025
opcoder0
added a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Jan 17, 2025
This reverts commit e7cfb3e.
8 tasks
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
* The change strips comma (if present) from py_gnmicli proc/uptime output before converting to float What is the motivation for this PR? Fix broken test How did you do it? Fix format parsing before type conversion How did you verify/test it? Tested on 7050cx3
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
May 16, 2025
* The change strips comma (if present) from py_gnmicli proc/uptime output before converting to float What is the motivation for this PR? Fix broken test How did you do it? Fix format parsing before type conversion How did you verify/test it? Tested on 7050cx3
Collaborator
|
Cherry-pick PR to 202411: #18461 |
11 tasks
bingwang-ms
pushed a commit
that referenced
this pull request
Jun 24, 2025
* The change strips comma (if present) from py_gnmicli proc/uptime output before converting to float What is the motivation for this PR? Fix broken test How did you do it? Fix format parsing before type conversion How did you verify/test it? Tested on 7050cx3 Co-authored-by: Sai Kiran <[email protected]>
Collaborator
|
already in 202411. |
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Jun 30, 2025
Code sync sonic-net/sonic-mgmt:202411 => 202412 ``` * 9be4331 (HEAD -> code-sync-202412, origin/code-sync-202412) r12f 250624:2357 - Merge remote-tracking branch 'base/202411' into code-sync-202412 |\ | * 859f834 (base/202411) mssonicbld 250625:0740 - Fix test_sysuptime failure (sonic-net#16528) (sonic-net#18461) ``` Co-authored-by: mssonicbld <[email protected]> Co-authored-by: Sai Kiran <[email protected]>
11 tasks
Collaborator
|
Cherry-pick PR to msft-202503: Azure/sonic-mgmt.msft#552 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
test_sysuptimefails with errorSummary:
Fixes # NA
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix broken test
How did you do it?
Fix format parsing before type conversion
How did you verify/test it?
Tested on 7050cx3
Any platform specific information?
None
Supported testbed topology if it's a new test case?
NA
Documentation