flap interface after sfp reset by sdszhang · Pull Request #16375 · sonic-net/sonic-mgmt

sdszhang · 2025-01-07T06:25:50Z

Description of PR

Summary:
Fixes interface stays down after tests/platform_tests/api/test_sfp.py::sfp_reset()

And causing error during shutdown_ebgp fixture teardown.

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

keep interface up after sfp_reset if it's T2 and QSFP-DD SFP.

How did you do it?

flap the interface after sfp_reset to restore the interface state.

How did you verify/test it?

passed on physical testbed with

admin@svcstr2-8800-lc1-1:~$ sudo sfputil show eeprom -d -p Ethernet0
Ethernet0: SFP EEPROM detected
...
        Application Advertisement: 400GAUI-8 C2M (Annex 120E) - Host Assign (0x1) - Active Cable assembly with BER < 5x10^-5 - Media Assign (0x1)
                                   CAUI-4 C2M (Annex 83E) - Host Assign (0x1) - Active Cable assembly with BER < 5x10^-5 - Media Assign (0x1)
        CMIS Revision: 4.0
        Connector: No separable connector
        Encoding: N/A
        Extended Identifier: Power Class 5 (10.0W Max)
        Extended RateSelect Compliance: N/A
        Hardware Revision: 1.0
        Host Electrical Interface: 400GAUI-8 C2M (Annex 120E)
        Host Lane Assignment Options: 1
        Host Lane Count: 8
        Identifier: QSFP-DD Double Density 8X Pluggable Transceiver
        Length Cable Assembly(m): 1.0
......

platform_tests/api/test_sfp.py::TestSfpApi::test_reset[xxx-lc1-1] PASSED [ 73%]
......
=========================== short test summary info ============================
FAILED platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[svcstr2-8800-lc1-1]                        <<<< this is separate issue, not related to this PR.
========================= 1 failed, 22 passed, 1 warning in 2104.41s (0:35:04) =========================
``
============= 1 failed, 22 passed, 1 warning in 2104.41s (0:35:04) =============

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2025-01-07T06:25:52Z

/azp run

azure-pipelines · 2025-01-07T06:26:04Z

Azure Pipelines successfully started running 1 pipeline(s).

sdszhang · 2025-01-07T06:33:10Z

@prgeor @abdosi @yejianquan can you help to review this one?

mihirpat1 · 2025-01-08T06:10:57Z

@longhuan-cisco Can you please help in reviewing this?

mssonicbld · 2025-01-10T01:55:14Z

/azp run

azure-pipelines · 2025-01-10T01:55:26Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-10T03:58:00Z

/azp run

azure-pipelines · 2025-01-10T03:58:12Z

Azure Pipelines successfully started running 1 pipeline(s).

mihirpat1 · 2025-01-14T03:33:15Z

@prgeor Can you please help in reviewing this PR?

Co-authored-by: mihirpat1 <[email protected]>

mssonicbld · 2025-01-14T11:43:31Z

/azp run

azure-pipelines · 2025-01-14T11:43:44Z

Azure Pipelines successfully started running 1 pipeline(s).

prgeor

@sdszhang please make the following changes:-

This SFP test case is not T2 specific. Please remove T2 specific platform check.
Make this fix for CMIS optics does not matter if osfp or QSFP-DD

mssonicbld · 2025-01-15T06:26:28Z

/azp run

azure-pipelines · 2025-01-15T06:26:40Z

Azure Pipelines successfully started running 1 pipeline(s).

sdszhang · 2025-01-15T07:28:26Z

@sdszhang please make the following changes:-

This SFP test case is not T2 specific. Please remove T2 specific platform check.

Make this fix for CMIS optics does not matter if osfp or QSFP-DD

@prgeor Updated with the suggestion.
Internal test result:
T1 result PASSED
T2 result PASSED

mssonicbld · 2025-01-17T00:27:27Z

/azp run

azure-pipelines · 2025-01-17T00:27:39Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-17T02:14:17Z

/azp run

azure-pipelines · 2025-01-17T02:14:30Z

Azure Pipelines successfully started running 1 pipeline(s).

The comment has been resolved

Description of PR Summary: Fixes interface stays down after tests/platform_tests/api/test_sfp.py::sfp_reset() And causing error during shutdown_ebgp fixture teardown. Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? keep interface up after sfp_reset if it's T2 and QSFP-DD SFP. How did you do it? flap the interface after sfp_reset to restore the interface state. How did you verify/test it? passed on physical testbed with admin@svcstr2-8800-lc1-1:~$ sudo sfputil show eeprom -d -p Ethernet0 Ethernet0: SFP EEPROM detected ... Application Advertisement: 400GAUI-8 C2M (Annex 120E) - Host Assign (0x1) - Active Cable assembly with BER < 5x10^-5 - Media Assign (0x1) CAUI-4 C2M (Annex 83E) - Host Assign (0x1) - Active Cable assembly with BER < 5x10^-5 - Media Assign (0x1) CMIS Revision: 4.0 Connector: No separable connector Encoding: N/A Extended Identifier: Power Class 5 (10.0W Max) Extended RateSelect Compliance: N/A Hardware Revision: 1.0 Host Electrical Interface: 400GAUI-8 C2M (Annex 120E) Host Lane Assignment Options: 1 Host Lane Count: 8 Identifier: QSFP-DD Double Density 8X Pluggable Transceiver Length Cable Assembly(m): 1.0 ...... platform_tests/api/test_sfp.py::TestSfpApi::test_reset[xxx-lc1-1] PASSED [ 73%] ...... =========================== short test summary info ============================ FAILED platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[svcstr2-8800-lc1-1] <<<< this is separate issue, not related to this PR. ========================= 1 failed, 22 passed, 1 warning in 2104.41s (0:35:04) ========================= `` ============= 1 failed, 22 passed, 1 warning in 2104.41s (0:35:04) ============= Any platform specific information? Supported testbed topology if it's a new test case? Co-authored-by: [email protected]

mssonicbld · 2025-01-17T06:06:29Z

Cherry-pick PR to 202411: #16570

Description of PR Summary: Fixes interface stays down after tests/platform_tests/api/test_sfp.py::sfp_reset() And causing error during shutdown_ebgp fixture teardown. Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? keep interface up after sfp_reset if it's T2 and QSFP-DD SFP. How did you do it? flap the interface after sfp_reset to restore the interface state. How did you verify/test it? passed on physical testbed with admin@svcstr2-8800-lc1-1:~$ sudo sfputil show eeprom -d -p Ethernet0 Ethernet0: SFP EEPROM detected ... Application Advertisement: 400GAUI-8 C2M (Annex 120E) - Host Assign (0x1) - Active Cable assembly with BER < 5x10^-5 - Media Assign (0x1) CAUI-4 C2M (Annex 83E) - Host Assign (0x1) - Active Cable assembly with BER < 5x10^-5 - Media Assign (0x1) CMIS Revision: 4.0 Connector: No separable connector Encoding: N/A Extended Identifier: Power Class 5 (10.0W Max) Extended RateSelect Compliance: N/A Hardware Revision: 1.0 Host Electrical Interface: 400GAUI-8 C2M (Annex 120E) Host Lane Assignment Options: 1 Host Lane Count: 8 Identifier: QSFP-DD Double Density 8X Pluggable Transceiver Length Cable Assembly(m): 1.0 ...... platform_tests/api/test_sfp.py::TestSfpApi::test_reset[xxx-lc1-1] PASSED [ 73%] ...... =========================== short test summary info ============================ FAILED platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[svcstr2-8800-lc1-1] <<<< this is separate issue, not related to this PR. ========================= 1 failed, 22 passed, 1 warning in 2104.41s (0:35:04) ========================= `` ============= 1 failed, 22 passed, 1 warning in 2104.41s (0:35:04) ============= Any platform specific information? Supported testbed topology if it's a new test case? Co-authored-by: [email protected]

longhuan-cisco · 2025-02-10T19:26:29Z

@yejianquan
We saw same issue on fixed (non-chassis) platforms.
Wondering if it's possible to add back request for 202405 tag to cherry-pick it to 202405 (not msft-202405)? I saw this tag got removed somehow, not sure about the reason behind.

yejianquan · 2025-02-19T03:46:52Z

@yejianquan We saw same issue on fixed (non-chassis) platforms. Wondering if it's possible to add back request for 202405 tag to cherry-pick it to 202405 (not msft-202405)? I saw this tag got removed somehow, not sure about the reason behind.

@bingwang-ms for the requirement to 202405 branch

Merge sonic-net#16547 sonic-net#16375 into msft 202405 branch

Description of PR Summary: Fixes interface stays down after tests/platform_tests/api/test_sfp.py::sfp_reset() And causing error during shutdown_ebgp fixture teardown. Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? keep interface up after sfp_reset if it's T2 and QSFP-DD SFP. How did you do it? flap the interface after sfp_reset to restore the interface state. How did you verify/test it? passed on physical testbed with admin@svcstr2-8800-lc1-1:~$ sudo sfputil show eeprom -d -p Ethernet0 Ethernet0: SFP EEPROM detected ... Application Advertisement: 400GAUI-8 C2M (Annex 120E) - Host Assign (0x1) - Active Cable assembly with BER < 5x10^-5 - Media Assign (0x1) CAUI-4 C2M (Annex 83E) - Host Assign (0x1) - Active Cable assembly with BER < 5x10^-5 - Media Assign (0x1) CMIS Revision: 4.0 Connector: No separable connector Encoding: N/A Extended Identifier: Power Class 5 (10.0W Max) Extended RateSelect Compliance: N/A Hardware Revision: 1.0 Host Electrical Interface: 400GAUI-8 C2M (Annex 120E) Host Lane Assignment Options: 1 Host Lane Count: 8 Identifier: QSFP-DD Double Density 8X Pluggable Transceiver Length Cable Assembly(m): 1.0 ...... platform_tests/api/test_sfp.py::TestSfpApi::test_reset[xxx-lc1-1] PASSED [ 73%] ...... =========================== short test summary info ============================ FAILED platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[svcstr2-8800-lc1-1] <<<< this is separate issue, not related to this PR. ========================= 1 failed, 22 passed, 1 warning in 2104.41s (0:35:04) ========================= `` ============= 1 failed, 22 passed, 1 warning in 2104.41s (0:35:04) ============= Any platform specific information? Supported testbed topology if it's a new test case? Co-authored-by: [email protected]

Merge 202405 branch in as of 12:23pm 20/01/2025 AEST b118611 (HEAD -> merge/202405) Use alternate check for reboot for T2 after reboot with REBOOT_TYPE_POWEROFF (sonic-net#16348) 0e0e898 flap interface after sfp reset (sonic-net#16375) 41e2b2f Temporarily skip lpmode test for some transceivers with known issue (sonic-net#16547) de60273 [Snappi] Infra changes for new PFC-ECN testcases. (sonic-net#13864) 7b357f5 [Snappi] New testcases for PFC-ECN. (sonic-net#13865) 3523a7f [Snappi]: PFC - Mixed Speed testcases (sonic-net#14122) 3754f2a sonic-mgmt: Fix namespace issues for qos tests on T2 single ASIC (sonic-net#15708) 21f6526 [sonic-net#16015 Fix]: Cleaning up unused code from snappi_fixtures (sonic-net#16026) d8f23be Correcting client arguments to dynamically_compensate_leakout (sonic-net#16169) 3c47107 [sanity_check][bgp] Enhance sanity check recover for bgp default route missing (sonic-net#16357) 37352b8 Eliminate cross-feature dependency from macsec module (sonic-net#15617) 4f33b0d (pub_upstream/202405) [202405][dhcp_relay] Add test case to verify dhcp6relay LLA waiting logic (sonic-net#16494) (sonic-net#16567)

Description of PR Summary: Fixes interface stays down after tests/platform_tests/api/test_sfp.py::sfp_reset() And causing error during shutdown_ebgp fixture teardown. Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? keep interface up after sfp_reset if it's T2 and QSFP-DD SFP. How did you do it? flap the interface after sfp_reset to restore the interface state. How did you verify/test it? passed on physical testbed with admin@svcstr2-8800-lc1-1:~$ sudo sfputil show eeprom -d -p Ethernet0 Ethernet0: SFP EEPROM detected ... Application Advertisement: 400GAUI-8 C2M (Annex 120E) - Host Assign (0x1) - Active Cable assembly with BER < 5x10^-5 - Media Assign (0x1) CAUI-4 C2M (Annex 83E) - Host Assign (0x1) - Active Cable assembly with BER < 5x10^-5 - Media Assign (0x1) CMIS Revision: 4.0 Connector: No separable connector Encoding: N/A Extended Identifier: Power Class 5 (10.0W Max) Extended RateSelect Compliance: N/A Hardware Revision: 1.0 Host Electrical Interface: 400GAUI-8 C2M (Annex 120E) Host Lane Assignment Options: 1 Host Lane Count: 8 Identifier: QSFP-DD Double Density 8X Pluggable Transceiver Length Cable Assembly(m): 1.0 ...... platform_tests/api/test_sfp.py::TestSfpApi::test_reset[xxx-lc1-1] PASSED [ 73%] ...... =========================== short test summary info ============================ FAILED platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[svcstr2-8800-lc1-1] <<<< this is separate issue, not related to this PR. ========================= 1 failed, 22 passed, 1 warning in 2104.41s (0:35:04) ========================= `` ============= 1 failed, 22 passed, 1 warning in 2104.41s (0:35:04) ============= Any platform specific information? Supported testbed topology if it's a new test case? Co-authored-by: [email protected]

flap interface after reset

d4e9991

sdszhang requested a review from prgeor as a code owner January 7, 2025 06:25

sdszhang requested a review from abdosi January 7, 2025 06:31

mihirpat1 reviewed Jan 8, 2025

View reviewed changes

Comment thread tests/platform_tests/api/test_sfp.py Outdated

mihirpat1 reviewed Jan 8, 2025

View reviewed changes

Comment thread tests/platform_tests/api/test_sfp.py Outdated

sdszhang added chassis Request for 202405 branch Request for 202411 branch labels Jan 9, 2025

mihirpat1 reviewed Jan 9, 2025

View reviewed changes

Comment thread tests/platform_tests/api/test_sfp.py Outdated

Comment thread tests/common/devices/multi_asic.py

update review comments

246e4bf

prep-commit error

e3848c3

mihirpat1 approved these changes Jan 14, 2025

View reviewed changes

Comment thread tests/common/devices/multi_asic.py Outdated

Comment thread tests/common/devices/multi_asic.py Outdated

Apply suggestions from code review

42deb8a

Co-authored-by: mihirpat1 <[email protected]>

prgeor previously requested changes Jan 15, 2025

View reviewed changes

make it generic, and check for CMIS module only.

1fb54c7

sdszhang requested a review from prgeor January 15, 2025 22:17

mihirpat1 approved these changes Jan 17, 2025

View reviewed changes

sdszhang removed the Request for msft-202405 Branch label Jan 17, 2025

fix pre-commit error.

ef1f833

yejianquan merged commit 6814013 into sonic-net:master Jan 17, 2025

yejianquan added Approved for 202411 branch Request for msft-202405 Branch and removed Request for 202405 branch labels Jan 17, 2025

mssonicbld added the Created PR to 202411 branch label Jan 17, 2025

mssonicbld mentioned this pull request Jan 17, 2025

[action] [PR:16375] flap interface after sfp reset #16570

Merged

9 tasks

mssonicbld added Included in 202411 branch and removed Created PR to 202411 branch labels Jan 17, 2025

Javier-Tan added the Included in msft-202405 Branch label Jan 18, 2025

bpar9 added the Request for 202405 branch label Feb 14, 2025

wangxin pushed a commit to wangxin/sonic-mgmt that referenced this pull request Feb 21, 2025

Merge pull request sonic-net#10 from yejianquan/jianquanye/msft_202405

11bf470

Merge sonic-net#16547 sonic-net#16375 into msft 202405 branch

arista-nwolfe mentioned this pull request Feb 25, 2025

sfp reset on optical xcvrs leave the port in low-power mode aristanetworks/sonic#121

Closed

sdszhang deleted the sfp_reset branch March 27, 2025 12:26

Conversation

sdszhang commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Jan 7, 2025

Uh oh!

azure-pipelines bot commented Jan 7, 2025

Uh oh!

sdszhang commented Jan 7, 2025

Uh oh!

Uh oh!

mihirpat1 commented Jan 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Jan 10, 2025

Uh oh!

azure-pipelines bot commented Jan 10, 2025

Uh oh!

mssonicbld commented Jan 10, 2025

Uh oh!

azure-pipelines bot commented Jan 10, 2025

Uh oh!

Uh oh!

Uh oh!

mihirpat1 commented Jan 14, 2025

Uh oh!

mssonicbld commented Jan 14, 2025

Uh oh!

azure-pipelines bot commented Jan 14, 2025

Uh oh!

prgeor left a comment

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Jan 15, 2025

Uh oh!

azure-pipelines bot commented Jan 15, 2025

Uh oh!

sdszhang commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssonicbld commented Jan 17, 2025

Uh oh!

azure-pipelines bot commented Jan 17, 2025

Uh oh!

mssonicbld commented Jan 17, 2025

Uh oh!

azure-pipelines bot commented Jan 17, 2025

Uh oh!

mssonicbld commented Jan 17, 2025

Uh oh!

longhuan-cisco commented Feb 10, 2025

Uh oh!

yejianquan commented Feb 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

sdszhang commented Jan 7, 2025 •

edited

Loading

sdszhang commented Jan 15, 2025 •

edited

Loading