Add E2E bmp feature test cases#15749

Merged

qiluo-msft merged 25 commits intosonic-net:masterfrom

FengPan-Frank:bmptest

Feb 7, 2025

Contributor

FengPan-Frank commented Nov 26, 2024 •

edited

Loading

Description of PR

Add E2E test cases for bmp feature, including below main workflow

config cli
new redis-server bmp instance
systemctl service
bmp_state_db population

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

Add test cases for bmp feature, including config cli, redis-server instance, systemctl service, bmp_state_db population

How did you do it?

Added relevant bmp feature test cases

How did you verify/test it?

via mgmt pipeline test.

Any platform specific information?

single asic only.

Supported testbed topology if it's a new test case?

Documentation


          Add bmp feature test cases

504b8e9

FengPan-Frank marked this pull request as draft

November 26, 2024 12:49

Collaborator

mssonicbld commented Nov 26, 2024

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/bmp/test_db_instace.py fix end of files.........................................................Failed - hook id: end-of-file-fixer - exit code: 1 - files were modified by this hook Fixing tests/bmp/conftest.py Fixing tests/common/helpers/bmp_utils.py Fixing tests/bmp/helper.py check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

FengPan-Frank added 2 commits

January 23, 2025 14:03


          update test

cf0fb40


          Merge branch 'sonic-net:master' into bmptest

f58c6d9

Collaborator

mssonicbld commented Jan 23, 2025

/azp run

azure-pipelines bot commented Jan 23, 2025

Azure Pipelines successfully started running 1 pipeline(s).

Collaborator

mssonicbld commented Jan 23, 2025

/azp run

azure-pipelines bot commented Jan 23, 2025

Azure Pipelines successfully started running 1 pipeline(s).

FengPan-Frank marked this pull request as ready for review

January 23, 2025 14:05

FengPan-Frank force-pushed the bmptest branch from 5f1c2e9 to 6831dfe Compare

January 23, 2025 14:22

Collaborator

mssonicbld commented Jan 23, 2025

/azp run

azure-pipelines bot commented Jan 23, 2025

Azure Pipelines successfully started running 1 pipeline(s).

FengPan-Frank force-pushed the bmptest branch from 6831dfe to 8b23150 Compare

January 23, 2025 14:29

Collaborator

mssonicbld commented Jan 23, 2025

/azp run

azure-pipelines bot commented Jan 23, 2025

Azure Pipelines successfully started running 1 pipeline(s).

FengPan-Frank force-pushed the bmptest branch from 8b23150 to 74b237e Compare

January 23, 2025 14:38

Collaborator

mssonicbld commented Jan 23, 2025

/azp run

azure-pipelines bot commented Jan 23, 2025

Azure Pipelines successfully started running 1 pipeline(s).


          Merge branch 'bmptest' of https://github.com/FengPan-Frank/sonic-mgmt …

c04e8d8

…into bmptest

FengPan-Frank force-pushed the bmptest branch from 74b237e to c04e8d8 Compare

January 23, 2025 21:53

Collaborator

mssonicbld commented Jan 23, 2025

/azp run

azure-pipelines bot commented Jan 23, 2025

Azure Pipelines successfully started running 1 pipeline(s).


          Merge branch 'bmptest' of https://github.com/FengPan-Frank/sonic-mgmt …

523c0ce

…into bmptest

Collaborator

mssonicbld commented Jan 30, 2025

/azp run

azure-pipelines bot commented Jan 30, 2025

Azure Pipelines successfully started running 1 pipeline(s).

FengPan-Frank force-pushed the bmptest branch from 137b564 to 59bfce5 Compare

January 30, 2025 05:01

Collaborator

mssonicbld commented Jan 30, 2025

/azp run

azure-pipelines bot commented Jan 30, 2025

Azure Pipelines successfully started running 1 pipeline(s).

FengPan-Frank force-pushed the bmptest branch from 59bfce5 to 51e709e Compare

January 30, 2025 05:06

FengPan-Frank added 2 commits

February 7, 2025 01:27


          Merge branch 'bmptest' of https://github.com/FengPan-Frank/sonic-mgmt …

765cbe3

…into bmptest


          Merge branch 'bmptest' of https://github.com/FengPan-Frank/sonic-mgmt …

b12e8d3

…into bmptest

Collaborator

mssonicbld commented Feb 7, 2025

/azp run

azure-pipelines bot commented Feb 7, 2025

Azure Pipelines successfully started running 1 pipeline(s).

FengPan-Frank added 2 commits

February 7, 2025 01:51


          Merge branch 'bmptest' of https://github.com/FengPan-Frank/sonic-mgmt …

36734d0

…into bmptest


          Merge branch 'bmptest' of https://github.com/FengPan-Frank/sonic-mgmt …

60aefcc

…into bmptest

Collaborator

mssonicbld commented Feb 7, 2025

/azp run

azure-pipelines bot commented Feb 7, 2025

Azure Pipelines successfully started running 1 pipeline(s).

FengPan-Frank added 2 commits

February 7, 2025 02:06


          Merge branch 'bmptest' of https://github.com/FengPan-Frank/sonic-mgmt …

5b70252

…into bmptest


          Merge branch 'bmptest' of https://github.com/FengPan-Frank/sonic-mgmt …

c0ab792

…into bmptest

Collaborator

mssonicbld commented Feb 7, 2025

/azp run

azure-pipelines bot commented Feb 7, 2025

Azure Pipelines successfully started running 1 pipeline(s).

FengPan-Frank added 2 commits

February 7, 2025 02:12


          Merge branch 'bmptest' of https://github.com/FengPan-Frank/sonic-mgmt …

d55b60f

…into bmptest


          Merge branch 'bmptest' of https://github.com/FengPan-Frank/sonic-mgmt …

3c735e0

…into bmptest

Collaborator

mssonicbld commented Feb 7, 2025

/azp run

azure-pipelines bot commented Feb 7, 2025

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft approved these changes

View reviewed changes

qiluo-msft enabled auto-merge (squash)

February 7, 2025 05:10

qiluo-msft merged commit 7ea4711 into sonic-net:master

FengPan-Frank added Request for 202411 branch Approved for 202411 branch labels

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request


          Add E2E bmp feature test cases (sonic-net#15749)

d5ba7fd

Description of PR
Add E2E test cases for bmp feature, including below main workflow

config cli
new redis-server bmp instance
systemctl service
bmp_state_db population

Approach
What is the motivation for this PR?
Add test cases for bmp feature, including config cli, redis-server instance, systemctl service, bmp_state_db population

How did you do it?
Added relevant bmp feature test cases

How did you verify/test it?
via mgmt pipeline test.

Any platform specific information?
single asic only.

mssonicbld added the Created PR to 202411 branch label

Collaborator

mssonicbld commented Feb 7, 2025

Cherry-pick PR to 202411: #16850

mssonicbld mentioned this pull request

[action] [PR:15749] Add E2E bmp feature test cases #16850

Merged

8 tasks

mssonicbld pushed a commit that referenced this pull request


          Add E2E bmp feature test cases (#15749)

71eedcf

Description of PR
Add E2E test cases for bmp feature, including below main workflow

config cli
new redis-server bmp instance
systemctl service
bmp_state_db population

Approach
What is the motivation for this PR?
Add test cases for bmp feature, including config cli, redis-server instance, systemctl service, bmp_state_db population

How did you do it?
Added relevant bmp feature test cases

How did you verify/test it?
via mgmt pipeline test.

Any platform specific information?
single asic only.

mssonicbld added Included in 202411 branch and removed Created PR to 202411 branch labels

vivekverma-arista mentioned this pull request

Add BMP to init config in default disabled state sonic-net/sonic-buildimage#21863

Closed

12 tasks

nnelluri-cisco pushed a commit to nnelluri-cisco/sonic-mgmt that referenced this pull request


          Add E2E bmp feature test cases (sonic-net#15749)

2e7e1c5

Description of PR
Add E2E test cases for bmp feature, including below main workflow

config cli
new redis-server bmp instance
systemctl service
bmp_state_db population

Approach
What is the motivation for this PR?
Add test cases for bmp feature, including config cli, redis-server instance, systemctl service, bmp_state_db population

How did you do it?
Added relevant bmp feature test cases

How did you verify/test it?
via mgmt pipeline test.

Any platform specific information?
single asic only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved for 202411 branch Included in 202411 branch Request for 202411 branch