Skip to content

Convert bgp_multipath_relax ansible playbook to pytest#1569

Merged
arlakshm merged 6 commits intosonic-net:masterfrom
arlakshm:bgp_multipath
Jul 2, 2020
Merged

Convert bgp_multipath_relax ansible playbook to pytest#1569
arlakshm merged 6 commits intosonic-net:masterfrom
arlakshm:bgp_multipath

Conversation

@arlakshm
Copy link
Copy Markdown
Contributor

@arlakshm arlakshm commented Apr 15, 2020

Signed-off-by: Arvindsrinivasan Lakshminarasimhan [email protected]

Description of PR

Summary:
Convert bgp_multipath_relax ansible playbook to pytest
Fixes # (issue)

Type of change

New Pytest

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

How did you verify/test it?

arlakshm/sonic-mgmt@3176a03c5c39:/var/repos/public/my_repo/sonic-mgmt/tests$ py.test $PYTEST_COMMON_OPTS --skip_sanity --log-file logs/test_bgp_multipath_relax.log --junitxml=results/tr.xml test_bgp_multipath_relax.py
================================================== test session starts ==================================================
platform linux2 -- Python 2.7.12, pytest-4.6.6, py-1.8.0, pluggy-0.13.0 -- /usr/bin/python
cachedir: .pytest_cache
ansible: 2.8.7
rootdir: /var/repos/public/my_repo/sonic-mgmt/tests, inifile: pytest.ini
plugins: ansible-2.2.2
collected 1 item

test_bgp_multipath_relax.py::test_bgp_multipath_relax PASSED [100%]

--------------------- generated xml file: /var/repos/public/my_repo/sonic-mgmt/tests/results/tr.xml ---------------------
=============================================== 1 passed in 15.38 seconds ===============================================
arlakshm/sonic-mgmt@3176a03c5c39:/var/repos/public/my_repo/sonic-mgmt/tests

Any platform specific information?

None

Supported testbed topology if it's a new test case?

This test is supported in t1 topologies

Documentation

@arlakshm
Convert bgp_multipath_relax ansible playbook to pytest
3cc7ad8 
Signed-off-by: Arvindsrinivasan Lakshminarasimhan <[email protected]>
@arlakshm arlakshm requested a review from lguohan April 15, 2020 07:24
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Apr 15, 2020

This pull request introduces 2 alerts when merging 3cc7ad8 into eeba0cf - view on LGTM.com

new alerts:

  • 2 for Unused import

@arlakshm
Minor fixes
95dbe00 
Signed-off-by: Arvindsrinivasan Lakshminarasimhan <[email protected]>
@msosyak
Copy link
Copy Markdown
Contributor

msosyak commented Apr 22, 2020

Please, add wrapper instead of ansible version of the test

@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Apr 23, 2020

current t0 route announce does not advertise the vip prefix. I believe in order for the test to work, we need to develop a fixture that leverage the exabgp to advertise the vip prefix. I cannot find this test has that configuration.

@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Apr 26, 2020

please also move the test into bgp subfolder.

@wangxin
Copy link
Copy Markdown
Collaborator

wangxin commented May 21, 2020

With PR #1692, the vips routes can be announced to the t0 VMs that have the vips configuration.

Since the vips routes are part of the topology definition. IMO, it's OK to announce the vips routes in the fib fixture.

wangxin
wangxin reviewed May 21, 2020
View reviewed changes
Comment thread tests/test_bgp_multipath_relax.py




Copy link
Copy Markdown
Collaborator

@wangxin wangxin May 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove the extra new lines at the end of the script?

Copy link
Copy Markdown
Contributor Author

@arlakshm arlakshm Jun 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in the latest commit

@wangxin
Copy link
Copy Markdown
Collaborator

wangxin commented May 22, 2020

Tested this PR, it passed with change #1692.

@wangxin
Copy link
Copy Markdown
Collaborator

wangxin commented Jun 24, 2020

retest vsimage please

@arlakshm
Copy link
Copy Markdown
Contributor Author

arlakshm commented Jun 25, 2020

please also move the test into bgp subfolder.

Moved to bgp folder

tahmed-dev
tahmed-dev suggested changes Jun 26, 2020
View reviewed changes
Comment thread tests/bgp/test_bgp_multipath_relax.py Outdated
tahmed-dev
tahmed-dev approved these changes Jun 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tahmed-dev tahmed-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. there were two more assert leftovers

Comment thread tests/bgp/test_bgp_multipath_relax.py Outdated
Comment thread tests/bgp/test_bgp_multipath_relax.py Outdated
@wangxin
Copy link
Copy Markdown
Collaborator

wangxin commented Jul 1, 2020

retest vsimage please

3 similar comments
@arlakshm
Copy link
Copy Markdown
Contributor Author

arlakshm commented Jul 1, 2020

retest vsimage please

@arlakshm
Copy link
Copy Markdown
Contributor Author

arlakshm commented Jul 1, 2020

retest vsimage please

@arlakshm
Copy link
Copy Markdown
Contributor Author

arlakshm commented Jul 2, 2020

retest vsimage please

@arlakshm arlakshm merged commit 622db7d into sonic-net:master Jul 2, 2020
@arlakshm arlakshm deleted the bgp_multipath branch July 2, 2020 18:05
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@daall
[202012][swss/swss-common/utilities/kernel] Update submodule (sonic-n…
6060da3 
…et#7487)

* [202012][swss/swss-common/utilities/kernel] Update submodule

sonic-swss:
- [Monitor Vlan] Fix a typo in hostif (sonic-net#1722)
- Update pool sizes during initialization from timer only (sonic-net#1708)
- [SflowMgr] SamplingRate Update by Speed Change Added (sonic-net#1721)

sonic-swss-common:
- [swss-common] Add MUX Metrics Table (sonic-net#482)
- [azp] Purge swss before installing the newly built deb package (sonic-net#472)

sonic-utilities:
- disk_check: Check & mount RO as RW using tmpfs (sonic-net#1569)
- No more IP validation as it is more likely a URL (sonic-net#1555)
- Stop PMON docker before cold and soft reboots (sonic-net#1514)
- Add soft-reboot reboot type (sonic-net#1453)
- [acl] Use a list instead of a comma-separated string for ACL port list (sonic-net#1519)
- sonic-installer: fix py3 issues in bootloader.aboot (sonic-net#1553)
- Fix unsupported fs.squashfs extraction in sonic-installer (sonic-net#1366)
- [show][config] cli support for firmware upgrade on Y-Cable (sonic-net#1528) (sonic-net#1558)

sonic-linux-kernel:
- [Mellanox] backport kernel patches for hw-management 7.0100.2303 (sonic-net#211)

Signed-off-by: Danny Allen <[email protected]>

* Update utilities w/ build fix
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca
[201811][swss] advance swss submodule head (sonic-net#6809)
94c5242 
[CRM] Safety check for division by 0 (sonic-net#1569)
[crm]: Typecast to unit64_t to avoid divide by 0 during overflow (sonic-net#1550)

Signed-off-by: Ying Xie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangxin wangxin wangxin approved these changes

@lguohan lguohan Awaiting requested review from lguohan

+1 more reviewer

@tahmed-dev tahmed-dev tahmed-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arlakshm @msosyak @lguohan @wangxin @tahmed-dev