[action] [PR:15298] fix: handle EOFError for cache reading#15318
Merged
mssonicbld merged 1 commit intosonic-net:202405from Nov 1, 2024
Merged
[action] [PR:15298] fix: handle EOFError for cache reading#15318mssonicbld merged 1 commit intosonic-net:202405from
mssonicbld merged 1 commit intosonic-net:202405from
Conversation
Description of PR When parallel run is enabled, multiple processes may try to read/write the same cache file, so there will be a small chance that the file is being written by process 1 while process 2 is reading it, which will cause EOFError in process 2. In this case, we will retry reading the file in process 2. If we still get EOFError after some retry attempts, we will return NOTEXIST to overwrite the file. In the meantime, we should also optimize how we initialize the DUT hosts when parallel run is enabled to reduce the chance of having such cache read issue. Summary: Fixes # (issue) Microsoft ADO 30031372 Approach What is the motivation for this PR? To prevent EOFError when reading cache file when parallel run is enabled. How did you do it? Add retry mechanism and optimize how DUT hosts are initialized when parallel is enabled. How did you verify/test it? I ran the updated code and can confirm parallel run is still working as expected. co-authorized by: [email protected]
8 tasks
Collaborator
Author
|
Original PR: #15298 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
When parallel run is enabled, multiple processes may try to read/write the same cache file, so there will be a small chance that the file is being written by process 1 while process 2 is reading it, which will cause EOFError in process 2. In this case, we will retry reading the file in process 2. If we still get EOFError after some retry attempts, we will return NOTEXIST to overwrite the file.
In the meantime, we should also optimize how we initialize the DUT hosts when parallel run is enabled to reduce the chance of having such cache read issue.
Summary:
Fixes # (issue) Microsoft ADO 30031372
Type of change
Back port request
Approach
What is the motivation for this PR?
To prevent EOFError when reading cache file when parallel run is enabled.
How did you do it?
Add retry mechanism and optimize how DUT hosts are initialized when parallel is enabled.
How did you verify/test it?
I ran the updated code and can confirm parallel run is still working as expected.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation