[vendor_data] Refactor ASIC checks to use dut facts#1531
Merged
lguohan merged 4 commits intosonic-net:masterfrom Apr 3, 2020
Merged
[vendor_data] Refactor ASIC checks to use dut facts#1531lguohan merged 4 commits intosonic-net:masterfrom
lguohan merged 4 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Danny Allen <[email protected]>
yxieca
approved these changes
Apr 2, 2020
neethajohn
approved these changes
Apr 2, 2020
tahmed-dev
reviewed
Apr 3, 2020
tahmed-dev
approved these changes
Apr 3, 2020
daall
changed the title
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…tilites submodules (sonic-net#7209) sonic-swss -[SFlowMgr] Sflow Crash on 200G ports handled (sonic-net#1683) -Stablize the test case (sonic-net#1679) -Remove PGs from an administratively down port. (sonic-net#1677) sonic-swss-common - fix getting hash from redis db (sonic-net#465) - [dbconnector] Initialize redisContext (sonic-net#464) sonic-utilities - route_check: Fix hanging & logging level (sonic-net#1520) - Add self timeout and crash if exceeded. (sonic-net#1502) - [reboot] User-friendly reboot cause message for kernel panic (sonic-net#1486) - [acl-loader]: do not add default deny rule for egress acl (sonic-net#1531) Signed-off-by: Danny Allen <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
* fc80eeb 2021-03-28 | [acl-loader]: do not add default deny rule for egress acl (sonic-net#1531) (HEAD, origin/201911) [lguohan] Signed-off-by: Guohan Lu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen [email protected]
Description of PR
Summary: Adds a helper method to duthost for getting the ASIC type of the DUT
Fixes # (issue)
Type of change
Approach
How did you do it?
I used the show version command to get the ASIC type rather than relying on hard-coded lists.
How did you verify/test it?
Verified that swap_syncd and advanced reboot still work as expected after the refactor.