Skipping test_static_route on Cisco 8122#15272
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Nov 15, 2024
Merged
Conversation
Contributor
Author
Contributor
Author
Contributor
|
@AnantKishorSharma could you set enable_forwarding_route_counter in next image? |
Contributor
Author
@rajendrat , can we do that in next image? |
Contributor
|
@rajendrat Can you help close the conversation? |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
What is the motivation for this PR? All 3 tests in test_static_route are failing on 8122. Tests are failing because “show flowcnt-route stats“ does not show the 1 test pkt that the test has sent. “show flowcnt-route stats“ does not show the test pkt because counter config itself failed. Counter config failed because FLOW_COUNTER_CAPABILITY was enabled recently on ASIC/SDK side for 8122 but 'enable_forwarding_route_counter' is not enabled on SONiC/asic_cfg.json on 8122. 'enable_forwarding_route_counter' is not enabled on SONiC/asic_cfg.json on 8122 because of scale limits (cannot scale more than 50k with the current LPM profile). As the feature is not enabled for this platform, need to skip this testcase How did you do it? Added a skip condition for test_static_route for 8122 platform Type of change -Test modification Back port request -202311 -202405 How did you verify/test it? Ran test_static_router.py on 8122 and verified it was skipped.
Collaborator
|
Cherry-pick PR to 202405: #15576 |
mssonicbld
pushed a commit
that referenced
this pull request
Nov 15, 2024
What is the motivation for this PR? All 3 tests in test_static_route are failing on 8122. Tests are failing because “show flowcnt-route stats“ does not show the 1 test pkt that the test has sent. “show flowcnt-route stats“ does not show the test pkt because counter config itself failed. Counter config failed because FLOW_COUNTER_CAPABILITY was enabled recently on ASIC/SDK side for 8122 but 'enable_forwarding_route_counter' is not enabled on SONiC/asic_cfg.json on 8122. 'enable_forwarding_route_counter' is not enabled on SONiC/asic_cfg.json on 8122 because of scale limits (cannot scale more than 50k with the current LPM profile). As the feature is not enabled for this platform, need to skip this testcase How did you do it? Added a skip condition for test_static_route for 8122 platform Type of change -Test modification Back port request -202311 -202405 How did you verify/test it? Ran test_static_router.py on 8122 and verified it was skipped.
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
What is the motivation for this PR? All 3 tests in test_static_route are failing on 8122. Tests are failing because “show flowcnt-route stats“ does not show the 1 test pkt that the test has sent. “show flowcnt-route stats“ does not show the test pkt because counter config itself failed. Counter config failed because FLOW_COUNTER_CAPABILITY was enabled recently on ASIC/SDK side for 8122 but 'enable_forwarding_route_counter' is not enabled on SONiC/asic_cfg.json on 8122. 'enable_forwarding_route_counter' is not enabled on SONiC/asic_cfg.json on 8122 because of scale limits (cannot scale more than 50k with the current LPM profile). As the feature is not enabled for this platform, need to skip this testcase How did you do it? Added a skip condition for test_static_route for 8122 platform Type of change -Test modification Back port request -202311 -202405 How did you verify/test it? Ran test_static_router.py on 8122 and verified it was skipped.
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
What is the motivation for this PR? All 3 tests in test_static_route are failing on 8122. Tests are failing because “show flowcnt-route stats“ does not show the 1 test pkt that the test has sent. “show flowcnt-route stats“ does not show the test pkt because counter config itself failed. Counter config failed because FLOW_COUNTER_CAPABILITY was enabled recently on ASIC/SDK side for 8122 but 'enable_forwarding_route_counter' is not enabled on SONiC/asic_cfg.json on 8122. 'enable_forwarding_route_counter' is not enabled on SONiC/asic_cfg.json on 8122 because of scale limits (cannot scale more than 50k with the current LPM profile). As the feature is not enabled for this platform, need to skip this testcase How did you do it? Added a skip condition for test_static_route for 8122 platform Type of change -Test modification Back port request -202311 -202405 How did you verify/test it? Ran test_static_router.py on 8122 and verified it was skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this PR?
All 3 tests in test_static_route are failing on 8122.
Tests are failing because “show flowcnt-route stats“ does not show the 1 test pkt that the test has sent.
“show flowcnt-route stats“ does not show the test pkt because counter config itself failed.
Counter config failed because FLOW_COUNTER_CAPABILITY was enabled recently on ASIC/SDK side for 8122 but 'enable_forwarding_route_counter' is not enabled on SONiC/asic_cfg.json on 8122.
'enable_forwarding_route_counter' is not enabled on SONiC/asic_cfg.json on 8122 because of scale limits (cannot scale more than 50k with the current LPM profile).
As the feature is not enabled for this platform, need to skip this testcase
How did you do it?
Added a skip condition for test_static_route for 8122 platform
Type of change
-Test modification
Back port request
-202311
-202405
How did you verify/test it?
Ran test_static_router.py on 8122 and verified it was skipped.