Add nbr health test into PR checker. #14473
Merged
wangxin merged 2 commits intosonic-net:masterfrom Sep 10, 2024
Merged
Conversation
wangxin
previously approved these changes
Sep 10, 2024
wangxin
approved these changes
Sep 10, 2024
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Sep 20, 2024
What is the motivation for this PR? We consider the script test_nbr_health.py as applicable to all topologies. In this PR, we update the topology mark for the script to enable it to run on all topologies and add it to the onboarding t0 and t1 PR checkers. How did you do it? Update the topology mark for script test_nbr_health.py to enable it to run on all topologies and add it to the onboarding t0 and t1 PR checkers.
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
What is the motivation for this PR? We consider the script test_nbr_health.py as applicable to all topologies. In this PR, we update the topology mark for the script to enable it to run on all topologies and add it to the onboarding t0 and t1 PR checkers. How did you do it? Update the topology mark for script test_nbr_health.py to enable it to run on all topologies and add it to the onboarding t0 and t1 PR checkers.
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
What is the motivation for this PR? We consider the script test_nbr_health.py as applicable to all topologies. In this PR, we update the topology mark for the script to enable it to run on all topologies and add it to the onboarding t0 and t1 PR checkers. How did you do it? Update the topology mark for script test_nbr_health.py to enable it to run on all topologies and add it to the onboarding t0 and t1 PR checkers.
cyw233
added
Approved for msft-202405 Branch
and removed
Cherry Pick Conflict_msft-202405
labels
Contributor
|
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#91 |
8 tasks
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Feb 21, 2025
What is the motivation for this PR? We consider the script test_nbr_health.py as applicable to all topologies. In this PR, we update the topology mark for the script to enable it to run on all topologies and add it to the onboarding t0 and t1 PR checkers. How did you do it? Update the topology mark for script test_nbr_health.py to enable it to run on all topologies and add it to the onboarding t0 and t1 PR checkers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
We consider the script
test_nbr_health.pyas applicable to all topologies. In this PR, we update the topology mark for the script to enable it to run on all topologies and add it to the onboarding t0 and t1 PR checkers.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
We consider the script
test_nbr_health.pyas applicable to all topologies. In this PR, we update the topology mark for the script to enable it to run on all topologies and add it to the onboarding t0 and t1 PR checkers.How did you do it?
Update the topology mark for script
test_nbr_health.pyto enable it to run on all topologies and add it to the onboarding t0 and t1 PR checkers.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation