Add pcbb_xoff parameters for dualtor-aa-56 topo and 50000_40m profile#13564
Merged
StormLiangMS merged 3 commits intosonic-net:masterfrom Sep 10, 2024
Merged
Add pcbb_xoff parameters for dualtor-aa-56 topo and 50000_40m profile#13564StormLiangMS merged 3 commits intosonic-net:masterfrom
StormLiangMS merged 3 commits intosonic-net:masterfrom
Conversation
vivekverma-arista
changed the title
Contributor
Author
|
@StormLiangMS and @XuChen-MSFT can you review this? |
Contributor
|
@XuChen-MSFT could you please help review it? |
XuChen-MSFT
reviewed
Jul 18, 2024
| dscp: 3 | ||
| ecn: 1 | ||
| pg: 3 | ||
| pkts_num_trig_pfc: 19939 |
Contributor
There was a problem hiding this comment.
Is this value equal with the result of "qos_param_generator.py" for same asic and topology?
Contributor
Author
|
@StormLiangMS please help merge |
lolyu
approved these changes
Sep 5, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 10, 2024
…le (sonic-net#13564) Description of PR Summary: Add pcbb_xoff parameters for dualtor-aa-56 topo and 50000_40m profile for Arista-7260CX3. Fixes sonic-net#165
Collaborator
|
Cherry-pick PR to 202405: #14484 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 10, 2024
…le (sonic-net#13564) Description of PR Summary: Add pcbb_xoff parameters for dualtor-aa-56 topo and 50000_40m profile for Arista-7260CX3. Fixes sonic-net#165
Collaborator
|
Cherry-pick PR to 202311: #14485 |
This was referenced Sep 10, 2024
Merged
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Sep 20, 2024
…le (sonic-net#13564) Description of PR Summary: Add pcbb_xoff parameters for dualtor-aa-56 topo and 50000_40m profile for Arista-7260CX3. Fixes sonic-net#165
zjswhhh
reviewed
Sep 24, 2024
Contributor
zjswhhh
left a comment
zjswhhh
left a comment
There was a problem hiding this comment.
Hi @vivekverma-arista - noticed qos/test_tunnel_qos_remap.py tests started to fail on arista 7260 acitve-active dualtor after this change. Can you check?
19:17:03 __init__._fixture_func_decorator L0073 ERROR |
KeyError('100000_300m')
Traceback (most recent call last):
File "/azp/_work/4/s/tests/common/plugins/log_section_start/__init__.py", line 71, in _fixture_func_decorator
return fixture_func(*args, **kargs)
File "/azp/_work/4/s/tests/qos/tunnel_qos_remap_base.py", line 308, in qos_config
return qos_configs['qos_params'][dut_asic][dut_topo][profile_name]
KeyError: '100000_300m'
ERROR
zjswhhh
reviewed
Sep 24, 2024
Contributor
zjswhhh
left a comment
zjswhhh
left a comment
There was a problem hiding this comment.
Also I didn't see the question How did you verify/test it? being answered in the PR description.
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
…le (sonic-net#13564) Description of PR Summary: Add pcbb_xoff parameters for dualtor-aa-56 topo and 50000_40m profile for Arista-7260CX3. Fixes sonic-net#165
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
…le (sonic-net#13564) Description of PR Summary: Add pcbb_xoff parameters for dualtor-aa-56 topo and 50000_40m profile for Arista-7260CX3. Fixes sonic-net#165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Add pcbb_xoff parameters for dualtor-aa-56 topo and 50000_40m profile for Arista-7260CX3.
Fixes #165
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation