Ignore LA error unsupported operation for poller state 1#13502
Closed
rajendrat wants to merge 2 commits intosonic-net:masterfrom
Closed
Ignore LA error unsupported operation for poller state 1#13502rajendrat wants to merge 2 commits intosonic-net:masterfrom
rajendrat wants to merge 2 commits intosonic-net:masterfrom
Conversation
Contributor
Author
|
viz @kevinwangsk , as we discussed raised this PR. Please review this. |
wsycqyz
approved these changes
Jul 1, 2024
Contributor
|
I am ok with this PR. |
Contributor
|
@rajendrat from your description, this seems a generic issue, but why we just see this one Cisco? |
Contributor
Author
This is a generic message, updated the changes. |
Contributor
We didn't see this error on any other platforms. Could you clarify why just failed on Cisco platform if this is a generic issue? |
Contributor
Author
|
This is issue fixed in the platform side. We do not need this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Log analyzer failure ERR swss#orchagent: :- doCfgSensorsTableTask: ASIC sensors : unsupported operation for poller state 1 in cisco test_platform_overtemp_fault and T1 run, it's a cosmetic issue in upstream code (in orchagent). Basically, the code prints error message even in the case of trying to enable an already enabled sensor poller. It makes more sense to either do no-op or print non-error message.
sonic-swss/orchagent/switchorch.cpp at 0c620910ada929ac5154fd548d34aa4eca36b219 · sonic-net/sonic-swss
Summary:
Fixes # (issue)
Type of change
Adding this error part of LA error ignore list.
Back port request
Approach
What is the motivation for this PR?
This is cosmetic error, that errored out the sonic-mgmt test.
How did you do it?
How did you verify/test it?
Ran sonic-mgmt test with the ignore list updated in the local sonic-mgmt repo.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation