Skip to content

Update test_plan.py to get token via az cli#13440

Merged
wangxin merged 3 commits intosonic-net:masterfrom
wangxin:test-plan-no-secret
Jul 8, 2024
Merged

Update test_plan.py to get token via az cli#13440
wangxin merged 3 commits intosonic-net:masterfrom
wangxin:test-plan-no-secret

Conversation

@wangxin
Copy link
Copy Markdown
Collaborator

@wangxin wangxin commented Jun 25, 2024

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

This is the second part of the work for eliminating client secrets.

This change depends on merge of #13435.

How did you do it?

This change updated the test_plan.py to get access token by az cli. For the az cli command to work, the task calling test_plan.py must be wrapped in an AzureCLI azure pipeline task.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wangxin
Update test_plan.py to get token via az cli
d91a5c6 
This is the second part of the work for eliminating client secrets.

This change depends on merge of sonic-net#13435.

This change updated the test_plan.py to get access token by az cli. For the az cli command to work, the task calling test_plan.py must be wrapped in an AzureCLI azure pipeline task.

Signed-off-by: Xin Wang <[email protected]>
@wangxin wangxin requested review from ZhaohuiS and lerry-lee June 25, 2024 00:36
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 25, 2024

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

.azure-pipelines/test_plan.py:168:26: E203 whitespace before ':'

flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@wangxin wangxin marked this pull request as ready for review June 25, 2024 07:50
lerry-lee
lerry-lee approved these changes Jun 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lerry-lee lerry-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

StormLiangMS
StormLiangMS approved these changes Jun 25, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with a question

StormLiangMS
StormLiangMS approved these changes Jun 25, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with a question.

.azure-pipelines/test_plan.py
]:
scope = "api://sonic-testbed-tools-prod/.default"
return scope
# def get_scope(elastictest_url):
Copy link
Copy Markdown
Collaborator

@StormLiangMS StormLiangMS Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this code other than keep them in the source code with comment out?

Copy link
Copy Markdown
Collaborator Author

@wangxin wangxin Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it in subsequent PRs.

@wangxin wangxin merged commit d824bdc into sonic-net:master Jul 8, 2024
@wangxin wangxin mentioned this pull request Jul 8, 2024
Closed
8 tasks
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jul 10, 2024

@wangxin PR conflicts with 202311 branch

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jul 10, 2024

@wangxin PR conflicts with 202305 branch

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jul 10, 2024
@wangxin @mssonicbld
Update test_plan.py to get token via az cli (sonic-net#13440)
5dfdeda 
What is the motivation for this PR?
This is the second part of the work for eliminating client secrets.

This change depends on merge of sonic-net#13435.

How did you do it?
This change updated the test_plan.py to get access token by az cli. For the az cli command to work, the task calling test_plan.py must be wrapped in an AzureCLI azure pipeline task.

Signed-off-by: Xin Wang <[email protected]>
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jul 10, 2024

Cherry-pick PR to 202405: #13606

@mssonicbld mssonicbld mentioned this pull request Jul 10, 2024
Closed
8 tasks
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jul 10, 2024

@wangxin PR conflicts with 202205 branch

arista-hpandya pushed a commit to arista-hpandya/sonic-mgmt that referenced this pull request Oct 2, 2024
@wangxin @arista-hpandya
Update test_plan.py to get token via az cli (sonic-net#13440)
dbafa74 
What is the motivation for this PR?
This is the second part of the work for eliminating client secrets.

This change depends on merge of sonic-net#13435.

How did you do it?
This change updated the test_plan.py to get access token by az cli. For the az cli command to work, the task calling test_plan.py must be wrapped in an AzureCLI azure pipeline task.

Signed-off-by: Xin Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lerry-lee lerry-lee lerry-lee approved these changes

@StormLiangMS StormLiangMS StormLiangMS approved these changes

@ZhaohuiS ZhaohuiS Awaiting requested review from ZhaohuiS

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wangxin @mssonicbld @lerry-lee @StormLiangMS