Revert "Fix test_qos_sai teardown for dualtor (#13363)"#13436
Closed
XuChen-MSFT wants to merge 1 commit intosonic-net:masterfrom
Closed
Revert "Fix test_qos_sai teardown for dualtor (#13363)"#13436XuChen-MSFT wants to merge 1 commit intosonic-net:masterfrom
XuChen-MSFT wants to merge 1 commit intosonic-net:masterfrom
Conversation
This reverts commit 20c8cdf.
XuChen-MSFT
requested review from
StormLiangMS,
lolyu and
vivekrnv
and removed request for
vivekrnv
9 tasks
Contributor
|
@XuChen-MSFT On which platform and topology was this failure seen? It would help us to debug further. Before raising this pull request this fix was tested across Arista platforms and topologies and no issues were seen. Again it may be another race condition among the fixtures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 20c8cdf.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
PR #13363 caused qos sai tests error
How did you do it?
reverty PR #13363 can help.
How did you verify/test it?
pass qos sai test on local after revert pr #13363
Any platform specific information?
generic error
Supported testbed topology if it's a new test case?
Documentation