Use is_python3=True in test_ipinip_hash_negative ptf_runner#13326
Merged
wangxin merged 1 commit intosonic-net:masterfrom Jun 18, 2024
Merged
Use is_python3=True in test_ipinip_hash_negative ptf_runner#13326wangxin merged 1 commit intosonic-net:masterfrom
wangxin merged 1 commit intosonic-net:masterfrom
Conversation
wangxin
approved these changes
Jun 18, 2024
Contributor
|
@arlakshm can you help add a label to backport to 202405? |
Contributor
|
@bingwang-ms, @wangxin, can you help cherry-pick this fix in |
Contributor
|
Can we merge this PR in 202311 Also? |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 30, 2024
…t#13326) test_ipinip_hash_negative was using ptf_runner without passing is_python3=True. This resulted in some code which did string formatting unique to Python3 to assert: "Traceback (most recent call last):" " File \"/usr/bin/ptf\", line 522, in <module>" " test_modules = load_test_modules(config)" " File \"/usr/bin/ptf\", line 413, in load_test_modules" " mod = imp.load_module(modname, *imp.find_module(modname, [root]))" " File \"ptftests/py3/pfc_wd_background_traffic.py\", line 40" " print(f\"traffic from {src_port} to {dst_port}: {queue} \")" " ^" "SyntaxError: invalid syntax"] Summary: Fixes sonic-net#13313
Collaborator
|
Cherry-pick PR to 202311: #13881 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 30, 2024
…t#13326) test_ipinip_hash_negative was using ptf_runner without passing is_python3=True. This resulted in some code which did string formatting unique to Python3 to assert: "Traceback (most recent call last):" " File \"/usr/bin/ptf\", line 522, in <module>" " test_modules = load_test_modules(config)" " File \"/usr/bin/ptf\", line 413, in load_test_modules" " mod = imp.load_module(modname, *imp.find_module(modname, [root]))" " File \"ptftests/py3/pfc_wd_background_traffic.py\", line 40" " print(f\"traffic from {src_port} to {dst_port}: {queue} \")" " ^" "SyntaxError: invalid syntax"] Summary: Fixes sonic-net#13313
8 tasks
Collaborator
|
Cherry-pick PR to 202405: #13882 |
8 tasks
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jul 30, 2024
test_ipinip_hash_negative was using ptf_runner without passing is_python3=True.
This resulted in some code which did string formatting unique to Python3 to assert:
"Traceback (most recent call last):"
" File \"/usr/bin/ptf\", line 522, in <module>"
" test_modules = load_test_modules(config)"
" File \"/usr/bin/ptf\", line 413, in load_test_modules"
" mod = imp.load_module(modname, *imp.find_module(modname, [root]))"
" File \"ptftests/py3/pfc_wd_background_traffic.py\", line 40"
" print(f\"traffic from {src_port} to {dst_port}: {queue} \")"
" ^"
"SyntaxError: invalid syntax"]
Summary:
Fixes #13313
mssonicbld
pushed a commit
that referenced
this pull request
Jul 30, 2024
test_ipinip_hash_negative was using ptf_runner without passing is_python3=True.
This resulted in some code which did string formatting unique to Python3 to assert:
"Traceback (most recent call last):"
" File \"/usr/bin/ptf\", line 522, in <module>"
" test_modules = load_test_modules(config)"
" File \"/usr/bin/ptf\", line 413, in load_test_modules"
" mod = imp.load_module(modname, *imp.find_module(modname, [root]))"
" File \"ptftests/py3/pfc_wd_background_traffic.py\", line 40"
" print(f\"traffic from {src_port} to {dst_port}: {queue} \")"
" ^"
"SyntaxError: invalid syntax"]
Summary:
Fixes #13313
Closed
8 tasks
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
* [yang] Change swss-event, dhcp-relay-event leafref to string (sonic-net#13326) Why I did it Do not require leafref as part of yang. Only need string to compare whether string received from event matches what is possible for ifname. How I did it How to verify it Run UT * Add fix to monit_regex.json for catching mem_usage and cpu_usage (sonic-net#14954) Why I did it Current regex not able to capture logs, modify regex to capture syslog messages Work item tracking Microsoft ADO (number only): 13366345 How I did it Code change How to verify it sonic-mgmt test case * Update usage leaf in sonic-events-host yang models (sonic-net#15805) #### Why I did it event yang models for usage currently use int as type for usage leaf, needs to be of type decimal64 ##### Work item tracking - Microsoft ADO **(number only)**:17747466 #### How I did it Update yang models and UT #### How to verify it UT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
test_ipinip_hash_negativewas usingptf_runnerwithout passingis_python3=True.This resulted in some code which did string formatting unique to Python3 to assert:
Summary:
Fixes #13313
Type of change
Back port request