Skip to content

Fix IPv6 NTP test case missing an import#12494

Merged
yejianquan merged 2 commits intosonic-net:masterfrom
saiarcot895:fix-ipv6-ntp
Apr 18, 2024
Merged

Fix IPv6 NTP test case missing an import#12494
yejianquan merged 2 commits intosonic-net:masterfrom
saiarcot895:fix-ipv6-ntp

Conversation

@saiarcot895
Copy link
Copy Markdown
Contributor

@saiarcot895 saiarcot895 commented Apr 17, 2024

Description of PR

Summary:
Fixes # (issue)

Microsoft ADO 27674068

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

Somehow, the import for setup_ntp got missed. Add it in.

How did you do it?

How did you verify/test it?

Verified on physical device

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Somehow, the import for setup_ntp got missed. Add it in.

Signed-off-by: Saikrishna Arcot <[email protected]>
@mssonicbld
Copy link
Copy Markdown
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/ip/test_mgmt_ipv6_only.py:10:1: F401 'tests.ntp.test_ntp.setup_ntp' imported but unused

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Signed-off-by: Saikrishna Arcot <[email protected]>
@yejianquan yejianquan merged commit 3be5089 into sonic-net:master Apr 18, 2024
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Apr 18, 2024
Description of PR
Summary:
Fixes # (issue)

Microsoft ADO 27674068

Approach
What is the motivation for this PR?
Somehow, the import for setup_ntp got missed. Add it in.

How did you do it?
How did you verify/test it?
Verified on physical device

co-authorized by: [email protected]
@mssonicbld
Copy link
Copy Markdown
Collaborator

@saiarcot895 PR conflicts with 202311 branch

@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202305: #12508

mssonicbld pushed a commit that referenced this pull request Apr 18, 2024
Description of PR
Summary:
Fixes # (issue)

Microsoft ADO 27674068

Approach
What is the motivation for this PR?
Somehow, the import for setup_ntp got missed. Add it in.

How did you do it?
How did you verify/test it?
Verified on physical device

co-authorized by: [email protected]
@saiarcot895 saiarcot895 deleted the fix-ipv6-ntp branch April 18, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants