Set the RTC from the system time after NTP sync during deploy-mg#12212
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Mar 28, 2024
Merged
Set the RTC from the system time after NTP sync during deploy-mg#12212StormLiangMS merged 1 commit intosonic-net:masterfrom
StormLiangMS merged 1 commit intosonic-net:masterfrom
Conversation
SONiC currently does not support NTP long jump. In case there is a big difference between RTC and NTP server's time, the NTP service may long time to have system time synched with NTP server. During deploy-mg, there are steps to force sync DUT's system time to NTP server. However, during tests, the DUT may be power-cycled. After power cycle, RTC time will be used as system time. In case the difference between RTC and NTP server is too big, the system time of DUT may be inaccurate because NTP long jump is not supported yet. This change added a step to set system time to RTC after system time is force synched with NTP server during deploy minigraph. With this change, the time difference between DUT and NTP server won't be too big after DUT is power-cycled. Signed-off-by: Xin Wang <[email protected]>
ganglyu
approved these changes
Mar 28, 2024
lizhijianrd
approved these changes
Mar 28, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 28, 2024
…ic-net#12212) SONiC currently does not support NTP long jump. In case there is a big difference between RTC and NTP server's time, the NTP service may long time to have system time synched with NTP server. During deploy-mg, there are steps to force sync DUT's system time to NTP server. However, during tests, the DUT may be power-cycled. After power cycle, RTC time will be used as system time. In case the difference between RTC and NTP server is too big, the system time of DUT may be inaccurate because NTP long jump is not supported yet. This change added a step to set system time to RTC after system time is force synched with NTP server during deploy minigraph. With this change, the time difference between DUT and NTP server won't be too big after DUT is power-cycled. Signed-off-by: Xin Wang <[email protected]>
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 28, 2024
…ic-net#12212) SONiC currently does not support NTP long jump. In case there is a big difference between RTC and NTP server's time, the NTP service may long time to have system time synched with NTP server. During deploy-mg, there are steps to force sync DUT's system time to NTP server. However, during tests, the DUT may be power-cycled. After power cycle, RTC time will be used as system time. In case the difference between RTC and NTP server is too big, the system time of DUT may be inaccurate because NTP long jump is not supported yet. This change added a step to set system time to RTC after system time is force synched with NTP server during deploy minigraph. With this change, the time difference between DUT and NTP server won't be too big after DUT is power-cycled. Signed-off-by: Xin Wang <[email protected]>
Collaborator
|
Cherry-pick PR to 202305: #12217 |
Collaborator
|
Cherry-pick PR to 202311: #12218 |
This was referenced Mar 28, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Mar 28, 2024
) SONiC currently does not support NTP long jump. In case there is a big difference between RTC and NTP server's time, the NTP service may long time to have system time synched with NTP server. During deploy-mg, there are steps to force sync DUT's system time to NTP server. However, during tests, the DUT may be power-cycled. After power cycle, RTC time will be used as system time. In case the difference between RTC and NTP server is too big, the system time of DUT may be inaccurate because NTP long jump is not supported yet. This change added a step to set system time to RTC after system time is force synched with NTP server during deploy minigraph. With this change, the time difference between DUT and NTP server won't be too big after DUT is power-cycled. Signed-off-by: Xin Wang <[email protected]>
mssonicbld
pushed a commit
that referenced
this pull request
Mar 28, 2024
) SONiC currently does not support NTP long jump. In case there is a big difference between RTC and NTP server's time, the NTP service may long time to have system time synched with NTP server. During deploy-mg, there are steps to force sync DUT's system time to NTP server. However, during tests, the DUT may be power-cycled. After power cycle, RTC time will be used as system time. In case the difference between RTC and NTP server is too big, the system time of DUT may be inaccurate because NTP long jump is not supported yet. This change added a step to set system time to RTC after system time is force synched with NTP server during deploy minigraph. With this change, the time difference between DUT and NTP server won't be too big after DUT is power-cycled. Signed-off-by: Xin Wang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
SONiC currently does not support NTP long jump. In case there is a big difference between RTC and NTP server's time, the NTP service may long time to have system time synched with NTP server.
During deploy-mg, there are steps to force sync DUT's system time to NTP server. However, during tests, the DUT may be power-cycled. After power cycle, RTC time will be used as system time. In case the difference between RTC and NTP server is too big, the system time of DUT may be inaccurate because NTP long jump is not supported yet.
How did you do it?
This change added a step to set system time to RTC after system time is force synched with NTP server during deploy minigraph.
With this change, the time difference between DUT and NTP server won't be too big after DUT is power-cycled.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation