Fix syntax error in conditional mark for copp/test_copp.py.#11994
Closed
vivekverma-arista wants to merge 2 commits intosonic-net:masterfrom
Closed
Fix syntax error in conditional mark for copp/test_copp.py.#11994vivekverma-arista wants to merge 2 commits intosonic-net:masterfrom
vivekverma-arista wants to merge 2 commits intosonic-net:masterfrom
Conversation
Contributor
Author
|
This was fixed in #8827, hence closing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix syntax error in conditional mark for copp/test_copp.py.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Syntax error introduced by: #5097
copp/test_copp.pydon't get skipped even where they are suppose to as the conditional mark evaluation fails as follows :-How did you do it?
Corrected the syntax.
The fix is 't2' not in topo_name. The substring check is used in order to allow the test to run on all 't2-*' topologies with out explicitly having to list them all in the array for the explicit
topo_namein checks.How did you verify/test it?
Verified on Arista-7260CX3 platform that copp/test_copp.py get skipped correctly on t0-dualtor.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation