Skip to content

Wrong DIP on packet#1171

Merged
yxieca merged 2 commits intosonic-net:masterfrom
crzas:copp
Jul 8, 2020
Merged

Wrong DIP on packet#1171
yxieca merged 2 commits intosonic-net:masterfrom
crzas:copp

Conversation

@crzas
Copy link
Copy Markdown
Contributor

@crzas crzas commented Oct 22, 2019

Description of PR

it cannot receive BGP, SNMP, SSH IP2ME packet on t1-lag and the root cause is copp_test.py config wrong DIP on packet.

Getting correct DIP solution:
1.add the "- minig_bgp={{ minigraph_bgp }}" to call ptf_runner.yml as input argument in the copp.yml
2. Filter IPv6 of minigraph_bgp and in copp_test.py.

Summary:
Fixes # (issue)

Type of change

  • [v] Bug fix
  • [] Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

it cannot receive BGP, SNMP, SSH IP2ME packet on t1-lag and the root cause is copp_test.py config wrong DIP on packet
@daall
Copy link
Copy Markdown
Contributor

daall commented Jul 7, 2020

retest vsimage please

1 similar comment
@yxieca
Copy link
Copy Markdown
Collaborator

yxieca commented Jul 8, 2020

retest vsimage please

@yxieca yxieca merged commit 05dec86 into sonic-net:master Jul 8, 2020
yxieca added a commit that referenced this pull request Jul 9, 2020
* wrong DIP on packet

it cannot receive BGP, SNMP, SSH IP2ME packet on t1-lag and the root cause is copp_test.py config wrong DIP on packet

* fix comment indentation

Co-authored-by: Ying Xie <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Why I did it
sonic-sairedis

53488e9 - [sai_failure_dump]Invoking dump during SAI failure (Update Mellanox buffer profiles config sonic-net#1198) (15 hours ago) [Sudharsan Dhamal Gopalarathnam]
85921af - [Mellanox] Enable DSCP remapping by using SAI attribute ([Nephos] Updating download link for SAI and SDK sonic-net#1188) (15 hours ago) [Stephen Sun]
82f2cd7 - Switch to using stock gcovr 5.2 (Add service to config hostname based on configdb sonic-net#1174) (15 hours ago) [Saikrishna Arcot]
3a6c60d - [ppi]: Enable bulk API. ([Aboot] Declare flash_size for all platform sonic-net#1171) (15 hours ago) [Nazarii Hnydyn]
f1303cb - Use github code scanning instead of LGTM (sonic-net#1160) (15 hours ago) [Liu Shilong]
b1972d9 - Fix for [EVPN] When MAC moves from remote end point to local, ASIC DB fields are not updated properly for the mac #11503Update NotificationProcessor.cpp ([libteam] Add fallback support for single-member-port LAG sonic-net#1118) (15 hours ago) [anilkpan]
How I did it
How to verify it
arawat-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Apr 9, 2026
…route counter timeout (sonic-net#1171)

### Description of PR

[snmp] fix _test_snmp_bgp_down using wrong OID and increase route
counter timeout

`_test_snmp_bgp_down` hardcoded `INET_CIDR_ROUTE_NUMBER_OID`
(`1.3.6.1.2.1.4.24.6.0`)
in 3 places instead of using the `snmp_oid` parameter passed by callers.
This caused
`test_snmp_ipCidrRouteNumber_bgp_down` to query the wrong OID
(inetCidrRoute `.6.0`
instead of ipCidrRoute `.3.0`), leading to timeout failures.

Also increase `ROUTE_COUNTER_TEST_INTERVAL` to 5s and
`ROUTE_COUNTER_UPDATE_TIMEOUT`
to 10s (from 3s/6s) since inetCidrRoute takes 6-12s to repopulate after
BGP restart,
making the 6s timeout too tight.

Fixes # (issue)

### Type of change

- [x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [x] 202505
- [x] 202511

### Approach
#### What is the motivation for this PR?

`test_snmp_ipCidrRouteNumber_bgp_down` was failing on gold207 because
`_test_snmp_bgp_down`
hardcoded the wrong SNMP OID (`INET_CIDR_ROUTE_NUMBER_OID =
1.3.6.1.2.1.4.24.6.0`) instead
of using the `snmp_oid` parameter. The `ipCidrRoute` test should query
OID `.4.24.3.0`
but was querying `.4.24.6.0` (inetCidrRoute).

Additionally, the 6s recovery timeout was insufficient — inetCidrRoute
takes 6-12s to
repopulate after BGP restart.

#### How did you do it?

- Replace 3 hardcoded `INET_CIDR_ROUTE_NUMBER_OID` references in
`_test_snmp_bgp_down`
  with the `snmp_oid` parameter
- Increase `ROUTE_COUNTER_TEST_INTERVAL` from 3s to 5s and
`ROUTE_COUNTER_UPDATE_TIMEOUT`
  from 6s to 10s in `tests/common/fixtures/route_counter.py`

#### How did you verify/test it?

Observed test failure on gold207, analyzed root cause from logs, and
verified the fix
addresses both the wrong-OID issue and the timing issue.

#### Any platform specific information?

N/A

#### Supported testbed topology if it's a new test case?

N/A

### Documentation

N/A

NOTE: This is an AI-assisted PR, please review accordingly

---------

Signed-off-by: Anders Linn <[email protected]>
Co-authored-by: Claude Sonnet 4.6 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants