[Snappi] Bug fix for checking counters to account for forwarding lag#11704
Merged
yxieca merged 1 commit intosonic-net:masterfrom Feb 15, 2024
Merged
Conversation
bingwang-ms
approved these changes
Feb 14, 2024
auspham
added a commit
to auspham/sonic-mgmt
that referenced
this pull request
Jan 28, 2025
chore: migrate sonic-net#11704 to multidut_helper chore: migrate sonic-net#15002 to multidut_helper Signed-off-by: Austin Pham <[email protected]> chore: fix disable_pfcwd Signed-off-by: Austin Pham <[email protected]> chore: migrate sonic-net#9847 to test_multidut_pfc_pause_lossless_with_snappi Signed-off-by: Austin Pham <[email protected]>
11 tasks
auspham
added a commit
to auspham/sonic-mgmt
that referenced
this pull request
Jan 30, 2025
chore: migrate sonic-net#11704 to multidut_helper chore: migrate sonic-net#15002 to multidut_helper Signed-off-by: Austin Pham <[email protected]> chore: fix disable_pfcwd Signed-off-by: Austin Pham <[email protected]> chore: migrate sonic-net#9847 to test_multidut_pfc_pause_lossless_with_snappi Signed-off-by: Austin Pham <[email protected]>
auspham
added a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 2, 2025
chore: migrate sonic-net#11704 to multidut_helper chore: migrate sonic-net#15002 to multidut_helper Signed-off-by: Austin Pham <[email protected]> chore: fix disable_pfcwd Signed-off-by: Austin Pham <[email protected]> chore: migrate sonic-net#9847 to test_multidut_pfc_pause_lossless_with_snappi Signed-off-by: Austin Pham <[email protected]>
auspham
added a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2025
chore: migrate sonic-net#11704 to multidut_helper chore: migrate sonic-net#15002 to multidut_helper Signed-off-by: Austin Pham <[email protected]> chore: fix disable_pfcwd Signed-off-by: Austin Pham <[email protected]> chore: migrate sonic-net#9847 to test_multidut_pfc_pause_lossless_with_snappi Signed-off-by: Austin Pham <[email protected]>
auspham
added a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 4, 2025
chore: migrate sonic-net#11704 to multidut_helper chore: migrate sonic-net#15002 to multidut_helper Signed-off-by: Austin Pham <[email protected]> chore: fix disable_pfcwd Signed-off-by: Austin Pham <[email protected]> chore: migrate sonic-net#9847 to test_multidut_pfc_pause_lossless_with_snappi Signed-off-by: Austin Pham <[email protected]>
yejianquan
pushed a commit
that referenced
this pull request
Feb 7, 2025
Description of PR Summary: Fixes # (issue) 31085729 Migrate the following PR: [Snappi] Update test PFC pause frame functionality to include DUT counter polling #9847 Fixed the failure of test_valid_pfc_frame_with_snappi.py in Cisco DUT #15002 [Snappi] Bug fix for checking counters to account for forwarding lag #11704 Approach What is the motivation for this PR? Migrate PRs for pfc test cases to t2 Signed-off-by: Austin Pham <[email protected]>
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 7, 2025
Description of PR Summary: Fixes # (issue) 31085729 Migrate the following PR: [Snappi] Update test PFC pause frame functionality to include DUT counter polling sonic-net#9847 Fixed the failure of test_valid_pfc_frame_with_snappi.py in Cisco DUT sonic-net#15002 [Snappi] Bug fix for checking counters to account for forwarding lag sonic-net#11704 Approach What is the motivation for this PR? Migrate PRs for pfc test cases to t2 Signed-off-by: Austin Pham <[email protected]>
11 tasks
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Feb 21, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) 31085729 Migrate the following PR: - sonic-net#9847 - sonic-net#15002 - sonic-net#11704 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? Migrate PRs for pfc test cases to t2 #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
Description of PR Summary: Fixes # (issue) 31085729 Migrate the following PR: [Snappi] Update test PFC pause frame functionality to include DUT counter polling sonic-net#9847 Fixed the failure of test_valid_pfc_frame_with_snappi.py in Cisco DUT sonic-net#15002 [Snappi] Bug fix for checking counters to account for forwarding lag sonic-net#11704 Approach What is the motivation for this PR? Migrate PRs for pfc test cases to t2 Signed-off-by: Austin Pham <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: The current devices used in RDMA testing recently migrated to a L1 switch setup resulting in longer cables (5x) and forwarding lag that allows for the storage of greater frames in the cable. This lag is not accounted for in the tolerance threshold of 5%. As a result, the code has been modified to poll the TGEN counters at verification time after all traffic flows have been paused to allow for additional frames in the cable + buffer to propagate to the receiving port. There is also a bit of code cleanup done.
Fixes (issue) #11713
Type of change
Back port request
Approach
What is the motivation for this PR?
Bug fix for nightly test failure
How did you do it?
Polled TGEN device at end of test (at verification time) as done with DUT polling
How did you verify/test it?
Tested on lab device
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation