[action] [PR:10886] platform_tests: Fix skip_modules check in test_power_budget_info.py#11514
Merged
mssonicbld merged 1 commit intosonic-net:202305from Feb 1, 2024
Merged
Conversation
…onic-net#10886) There is an extra space in the linecard name in mod_name which prevents the linecard name from matching that in the module skip list. This PR removes the extra whitespace from mod_name so the linecard name correctly matches. Summary: Fixes sonic-net#10885
7 tasks
Collaborator
Author
|
Original PR: #10886 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
There is an extra space in the linecard name in
mod_namewhich prevents the linecard name from matching that in the module skip list. This PR removes the extra whitespace frommod_nameso the linecard name correctly matches.Summary:
Fixes #10885
Type of change
Back port request
Approach
What is the motivation for this PR?
This PR fixes a bug which causes a spurious test failure in
test_power_budget_info.py.How did you do it?
Remove the spurious whitespace that caused the linecard name to not match the value in the skip list.
How did you verify/test it?
Manually running
test_power_budget_info.pyon a device in our testbed with an extra linecard that should be skipped during the test.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation