[vlan] add ignore loganalyzer error to autostate-disabled test#11383
Merged
wangxin merged 2 commits intosonic-net:masterfrom Jan 29, 2024
Merged
Conversation
lizhijianrd
reviewed
Jan 25, 2024
| """ | ||
| duthost = duthosts[rand_one_dut_hostname] | ||
| if loganalyzer: | ||
| loganalyzer_ignore_regex = [ |
Contributor
There was a problem hiding this comment.
Is this fix for all platform or only E1031? If only E1031, I think it's better to check hwsku from duthost first.
wangxin
approved these changes
Jan 29, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 29, 2024
…-net#11383) What is the motivation for this PR? Ignore potential error that is expected to pass test_autostate_disabled. How did you do it? Add ignore loganalyzer error How did you verify/test it? Run test manually
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 29, 2024
…-net#11383) What is the motivation for this PR? Ignore potential error that is expected to pass test_autostate_disabled. How did you do it? Add ignore loganalyzer error How did you verify/test it? Run test manually
Collaborator
|
Cherry-pick PR to 202311: #11413 |
Collaborator
|
Cherry-pick PR to 202305: #11414 |
This was referenced Jan 29, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Jan 29, 2024
What is the motivation for this PR? Ignore potential error that is expected to pass test_autostate_disabled. How did you do it? Add ignore loganalyzer error How did you verify/test it? Run test manually
mssonicbld
pushed a commit
that referenced
this pull request
Jan 29, 2024
What is the motivation for this PR? Ignore potential error that is expected to pass test_autostate_disabled. How did you do it? Add ignore loganalyzer error How did you verify/test it? Run test manually
mhen1
pushed a commit
to mhen1/sonic-mgmt
that referenced
this pull request
Jan 31, 2024
…-net#11383) What is the motivation for this PR? Ignore potential error that is expected to pass test_autostate_disabled. How did you do it? Add ignore loganalyzer error How did you verify/test it? Run test manually
8 tasks
wangxin
pushed a commit
that referenced
this pull request
Feb 23, 2024
In PR #11383, we try to ignore autoneg related error logs in loganalyzer. However, some logs with below format are not marched by previous regex. Feb 17 11:39:40.131019 e1031-1 ERR swss#orchagent: message repeated 2 times: [ :- doPortTask: Ethernet52: autoneg is not supported (cap=0)] In current PR, I updated the regex to ignore above logs. What is the motivation for this PR? Update loganalyzer regex in test_autostate_disabled to ensure all the autoneg related error logs are ignored on Celestica-E1031 platform. How did you do it? Updated regex in testcase. How did you verify/test it? Verified on Celestica-E1031 M0 testbed with SONiC.202305 image. Any platform specific information? This PR only for Celestica-E1031 platform.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 23, 2024
…t#11757) In PR sonic-net#11383, we try to ignore autoneg related error logs in loganalyzer. However, some logs with below format are not marched by previous regex. Feb 17 11:39:40.131019 e1031-1 ERR swss#orchagent: message repeated 2 times: [ :- doPortTask: Ethernet52: autoneg is not supported (cap=0)] In current PR, I updated the regex to ignore above logs. What is the motivation for this PR? Update loganalyzer regex in test_autostate_disabled to ensure all the autoneg related error logs are ignored on Celestica-E1031 platform. How did you do it? Updated regex in testcase. How did you verify/test it? Verified on Celestica-E1031 M0 testbed with SONiC.202305 image. Any platform specific information? This PR only for Celestica-E1031 platform.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 23, 2024
…t#11757) In PR sonic-net#11383, we try to ignore autoneg related error logs in loganalyzer. However, some logs with below format are not marched by previous regex. Feb 17 11:39:40.131019 e1031-1 ERR swss#orchagent: message repeated 2 times: [ :- doPortTask: Ethernet52: autoneg is not supported (cap=0)] In current PR, I updated the regex to ignore above logs. What is the motivation for this PR? Update loganalyzer regex in test_autostate_disabled to ensure all the autoneg related error logs are ignored on Celestica-E1031 platform. How did you do it? Updated regex in testcase. How did you verify/test it? Verified on Celestica-E1031 M0 testbed with SONiC.202305 image. Any platform specific information? This PR only for Celestica-E1031 platform.
8 tasks
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Feb 23, 2024
In PR #11383, we try to ignore autoneg related error logs in loganalyzer. However, some logs with below format are not marched by previous regex. Feb 17 11:39:40.131019 e1031-1 ERR swss#orchagent: message repeated 2 times: [ :- doPortTask: Ethernet52: autoneg is not supported (cap=0)] In current PR, I updated the regex to ignore above logs. What is the motivation for this PR? Update loganalyzer regex in test_autostate_disabled to ensure all the autoneg related error logs are ignored on Celestica-E1031 platform. How did you do it? Updated regex in testcase. How did you verify/test it? Verified on Celestica-E1031 M0 testbed with SONiC.202305 image. Any platform specific information? This PR only for Celestica-E1031 platform.
mssonicbld
pushed a commit
that referenced
this pull request
Feb 23, 2024
In PR #11383, we try to ignore autoneg related error logs in loganalyzer. However, some logs with below format are not marched by previous regex. Feb 17 11:39:40.131019 e1031-1 ERR swss#orchagent: message repeated 2 times: [ :- doPortTask: Ethernet52: autoneg is not supported (cap=0)] In current PR, I updated the regex to ignore above logs. What is the motivation for this PR? Update loganalyzer regex in test_autostate_disabled to ensure all the autoneg related error logs are ignored on Celestica-E1031 platform. How did you do it? Updated regex in testcase. How did you verify/test it? Verified on Celestica-E1031 M0 testbed with SONiC.202305 image. Any platform specific information? This PR only for Celestica-E1031 platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Add ignore loganalyzer error to autostate-disabled test
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Ignore potential error that is expected to pass test_autostate_disabled.
How did you do it?
Add ignore loganalyzer error
How did you verify/test it?
Run test manually
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation