Update test_pg_headroom_update to check buffer mode before running#11254
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Feb 12, 2024
Merged
Update test_pg_headroom_update to check buffer mode before running#11254liat-grozovik merged 1 commit intosonic-net:masterfrom
liat-grozovik merged 1 commit intosonic-net:masterfrom
Conversation
Check and skip test if it is dynamic model Dynamic buffer config can not be updated Change-Id: I2358fb6538994a731ac9eabbec58f4103f740e53
nhe-NV
approved these changes
Jan 11, 2024
liat-grozovik
approved these changes
Feb 12, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 4, 2024
…onic-net#11254) When buffer mode is dynamic type, the dut would not support updating qos configuration. Base on the fact, I add a check to validate if the buffer mode is dynamic and skip test if it is. Change-Id: I2358fb6538994a731ac9eabbec58f4103f740e53
Collaborator
|
Cherry-pick PR to 202305: #11861 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 4, 2024
…onic-net#11254) When buffer mode is dynamic type, the dut would not support updating qos configuration. Base on the fact, I add a check to validate if the buffer mode is dynamic and skip test if it is. Change-Id: I2358fb6538994a731ac9eabbec58f4103f740e53
Collaborator
|
Cherry-pick PR to 202311: #11863 |
This was referenced Mar 4, 2024
Merged
mssonicbld
pushed a commit
that referenced
this pull request
Mar 4, 2024
…11254) When buffer mode is dynamic type, the dut would not support updating qos configuration. Base on the fact, I add a check to validate if the buffer mode is dynamic and skip test if it is. Change-Id: I2358fb6538994a731ac9eabbec58f4103f740e53
mssonicbld
pushed a commit
that referenced
this pull request
Mar 4, 2024
…11254) When buffer mode is dynamic type, the dut would not support updating qos configuration. Base on the fact, I add a check to validate if the buffer mode is dynamic and skip test if it is. Change-Id: I2358fb6538994a731ac9eabbec58f4103f740e53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
When buffer mode is dynamic type, the dut would not support updating qos configuration.
Base on the fact, I add a check to validate if the buffer mode is dynamic and skip test if it is.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Make the script more stable.
How did you do it?
Add a check
How did you verify/test it?
Run it in internal regression.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation