Closed
Conversation
bpar9
requested changes
Mar 15, 2024
Collaborator
bpar9
left a comment
bpar9
left a comment
There was a problem hiding this comment.
can you also change Churchill to actual Platform name/id in description
|
|
||
| cisco_hwskus: ["Cisco-8102-C64", "Cisco-8111-O32", "Cisco-8111-O64", "Cisco-8800-LC-48H-C48"] | ||
| cisco-8000_gb_hwskus: ["Cisco-8102-C64", "Cisco-88-LC0-36FH-M-O36", "Cisco-8101-O8C48", "Cisco-8101-O32", "Cisco-88-LC0-36FH-O36"] | ||
| cisco-8000_gb_hwskus: ["Cisco-8102-C64", "Cisco-88-LC0-36FH-M-O36", "Cisco-8101-O8C48", "Cisco-8101-O32", "Cisco-88-LC0-36FH-O36", "32x400Gb"] |
Collaborator
There was a problem hiding this comment.
can you check if the sku can be verified along with Vendor name like 'Cisco-xxx' similar to other SKUs
Contributor
Author
There was a problem hiding this comment.
32x400Gb will not be used moving forward. Hence closing this PR
Contributor
Author
|
32x400Gb will not be used moving forward. Hence closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
To support Cisco churchill platforms to run sonic mgmt suites
Added 32x400Gb hwsku to port_utils
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
To support churchill platforms to run sonic mgmt suites
Added 32x400Gb hwsku to port_utils
How did you do it?
How did you verify/test it?
deployed minigraph with the changes and it worked
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation