Add docker0's IPv6 address since it was removed when disabling IPv6#10651
Merged
judyjoseph merged 3 commits intosonic-net:masterfrom Dec 8, 2023
Merged
Add docker0's IPv6 address since it was removed when disabling IPv6#10651judyjoseph merged 3 commits intosonic-net:masterfrom
judyjoseph merged 3 commits intosonic-net:masterfrom
Conversation
judyjoseph
reviewed
Nov 13, 2023
Collaborator
|
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
judyjoseph
previously approved these changes
Nov 17, 2023
judyjoseph
reviewed
Nov 17, 2023
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
judyjoseph
approved these changes
Dec 7, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 8, 2023
…onic-net#10651) * Add docker0's IPv6 address since it was removed when disabling IPv6 * Add docker0's IPv6 address since it was removed when disabling IPv6 * Add docker0's IPv6 address since it was removed when disabling IPv6
Collaborator
|
Cherry-pick PR to 202205: #10976 |
Merged
7 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 8, 2023
…10651) * Add docker0's IPv6 address since it was removed when disabling IPv6 * Add docker0's IPv6 address since it was removed when disabling IPv6 * Add docker0's IPv6 address since it was removed when disabling IPv6
vivekverma-arista
added a commit
to vivekverma-arista/sonic-mgmt
that referenced
this pull request
Mar 10, 2024
Regression introduced by sonic-net#10651 for dualtor. The config_reload in the fixture `dut_disable_ipv6` waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture in the same file `stopServices`. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of `dut_disable_ipv6` happens before `stopServices` then this issue is seen.
8 tasks
yxieca
pushed a commit
that referenced
this pull request
Mar 20, 2024
Regression introduced by #10651 for dualtor. The config_reload in the fixture `dut_disable_ipv6` waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture in the same file `stopServices`. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of `dut_disable_ipv6` happens before `stopServices` then this issue is seen.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 21, 2024
Regression introduced by sonic-net#10651 for dualtor. The config_reload in the fixture `dut_disable_ipv6` waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture in the same file `stopServices`. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of `dut_disable_ipv6` happens before `stopServices` then this issue is seen.
8 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 21, 2024
Regression introduced by sonic-net#10651 for dualtor. The config_reload in the fixture `dut_disable_ipv6` waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture in the same file `stopServices`. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of `dut_disable_ipv6` happens before `stopServices` then this issue is seen.
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Mar 21, 2024
Regression introduced by #10651 for dualtor. The config_reload in the fixture `dut_disable_ipv6` waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture in the same file `stopServices`. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of `dut_disable_ipv6` happens before `stopServices` then this issue is seen.
mssonicbld
pushed a commit
that referenced
this pull request
Mar 21, 2024
Regression introduced by #10651 for dualtor. The config_reload in the fixture `dut_disable_ipv6` waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture in the same file `stopServices`. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of `dut_disable_ipv6` happens before `stopServices` then this issue is seen.
8 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
May 14, 2024
What is the motivation for this PR? qos/test_qos_sai.py fails at teardown failed on setup with "Failed: All critical services should be fully started! Regression introduced by #10651 for dualtor. How did you do it? The config_reload in the fixture dut_disable_ipv6 waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture stopServices in the same file. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of dut_disable_ipv6 happens before stopServices then this issue is seen. This change ensures that the teardown of stopServices happens before dut_disable_ipv6 so that mux is no longer disabled at the time of config_reload. How did you verify/test it? Ran qos/test_qos_sai.py on Arista-7260CX3 platform with dualtor topology with 202305 and 202311 images.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
May 16, 2024
…r. (sonic-net#12503) What is the motivation for this PR? qos/test_qos_sai.py fails at teardown failed on setup with "Failed: All critical services should be fully started! Regression introduced by sonic-net#10651 for dualtor. How did you do it? The config_reload in the fixture dut_disable_ipv6 waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture stopServices in the same file. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of dut_disable_ipv6 happens before stopServices then this issue is seen. This change ensures that the teardown of stopServices happens before dut_disable_ipv6 so that mux is no longer disabled at the time of config_reload. How did you verify/test it? Ran qos/test_qos_sai.py on Arista-7260CX3 platform with dualtor topology with 202305 and 202311 images.
8 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
May 16, 2024
…r. (sonic-net#12503) What is the motivation for this PR? qos/test_qos_sai.py fails at teardown failed on setup with "Failed: All critical services should be fully started! Regression introduced by sonic-net#10651 for dualtor. How did you do it? The config_reload in the fixture dut_disable_ipv6 waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture stopServices in the same file. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of dut_disable_ipv6 happens before stopServices then this issue is seen. This change ensures that the teardown of stopServices happens before dut_disable_ipv6 so that mux is no longer disabled at the time of config_reload. How did you verify/test it? Ran qos/test_qos_sai.py on Arista-7260CX3 platform with dualtor topology with 202305 and 202311 images.
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
May 16, 2024
What is the motivation for this PR? qos/test_qos_sai.py fails at teardown failed on setup with "Failed: All critical services should be fully started! Regression introduced by #10651 for dualtor. How did you do it? The config_reload in the fixture dut_disable_ipv6 waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture stopServices in the same file. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of dut_disable_ipv6 happens before stopServices then this issue is seen. This change ensures that the teardown of stopServices happens before dut_disable_ipv6 so that mux is no longer disabled at the time of config_reload. How did you verify/test it? Ran qos/test_qos_sai.py on Arista-7260CX3 platform with dualtor topology with 202305 and 202311 images.
mssonicbld
pushed a commit
that referenced
this pull request
May 16, 2024
What is the motivation for this PR? qos/test_qos_sai.py fails at teardown failed on setup with "Failed: All critical services should be fully started! Regression introduced by #10651 for dualtor. How did you do it? The config_reload in the fixture dut_disable_ipv6 waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture stopServices in the same file. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of dut_disable_ipv6 happens before stopServices then this issue is seen. This change ensures that the teardown of stopServices happens before dut_disable_ipv6 so that mux is no longer disabled at the time of config_reload. How did you verify/test it? Ran qos/test_qos_sai.py on Arista-7260CX3 platform with dualtor topology with 202305 and 202311 images.
9 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
Jun 21, 2024
Approach What is the motivation for this PR? qos/test_qos_sai.py fails at teardown failed on setup with "Failed: All critical services should be fully started! Regression introduced by #10651 for dualtor. How did you do it? The config_reload in the fixture dut_disable_ipv6 waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture stopServices in the same file. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of dut_disable_ipv6 happens before stopServices then this issue is seen. This change ensures that the teardown of stopServices happens before dut_disable_ipv6 so that mux is no longer disabled at the time of config_reload. How did you verify/test it? Ran qos/test_qos_sai.py on Arista-7260CX3 platform with dualtor topology with 202305 and 202311 images.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 21, 2024
Approach What is the motivation for this PR? qos/test_qos_sai.py fails at teardown failed on setup with "Failed: All critical services should be fully started! Regression introduced by sonic-net#10651 for dualtor. How did you do it? The config_reload in the fixture dut_disable_ipv6 waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture stopServices in the same file. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of dut_disable_ipv6 happens before stopServices then this issue is seen. This change ensures that the teardown of stopServices happens before dut_disable_ipv6 so that mux is no longer disabled at the time of config_reload. How did you verify/test it? Ran qos/test_qos_sai.py on Arista-7260CX3 platform with dualtor topology with 202305 and 202311 images.
9 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jun 21, 2024
Approach What is the motivation for this PR? qos/test_qos_sai.py fails at teardown failed on setup with "Failed: All critical services should be fully started! Regression introduced by #10651 for dualtor. How did you do it? The config_reload in the fixture dut_disable_ipv6 waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture stopServices in the same file. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of dut_disable_ipv6 happens before stopServices then this issue is seen. This change ensures that the teardown of stopServices happens before dut_disable_ipv6 so that mux is no longer disabled at the time of config_reload. How did you verify/test it? Ran qos/test_qos_sai.py on Arista-7260CX3 platform with dualtor topology with 202305 and 202311 images.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 2, 2024
Approach What is the motivation for this PR? qos/test_qos_sai.py fails at teardown failed on setup with "Failed: All critical services should be fully started! Regression introduced by sonic-net#10651 for dualtor. How did you do it? The config_reload in the fixture dut_disable_ipv6 waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture stopServices in the same file. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of dut_disable_ipv6 happens before stopServices then this issue is seen. This change ensures that the teardown of stopServices happens before dut_disable_ipv6 so that mux is no longer disabled at the time of config_reload. How did you verify/test it? Ran qos/test_qos_sai.py on Arista-7260CX3 platform with dualtor topology with 202305 and 202311 images.
9 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 2, 2024
Approach What is the motivation for this PR? qos/test_qos_sai.py fails at teardown failed on setup with "Failed: All critical services should be fully started! Regression introduced by sonic-net#10651 for dualtor. How did you do it? The config_reload in the fixture dut_disable_ipv6 waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture stopServices in the same file. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of dut_disable_ipv6 happens before stopServices then this issue is seen. This change ensures that the teardown of stopServices happens before dut_disable_ipv6 so that mux is no longer disabled at the time of config_reload. How did you verify/test it? Ran qos/test_qos_sai.py on Arista-7260CX3 platform with dualtor topology with 202305 and 202311 images.
9 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 3, 2024
Approach What is the motivation for this PR? qos/test_qos_sai.py fails at teardown failed on setup with "Failed: All critical services should be fully started! Regression introduced by #10651 for dualtor. How did you do it? The config_reload in the fixture dut_disable_ipv6 waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture stopServices in the same file. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of dut_disable_ipv6 happens before stopServices then this issue is seen. This change ensures that the teardown of stopServices happens before dut_disable_ipv6 so that mux is no longer disabled at the time of config_reload. How did you verify/test it? Ran qos/test_qos_sai.py on Arista-7260CX3 platform with dualtor topology with 202305 and 202311 images.
mssonicbld
pushed a commit
that referenced
this pull request
Aug 4, 2024
Approach What is the motivation for this PR? qos/test_qos_sai.py fails at teardown failed on setup with "Failed: All critical services should be fully started! Regression introduced by #10651 for dualtor. How did you do it? The config_reload in the fixture dut_disable_ipv6 waits until all critical processes are up after issuing config reload command and it timeouts in case of dualtor because mux container doesn't come up. Mux container is disabled by another fixture stopServices in the same file. These two fixtures have no dependency on each other hence the execution can happen in any order, so if the teardown of dut_disable_ipv6 happens before stopServices then this issue is seen. This change ensures that the teardown of stopServices happens before dut_disable_ipv6 so that mux is no longer disabled at the time of config_reload. How did you verify/test it? Ran qos/test_qos_sai.py on Arista-7260CX3 platform with dualtor topology with 202305 and 202311 images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
IPv6 address is removed from docker0 when disabling IPv6 and this causes test_snmp_loopback testcase to fail
ARISTA06T1#bash snmpget -v2c -c public FC00:11::1 .1.3.6.1.2.1.1.1.0 (FC00:11::1 is the ipv6 address of the LC's loopback0)
Timeout: No Response from FC00:11::1.
% 'snmpget -v2c -c public FC00:11::1 .1.3.6.1.2.1.1.1.0' returned error code: 1
bash snmpget -v2c -c public FC00:11::1 .1.3.6.1.2.1.1.1.0 AssertionError: Sysdescr not found in SNMP result from IP FC00:11::1/128)
After enabling IPv6, an IPv6 address should be added to docker0 and a config reload is required.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
To restore the docker0's IPv6 address which is removed when IPv6 is disabled
How did you do it?
Add IPv6 address do docker0.
Do a config reload
How did you verify/test it?
Tested qos and snmp suites against a multi Asics line card on a T2 chassis
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation