[dualtor] Improve sanity check#10555
Merged
yxieca merged 1 commit intosonic-net:masterfrom Nov 1, 2023
Merged
Conversation
Add two changes related to sanity check: 1. Enable verbose mode when check monit status 2. Config save after confg mux auto in mux toggle fixture Signed-off-by: Longxiang Lyu <[email protected]>
yxieca
approved these changes
Nov 1, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 1, 2023
Add two changes related to sanity check: 1. Enable verbose mode when check monit status 2. Config save after confg mux auto in mux toggle fixture Signed-off-by: Longxiang Lyu <[email protected]>
Collaborator
|
Cherry-pick PR to 202205: #10561 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 1, 2023
Add two changes related to sanity check: 1. Enable verbose mode when check monit status 2. Config save after confg mux auto in mux toggle fixture Signed-off-by: Longxiang Lyu <[email protected]>
Collaborator
|
Cherry-pick PR to 202305: #10562 |
This was referenced Nov 1, 2023
mssonicbld
pushed a commit
that referenced
this pull request
Nov 1, 2023
Add two changes related to sanity check: 1. Enable verbose mode when check monit status 2. Config save after confg mux auto in mux toggle fixture Signed-off-by: Longxiang Lyu <[email protected]>
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Nov 4, 2023
Add two changes related to sanity check: 1. Enable verbose mode when check monit status 2. Config save after confg mux auto in mux toggle fixture Signed-off-by: Longxiang Lyu <[email protected]>
mssonicbld
added
Included in 202205 branch
and removed
Created PR to 202205 branch
labels
7 tasks
lolyu
added a commit
that referenced
this pull request
Dec 2, 2023
Approach What is the motivation for this PR? Same purpose as PR: #10555. This is to ensure mux auto to save to config_db.json to avoid any unwanted modification. How did you do it? Do a config save in teardown. How did you verify/test it? Any platform specific information? Supported testbed topology if it's a new test case?
7 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 2, 2023
Approach What is the motivation for this PR? Same purpose as PR: sonic-net#10555. This is to ensure mux auto to save to config_db.json to avoid any unwanted modification. How did you do it? Do a config save in teardown. How did you verify/test it? Any platform specific information? Supported testbed topology if it's a new test case?
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 2, 2023
Approach What is the motivation for this PR? Same purpose as PR: sonic-net#10555. This is to ensure mux auto to save to config_db.json to avoid any unwanted modification. How did you do it? Do a config save in teardown. How did you verify/test it? Any platform specific information? Supported testbed topology if it's a new test case?
7 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 2, 2023
Approach What is the motivation for this PR? Same purpose as PR: #10555. This is to ensure mux auto to save to config_db.json to avoid any unwanted modification. How did you do it? Do a config save in teardown. How did you verify/test it? Any platform specific information? Supported testbed topology if it's a new test case?
mssonicbld
pushed a commit
that referenced
this pull request
Dec 2, 2023
Approach What is the motivation for this PR? Same purpose as PR: #10555. This is to ensure mux auto to save to config_db.json to avoid any unwanted modification. How did you do it? Do a config save in teardown. How did you verify/test it? Any platform specific information? Supported testbed topology if it's a new test case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Sanity check observed during dualtor nightly in 202305:
monitcheck failure.manualmode.How did you do it?
How did you verify/test it?
run
test_hashon dualtor testbed.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation