Skip to content

Using the latest sonic command of interface startup and shutdown for the case of link_flap#1040

Closed
Harrison-SH wants to merge 1 commit intosonic-net:masterfrom
Harrison-SH:pr2
Closed

Using the latest sonic command of interface startup and shutdown for the case of link_flap#1040
Harrison-SH wants to merge 1 commit intosonic-net:masterfrom
Harrison-SH:pr2

Conversation

@Harrison-SH
Copy link
Copy Markdown
Contributor

@Harrison-SH Harrison-SH commented Jul 30, 2019

Description of PR
In the latest sonic. Setting interface to up/down is supported. Using the command to trigger link flap for the peer type of FanoutLeafSonic.
Summary:
Fixes # (issue)
Type of change
Bug fix

Approach
Change the command of " ip link set" to "config interface"
How did you verify/test it?
Pass the testcase of link_flap with the peer host of the latest sonic.

@Harrison-SH Harrison-SH changed the title Using the latest sonic command of interface startup and shutdown Using the latest sonic command of interface startup and shutdown for the case of link_flap Jul 30, 2019
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca
[201811] advance sairedis, swss and utilities sub module head (sonic-…
96038ee 
…net#3424)

Submodule src/sonic-sairedis 4ee82cb..1cf2eea:
  > Add acl counter match logic based on acl entry field (sonic-net#511)
  > Add specific comparison logic for ACL counter (sonic-net#484)

Submodule src/sonic-swss 46bc1f4..660530e:
  > Fix VLAN error introduced with new 4.9 kernel behavior (sonic-net#1001)
  > Warmboot Vlan neigh restore fix (sonic-net#1040)

Submodule src/sonic-utilities 11b4cf1..f76fc2c:
  > [warm reboot] Skip ASIC config pre-check if current image does not support it (sonic-net#637)
  > [FastReboot]: Send SIGINT to all teamd before stop (sonic-net#633)
  > [warm/fast reboot] provide strict option to prevent warm reboot under certain conditions (sonic-net#631)

Signed-off-by: Ying Xie <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@abdosi
[submodule update] sonic-utilities
09248d9 
 [201911][Python] Migrate applications/scripts to import sonic-py-common
 package (sonic-net#1040)

Signed-off-by: Abhishek Dosi <[email protected]>
@wangxinbot
Copy link
Copy Markdown
Contributor

wangxinbot commented Apr 3, 2026

This PR has been open since July 2019 (~7 years). The affected file (ansible/roles/test/tasks/link_flap/link_flap_helper.yml) is part of the legacy Ansible-based test framework, which has largely been replaced by pytest-based tests.

Additionally, there is a subtle behavior change: the original code used port_alias_map[neighbor_interface] (translated alias) with ip link set, but the replacement uses neighbor_interface directly with config interface. This drops the alias translation, which may or may not be correct depending on the interface naming convention on the fanout.

Recommend closing this PR as stale.

@wangxin
Copy link
Copy Markdown
Collaborator

wangxin commented Apr 3, 2026

Closing this PR.

@wangxin wangxin closed this Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Harrison-SH @wangxinbot @wangxin