Very nice initiative to run ansible test with sonic kvm vs, I think it will greatly facilitate the implementation and validation of SONiC control plane.

While following the instructions listed in:
https://github.com/Azure/sonic-mgmt/blob/master/ansible/doc/README.testbed.VsSetup.md

I encountered a few issues and questions:

1. vEOS-lab-4.15.9M.vmdk not available for download any more.
   Probably more recent version like vEOS-lab-4.21.1.1F.vmdk should be used, and the image version reference be updated accordingly too.

2. Could the whole test bed be created within VM?
   Though that means nested virtualization, it will be a lot easier for people who don't have access to bare metal servers.

3. Requirement for building sonic-vs image
   kvm support is needed to build this image, which is different from other sonic image build. Probably it should be documented somewhere.

4. credentials update
   It might be obvious to people who are familiar with ansible test setup. It is still good to mention creds.yml in this guide. There could be people taking vs ansible setup as the very start.

5. one typo
   "ansible -m ping -i veos server_1", actually means "ansible -m ping -i veos.vtb server_1"?

https://github.com/Azure/sonic-mgmt/blob/71d24e878bcd75c2d01bf013e85c66cc486c397d/ansible/doc/README.testbed.VsSetup.md#setup-arista-vms-in-the-server

6. "Put the private key inside the sonic-mgmt docker container."

private key from host? why do you need this?

https://github.com/Azure/sonic-mgmt/blob/71d24e878bcd75c2d01bf013e85c66cc486c397d/ansible/doc/README.testbed.VsSetup.md#clone-sonic-mgmt-repo

7. Last but not the least, it does work. Hope to see more complete vs ansible test instructions.

Last login: Thu Jan 24 02:18:39 2019 from 10.250.0.1
admin@vlab-01:~$ 
admin@vlab-01:~$ show ip bgp sum
BGP router identifier 10.1.0.32, local AS number 65100
RIB entries 12807, using 1401 KiB of memory
Peers 8, using 36 KiB of memory
Peer groups 2, using 112 bytes of memory

Neighbor        V         AS MsgRcvd MsgSent   TblVer  InQ OutQ Up/Down  State/PfxRcd
10.0.0.57       4 64600    3728    2869        0    0    0 00:26:22     6400
10.0.0.59       4 64600    3730    3731        0    0    0 00:26:21     6400
10.0.0.61       4 64600    3729    3732        0    0    0 00:26:19     6400
10.0.0.63       4 64600    3731    1399        0    0    0 00:26:21     6400

Total number of neighbors 4