Skip to content

test_thermal.py and test_sfp.py should check SFP capability  #2524

@Junchao-Mellanox

Description

@Junchao-Mellanox

Description

A few SFP related platform APIs return value according to its capability. For example, a SFP might not support temperature sensor, or a SFP might not support reading its voltage... However, in test_thermal.py and test_sfp.py, the related test case always expect a "real" value, and will fail if it get None or other empty value (such as empty list, empty dict). As we will have different type SFP in testbed, and the SFP capability may not fully support all platform APIs, please consider whether such strict check is necessary.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions