Skip to content

Bug: SnappiTests when run with --skip-sanity still end up expecting BGP sessions during teardown. #18407

@vivekverma-arista

Description

@vivekverma-arista

Is it platform specific

generic

Importance or Severity

Medium

Description of the bug

It is recommended that snappi tests are run with --skip-sanity flag: https://github.com/sonic-net/sonic-mgmt/blob/master/tests/snappi_tests/README.md

In snappi tests, BGP sessions, port channels, LLDP neighbors, etc are established during the test when needed unlike normal topologies where these protocols run continuously.

Also this session is torn down during the test itself and doesn't stay up until teardown as snappi api terminates the session with IxNetwork client.

https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/snappi_tests/snappi_fixtures.py#L73-L76
 
The tests even with this flags are expecting BGP sessions to be up during teardown which leads to sanity check failure in teardown:
https://github.com/sonic-net/sonic-mgmt/blob/master/tests/conftest.py#L2479
 

Steps to Reproduce

Run any of the snappi tests

Actual Behavior and Expected Behavior

The sanity check should be skipped in teardown as well if --skip-sanity was passed.

Relevant log output

Output of show version

Attach files (if any)

No response

Metadata

Metadata

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions