Skip to content

[Bug][Snappi]: get_lossless_buffer_size definition in common_helpers to have Nokia-7250 specific check for selecting profile name. #13653

@amitpawar12

Description

@amitpawar12

Issue Description

The get_lossless_buffer_size in common/snappi_tests/common_helper.py checks the name of the ingress lossless profile name and based on that selects appropriate settings.

There is a check to select 'ingress_lossless_pool' for Cisco 8000 platform and egress_lossless_pool otherwise.

    is_cisco8000_platform = True if 'cisco-8000' in host_ans.facts['platform_asic'] else False

    if "BUFFER_POOL" not in list(config_facts.keys()):
        return None

    buffer_pools = config_facts['BUFFER_POOL']
    profile_name = 'ingress_lossless_pool' if is_cisco8000_platform else 'egress_lossless_pool'

Similar check is needed to select ingress_lossless_pool if it is Nokia 7250 platform.

Intend to add following check:

    is_nokia_7250 = True if ('Nokia' or 'nokia') and '7250' in device_mtd else False

    if "BUFFER_POOL" not in list(config_facts.keys()):
        return None

    buffer_pools = config_facts['BUFFER_POOL']

    profile_name = 'ingress_lossless_pool' if (is_cisco_8102 or is_nokia_7250 ) or else 'egress_lossless_pool'

Results you see

The function returns size parameter of "egress_lossless_pool" for Nokia platforms as well.

Results you expected to see

Returning ingress_lossless_pool profile for Nokia 7250 platform.

Is it platform specific

generic

Relevant log output

No response

Output of show version

No response

Attach files (if any)

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions