Fix unable to probe emc2301/2/3#312
Conversation
|
Can you add a reference to the upstream commit, and add in the second chunk of that change where |
|
Please add a space after [patch] (maybe spell it [PATCH]). No idea, if the tag is needed though. |
The definitions of 'EMC2305_REG_PRODUCT_ID' and 'EMC2305_REG_DEVICE' are both '0xfd', they actually return the same value, but the values returned by emc2301/2/3/5 are different, so probe emc2301/2/3 will fail, This patch fixes that. upstream commit: torvalds/linux@4d50591 Signed-off-by: Natarajan Subbiramani <[email protected]> Signed-off-by: Xingjiang Qiao <[email protected]> Link: https://lore.kernel.org/r/[email protected] Fixes: 0d8400c ("hwmon: (emc2305) add support for EMC2301/2/3/5 RPM-based PWM Fan Speed Controller.") Signed-off-by: Guenter Roeck <[email protected]>
Pavan-Nokia
force-pushed
the
dev_enable_fan_driver
branch
from
f5fea3d to
30f92f8
Compare
Pavan-Nokia
changed the title
|
Hi @paulmenzel @saiarcot895 Thanks for the review. I have addressed the review comments and updated the PR. Please review. |
|
Please revert and backport the upstream commit 4d50591ebf60 (hwmon: (emc2305) fix unable to probe emc2301/2/3). @Pavan-Nokia, why did you not check that? @Pavan-Nokia, please make up for this, by sending a message to [email protected] asking to backport this patch to the stable series. PS: |
The driver was only added in Linux v6.1-rc1, the commit adding the driver would also need to be backported. |
|
Hi Paul
|
Update sonic-linux-kernel submodule pointer to include the following: * 6f38dca Provision the ability to apply the non upstream patches in any order ([sonic-net#313](sonic-net/sonic-linux-kernel#313)) * fbd307e Fix unable to probe emc2301/2/3 ([sonic-net#312](sonic-net/sonic-linux-kernel#312)) Signed-off-by: Vivek Reddy <[email protected]>
|
I am sorry for missing this detail and overreacting. Please accept my apologies. Next time, if you found the upstream commit, you should have cherry-picked it so the author information would have been from the upstream author. Also for backports, the upstream commit is usually mentioned right at the top.
|
3 participants
The current code only supports EMC2305, enable support for EMC2301/2/3 also
Same driver is used for EMC 2301/2/3/5 family of products.
https://docs.kernel.org/hwmon/emc2305.html
The definitions of 'EMC2305_REG_PRODUCT_ID' and 'EMC2305_REG_DEVICE' are
both '0xfd', they actually return the same value, but the values returned
by emc2301/2/3/5 are different, so probe emc2301/2/3 will fail, This patch
fixes that.
upstream commit:
torvalds/linux@4d50591
Signed-off-by: Natarajan Subbiramani [email protected]
Signed-off-by: Xingjiang Qiao [email protected]
Link: https://lore.kernel.org/r/[email protected]
Fixes: 0d8400c ("hwmon: (emc2305) add support for EMC2301/2/3/5 RPM-based PWM Fan Speed Controller.")
Signed-off-by: Guenter Roeck [email protected]