Add markers to faciliate easy parsing of kconfig-inclusion and series#309
Merged
saiarcot895 merged 11 commits intosonic-net:masterfrom Mar 16, 2023
Merged
Add markers to faciliate easy parsing of kconfig-inclusion and series#309saiarcot895 merged 11 commits intosonic-net:masterfrom
saiarcot895 merged 11 commits intosonic-net:masterfrom
Conversation
…ate mlnx kconfig Signed-off-by: Vivek Reddy <[email protected]>
Signed-off-by: Vivek Reddy <[email protected]>
Signed-off-by: Vivek Reddy <[email protected]>
Signed-off-by: Vivek Reddy <[email protected]>
Contributor
Author
|
@dgsudharsan @saiarcot895 Please review |
dgsudharsan
approved these changes
Mar 11, 2023
Contributor
Author
|
/azpw run Azure.sonic-linux-kernel |
|
/AzurePipelines run Azure.sonic-linux-kernel |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Vivek Reddy <[email protected]>
Contributor
|
Thank you for the clean-up, and fix. Could you please amend the commit message and write a more elaborate message?
|
Contributor
|
Is there an actual need to have a per-platform kernel? Right now, the kernel is the same whether it's running on a Mellanox, Arista, Dell, or even KVM. I would like to keep that platform independence, and not introduce platform-specific logic here. |
Contributor
Author
We are developing a script which can automatically update the Kconfig opts based on new mlnx hw-mgmt version. For that to work, we need kconfig options specific to mellanox and thus i've moved them to a separate section. I suppose other vendors shouldn't be affected by this change, do you foresee any functional impact of this? Besides the logic to include vendor specific options was already present, i've just made some fixes |
Signed-off-by: Vivek Reddy <[email protected]>
Signed-off-by: Vivek Reddy <[email protected]>
vivekrnv
changed the title
Signed-off-by: Vivek Reddy <[email protected]>
Signed-off-by: Vivek Reddy <[email protected]>
Signed-off-by: Vivek Reddy <[email protected]>
vivekrnv
changed the title
Signed-off-by: Vivek Reddy <[email protected]>
dgsudharsan
approved these changes
Mar 15, 2023
vivekrnv
changed the title
Collaborator
|
@saiarcot895 Can you please review? |
saiarcot895
approved these changes
Mar 16, 2023
Contributor
Author
|
Request for 202211 |
Collaborator
|
@StormLiangMS @saiarcot895 Can you please add label for 202211? |
vivekrnv
added a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Mar 17, 2023
Update sonic-linux-kernel submodule pointer to include the following: * 6847319 Read ID register for optoe1 to find pageable bit in optoe driver ([sonic-net#308](sonic-net/sonic-linux-kernel#308)) * 42ad073 Add markers to faciliate easy parsing of kconfig-inclusion and series ([sonic-net#309](sonic-net/sonic-linux-kernel#309)) Signed-off-by: Vivek Reddy <[email protected]>
8 tasks
Collaborator
|
@StormLiangMS Can you please cherry-pick to 202211? |
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Mar 21, 2023
Update sonic-linux-kernel submodule pointer to include the following: * 6847319 Read ID register for optoe1 to find pageable bit in optoe driver ([#308](sonic-net/sonic-linux-kernel#308)) * 42ad073 Add markers to faciliate easy parsing of kconfig-inclusion and series ([#309](sonic-net/sonic-linux-kernel#309)) Signed-off-by: Vivek Reddy <[email protected]>
StormLiangMS
pushed a commit
that referenced
this pull request
Apr 13, 2023
…#309) * [Kconfig] [mellanox] Fix platform specific kconfig logic and consolidate mlnx kconfig Signed-off-by: Vivek Reddy <[email protected]> * Re-org options Signed-off-by: Vivek Reddy <[email protected]> * Include Secure boot cfg Signed-off-by: Vivek Reddy <[email protected]> * Update the option name to mellanox Signed-off-by: Vivek Reddy <[email protected]> * Remove duplicate mlnx options Signed-off-by: Vivek Reddy <[email protected]> * Revert kconfig option changes Signed-off-by: Vivek Reddy <[email protected]> * Added consistent marker format in the inclusions file Signed-off-by: Vivek Reddy <[email protected]> * Update markers and description for series file Signed-off-by: Vivek Reddy <[email protected]> * Fix in series mlnx sdk marker Signed-off-by: Vivek Reddy <[email protected]> * Update marker id Signed-off-by: Vivek Reddy <[email protected]> * Remove manager-config changes Signed-off-by: Vivek Reddy <[email protected]> --------- Signed-off-by: Vivek Reddy <[email protected]>
vivekrnv
added a commit
to vivekrnv/sonic-linux-kernel
that referenced
this pull request
May 19, 2023
…sonic-net#309) * [Kconfig] [mellanox] Fix platform specific kconfig logic and consolidate mlnx kconfig Signed-off-by: Vivek Reddy <[email protected]> * Re-org options Signed-off-by: Vivek Reddy <[email protected]> * Include Secure boot cfg Signed-off-by: Vivek Reddy <[email protected]> * Update the option name to mellanox Signed-off-by: Vivek Reddy <[email protected]> * Remove duplicate mlnx options Signed-off-by: Vivek Reddy <[email protected]> * Revert kconfig option changes Signed-off-by: Vivek Reddy <[email protected]> * Added consistent marker format in the inclusions file Signed-off-by: Vivek Reddy <[email protected]> * Update markers and description for series file Signed-off-by: Vivek Reddy <[email protected]> * Fix in series mlnx sdk marker Signed-off-by: Vivek Reddy <[email protected]> * Update marker id Signed-off-by: Vivek Reddy <[email protected]> * Remove manager-config changes Signed-off-by: Vivek Reddy <[email protected]> --------- Signed-off-by: Vivek Reddy <[email protected]>
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-linux-kernel
that referenced
this pull request
Jan 27, 2025
…sonic-net#309) * [Kconfig] [mellanox] Fix platform specific kconfig logic and consolidate mlnx kconfig Signed-off-by: Vivek Reddy <[email protected]> * Re-org options Signed-off-by: Vivek Reddy <[email protected]> * Include Secure boot cfg Signed-off-by: Vivek Reddy <[email protected]> * Update the option name to mellanox Signed-off-by: Vivek Reddy <[email protected]> * Remove duplicate mlnx options Signed-off-by: Vivek Reddy <[email protected]> * Revert kconfig option changes Signed-off-by: Vivek Reddy <[email protected]> * Added consistent marker format in the inclusions file Signed-off-by: Vivek Reddy <[email protected]> * Update markers and description for series file Signed-off-by: Vivek Reddy <[email protected]> * Fix in series mlnx sdk marker Signed-off-by: Vivek Reddy <[email protected]> * Update marker id Signed-off-by: Vivek Reddy <[email protected]> * Remove manager-config changes Signed-off-by: Vivek Reddy <[email protected]> --------- Signed-off-by: Vivek Reddy <[email protected]>
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-linux-kernel
that referenced
this pull request
Feb 10, 2025
…sonic-net#309) * [Kconfig] [mellanox] Fix platform specific kconfig logic and consolidate mlnx kconfig Signed-off-by: Vivek Reddy <[email protected]> * Re-org options Signed-off-by: Vivek Reddy <[email protected]> * Include Secure boot cfg Signed-off-by: Vivek Reddy <[email protected]> * Update the option name to mellanox Signed-off-by: Vivek Reddy <[email protected]> * Remove duplicate mlnx options Signed-off-by: Vivek Reddy <[email protected]> * Revert kconfig option changes Signed-off-by: Vivek Reddy <[email protected]> * Added consistent marker format in the inclusions file Signed-off-by: Vivek Reddy <[email protected]> * Update markers and description for series file Signed-off-by: Vivek Reddy <[email protected]> * Fix in series mlnx sdk marker Signed-off-by: Vivek Reddy <[email protected]> * Update marker id Signed-off-by: Vivek Reddy <[email protected]> * Remove manager-config changes Signed-off-by: Vivek Reddy <[email protected]> --------- Signed-off-by: Vivek Reddy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did it