Fix issue: thermal algorithm not work for optical module#128
Merged
lguohan merged 4 commits intosonic-net:masterfrom Apr 3, 2020
Merged
Fix issue: thermal algorithm not work for optical module#128lguohan merged 4 commits intosonic-net:masterfrom
lguohan merged 4 commits intosonic-net:masterfrom
Conversation
Collaborator
|
retest this please |
Contributor
|
can you update the description, what is exactly not working? |
jleveque
approved these changes
Mar 31, 2020
abdosi
pushed a commit
that referenced
this pull request
Apr 27, 2020
Fix issue: optical module temperature raising doesn't result in fan speed raising. Kernel thermal algorithm cannot detect optical module temperature changing. ASIC and gearbox has no issue, only optical module. (0058) Enable kernel detect the hottest thermal zone and perform thermal algorithm based on that. (0059)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR contains two patches:
How to fix?
Add a patch to init thermal trips for optical modules.
How to verify?
Raise temperature of optical modules and check fan speed is also raising.