Skip to content

[fast-reboot] Back up FDB/ARP/Default routes#4795

Merged
tahmed-dev merged 2 commits intosonic-net:masterfrom
tahmed-dev:taahme/backup-file-during-fast-reboot
Jun 20, 2020
Merged

[fast-reboot] Back up FDB/ARP/Default routes#4795
tahmed-dev merged 2 commits intosonic-net:masterfrom
tahmed-dev:taahme/backup-file-during-fast-reboot

Conversation

@tahmed-dev
Copy link
Copy Markdown
Contributor

@tahmed-dev tahmed-dev commented Jun 18, 2020 •
edited
Loading

FDB/ARP/Default routes files are deleted after swssconfig. This
make debugging/validation of device conversion hard. This PR
save those files in order to facilitate device conversion.

signed-off-by: Tamer Ahmed [email protected]

- Why I did it
In order to make verification of device conversion easier.

- How I did it
Code change

- How to verify it
Verified with debug build that has this change

admin@str-s6000-acs-14:~$ sudo find / -name arp.json*
/host/image-taahme_backup-file-during-fast-reboot.0-dirty-20200618.235059/docker/overlay2/522da426044901997983d9c88f77fa14f123f48e2038af11f13bd357123c8c77/diff/arp.json.1
/usr/lib/python2.7/dist-packages/sonic-utilities-tests/filter_fdb_input/arp.json
/var/lib/docker/overlay2/522da426044901997983d9c88f77fa14f123f48e2038af11f13bd357123c8c77/diff/arp.json.1
/var/lib/docker/overlay2/522da426044901997983d9c88f77fa14f123f48e2038af11f13bd357123c8c77/merged/arp.json.1
admin@str-s6000-acs-14:~$ sudo find / -name default_routes.json*
/host/image-taahme_backup-file-during-fast-reboot.0-dirty-20200618.235059/docker/overlay2/522da426044901997983d9c88f77fa14f123f48e2038af11f13bd357123c8c77/diff/default_routes.json.1
/var/lib/docker/overlay2/522da426044901997983d9c88f77fa14f123f48e2038af11f13bd357123c8c77/diff/default_routes.json.1
/var/lib/docker/overlay2/522da426044901997983d9c88f77fa14f123f48e2038af11f13bd357123c8c77/merged/default_routes.json.1
admin@str-s6000-acs-14:~$ sudo find / -name fdb.json*
/host/image-taahme_backup-file-during-fast-reboot.0-dirty-20200618.235059/docker/overlay2/522da426044901997983d9c88f77fa14f123f48e2038af11f13bd357123c8c77/diff/fdb.json.1
/usr/lib/python2.7/dist-packages/sonic-utilities-tests/filter_fdb_input/fdb.json
/var/lib/docker/overlay2/522da426044901997983d9c88f77fa14f123f48e2038af11f13bd357123c8c77/diff/fdb.json.1
/var/lib/docker/overlay2/522da426044901997983d9c88f77fa14f123f48e2038af11f13bd357123c8c77/merged/fdb.json.1

- Description for the changelog

@tahmed-dev
[fast-reboot] Back up FDB/ARP/Default routes
c79e906 
FDB/ARP/Devault routes files are deleted after swssconfig. This
make debugging/validation of device conversion hard. This PR
save those files in order to facilitate device conversion.

signed-off-by: Tamer Ahmed <[email protected]>
@tahmed-dev tahmed-dev requested review from kcudnik, lguohan and yxieca June 18, 2020 00:18
lguohan
lguohan previously approved these changes Jun 18, 2020
View reviewed changes
@tahmed-dev
Copy link
Copy Markdown
Contributor Author

tahmed-dev commented Jun 18, 2020

retest mellanox please

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Jun 19, 2020

@tahmed-dev, let me know if you have validated so that we can merge.

yxieca
yxieca reviewed Jun 19, 2020
View reviewed changes
@tahmed-dev
Copy link
Copy Markdown
Contributor Author

tahmed-dev commented Jun 19, 2020

@tahmed-dev, let me know if you have validated so that we can merge.

Ack, will update the PR once validation is complete.

@tahmed-dev tahmed-dev requested review from lguohan and yxieca June 19, 2020 16:50
@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Jun 19, 2020 •
edited
Loading

why we are having this build error? https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/4406/

does not seem like random.

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Jun 19, 2020

retest vsimage please

@tahmed-dev
Copy link
Copy Markdown
Contributor Author

tahmed-dev commented Jun 19, 2020

why we are having this build error? https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/4406/

does not seem like random.

Interesting! I see this error and it does not look like it is related to change in here. Will keep an eye on it

10:07:56  >       namespaces = sonic_device_util.get_all_namespaces()
10:07:56  E       AttributeError: 'module' object has no attribute 'get_all_namespaces'

@jleveque
Copy link
Copy Markdown
Contributor

jleveque commented Jun 20, 2020 •
edited
Loading

vsimage check build appears to be stuck. I killed off a few stuck check builds.

@jleveque
Copy link
Copy Markdown
Contributor

jleveque commented Jun 20, 2020

Retest vsimage please

@tahmed-dev tahmed-dev merged commit 211d1e7 into sonic-net:master Jun 20, 2020
yxieca pushed a commit that referenced this pull request Jun 21, 2020
@tahmed-dev @yxieca
[fast-reboot] Back up FDB/ARP/Default routes (#4795)
ab3400f 
FDB/ARP/Default routes files are deleted after swssconfig. This
makes debugging/validation of device conversion hard. This PR
saves those files in order to facilitate debugging of device conversion.

signed-off-by: Tamer Ahmed <[email protected]>
abdosi pushed a commit that referenced this pull request Jun 28, 2020
@tahmed-dev @abdosi
[fast-reboot] Back up FDB/ARP/Default routes (#4795)
10cd212 
FDB/ARP/Default routes files are deleted after swssconfig. This
makes debugging/validation of device conversion hard. This PR
saves those files in order to facilitate debugging of device conversion.

signed-off-by: Tamer Ahmed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan approved these changes

@yxieca yxieca yxieca approved these changes

@kcudnik kcudnik Awaiting requested review from kcudnik

+1 more reviewer

@jleveque jleveque jleveque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement ➕ Included in 201811 Branch Included in 201911 Branch Request for 201811 Branch :shipit: Request for 201911 Branch :shipit:

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tahmed-dev @lguohan @jleveque @yxieca @abdosi