Added QFX5210 readme for build and install#4211
Merged
lguohan merged 4 commits intosonic-net:masterfrom Mar 20, 2020
Merged
Conversation
Signed-off-by: Ciju Rajan K <[email protected]> Signed-off-by: Ashish Bhensdadia <[email protected]>
|
|
Contributor
Author
jleveque
suggested changes
Mar 5, 2020
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
Please format all commands and command output in code blocks (surround by three backticks) for readability.
Contributor
Author
|
incorporated format related comments. Please take a look pull request. Thanks |
Contributor
Author
|
Can you please take a look? -Ashish |
jleveque
suggested changes
Mar 9, 2020
jleveque
suggested changes
Mar 11, 2020
Contributor
Author
|
@jleveque deleted extra blank lines. |
jleveque
approved these changes
Mar 12, 2020
Contributor
Author
|
@jleveque |
Contributor
|
Retest this please |
Contributor
|
@ashishb-juniper: Yes, the vs and vsimage check build failures were preventing this from being merged. I just kicked off a fresh set of tests with the comment above. Let's wait to see the results. |
Contributor
Author
|
@jleveque : now only vsimage. Is there any way we can skip the vsimage test cases? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation for installing SONiC on Juniper QFX5210 platform
Signed-off-by: Ciju Rajan K [email protected]
Signed-off-by: Ashish Bhensdadia [email protected]