DellEMC:S5232 fix transceiver change event#3924
Merged
lguohan merged 2 commits intosonic-net:masterfrom Feb 11, 2020
Merged
Conversation
jleveque
suggested changes
Dec 18, 2019
jleveque
approved these changes
Dec 20, 2019
Contributor
Author
|
retest vsimage please |
1 similar comment
Contributor
Author
|
retest vsimage please |
Contributor
|
Retest vsimage please |
Contributor
Author
|
retest vsimage please |
Contributor
Author
|
retest this please |
Contributor
Author
|
retest vsimage please |
2 similar comments
Contributor
|
retest vsimage please |
Collaborator
|
retest vsimage please |
lguohan
approved these changes
Jan 28, 2020
Contributor
|
Retest vsimage please |
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Feb 26, 2020
mssonicbld
added a commit
that referenced
this pull request
Jun 20, 2025
…atically (#23017) #### Why I did it src/sonic-utilities ``` * 77f05319 - (HEAD -> 202505, origin/202505) Skip checking offload flags for static routes/sids in route check and add check_sids (#3924) (3 days ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Nov 1, 2025
…lly (#24266) #### Why I did it src/sonic-swss ``` * 3ccfa62 - (HEAD -> master, origin/master, origin/HEAD) [orchagent] Add FEC frame loss ratio monitoring with predictive analytics (#3869) (3 days ago) [Apoorv Sachan] * 2018ed3 - Add mock test for IPv4/IPv6 route add/delete (#3839) (3 days ago) [meghtony] * 47df807 - [portsorch] Fixed port comparison logic executed every doTask for every port (#3821) (3 days ago) [Stepan Blyshchak] * 0c60bdb - [ssw][ha] use endpoint IP to for tunnel term acl (#3897) (3 days ago) [Jing Zhang] * 80c742c - [muxorch] Fix handling mux neighbors learned after route (#3937) (4 days ago) [Nikola Dancejic] * bd47953 - [Vnetorch] Ecmp vnet local routes (#3935) (7 days ago) [Leyza] * 5de5922 - [FC] Set FC delay in command line parameters (#3814) (8 days ago) [Stepan Blyshchak] * 85a0615 - [ssw][ha] set `SAI_ENI_ATTR_IS_HA_FLOW_OWNER` & `SAI_ENI_ATTR_HA_SCOPE_ID` when creating eni (#3881) (11 days ago) [Jing Zhang] * bc40a04 - Skip flush if ring buffer is not empty or thread is not in idle (#3895) (11 days ago) [Eddie Ruan] * ab96400 - [trim]: Update log level severity to avoid errors during attribute/enum capabilities query (#3916) (2 weeks ago) [Nazarii Hnydyn] * 582eed0 - [vs]: Fix trimming test cases: avoid config consolidation (#3939) (2 weeks ago) [Nazarii Hnydyn] * 34b9f36 - [vs]: Fix trimming test cases: avoid NULL OID polling (#3943) (2 weeks ago) [Nazarii Hnydyn] * 8b8918a - [ACL] Populate SAI tunnel term correctly (#3924) (2 weeks ago) [Vivek] * fb56d6d - Maximum non-zero FEC histogram bin (#3919) (2 weeks ago) [Prince George] * c87bf6c - [FC] Reduce sairedis calls by efficient caching (#3854) (3 weeks ago) [Vivek] * 287461b - [vs]: Remove non-default objects on dynamic buffer model teardown (#3931) (3 weeks ago) [Nazarii Hnydyn] * 36c598c - Make fpmsyncd capable of handling route replace semantics (#3872) (3 weeks ago) [venkit-nexthop] ``` #### How I did it #### How to verify it #### Description for the changelog
ashutosh-agrawal
pushed a commit
to AnantKishorSharma/sonic-buildimage
that referenced
this pull request
Nov 30, 2025
…lly (sonic-net#24266) #### Why I did it src/sonic-swss ``` * 3ccfa62 - (HEAD -> master, origin/master, origin/HEAD) [orchagent] Add FEC frame loss ratio monitoring with predictive analytics (sonic-net#3869) (3 days ago) [Apoorv Sachan] * 2018ed3 - Add mock test for IPv4/IPv6 route add/delete (sonic-net#3839) (3 days ago) [meghtony] * 47df807 - [portsorch] Fixed port comparison logic executed every doTask for every port (sonic-net#3821) (3 days ago) [Stepan Blyshchak] * 0c60bdb - [ssw][ha] use endpoint IP to for tunnel term acl (sonic-net#3897) (3 days ago) [Jing Zhang] * 80c742c - [muxorch] Fix handling mux neighbors learned after route (sonic-net#3937) (4 days ago) [Nikola Dancejic] * bd47953 - [Vnetorch] Ecmp vnet local routes (sonic-net#3935) (7 days ago) [Leyza] * 5de5922 - [FC] Set FC delay in command line parameters (sonic-net#3814) (8 days ago) [Stepan Blyshchak] * 85a0615 - [ssw][ha] set `SAI_ENI_ATTR_IS_HA_FLOW_OWNER` & `SAI_ENI_ATTR_HA_SCOPE_ID` when creating eni (sonic-net#3881) (11 days ago) [Jing Zhang] * bc40a04 - Skip flush if ring buffer is not empty or thread is not in idle (sonic-net#3895) (11 days ago) [Eddie Ruan] * ab96400 - [trim]: Update log level severity to avoid errors during attribute/enum capabilities query (sonic-net#3916) (2 weeks ago) [Nazarii Hnydyn] * 582eed0 - [vs]: Fix trimming test cases: avoid config consolidation (sonic-net#3939) (2 weeks ago) [Nazarii Hnydyn] * 34b9f36 - [vs]: Fix trimming test cases: avoid NULL OID polling (sonic-net#3943) (2 weeks ago) [Nazarii Hnydyn] * 8b8918a - [ACL] Populate SAI tunnel term correctly (sonic-net#3924) (2 weeks ago) [Vivek] * fb56d6d - Maximum non-zero FEC histogram bin (sonic-net#3919) (2 weeks ago) [Prince George] * c87bf6c - [FC] Reduce sairedis calls by efficient caching (sonic-net#3854) (3 weeks ago) [Vivek] * 287461b - [vs]: Remove non-default objects on dynamic buffer model teardown (sonic-net#3931) (3 weeks ago) [Nazarii Hnydyn] * 36c598c - Make fpmsyncd capable of handling route replace semantics (sonic-net#3872) (3 weeks ago) [venkit-nexthop] ``` #### How I did it #### How to verify it #### Description for the changelog
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Dec 4, 2025
…lly (sonic-net#24266) #### Why I did it src/sonic-swss ``` * 3ccfa62 - (HEAD -> master, origin/master, origin/HEAD) [orchagent] Add FEC frame loss ratio monitoring with predictive analytics (sonic-net#3869) (3 days ago) [Apoorv Sachan] * 2018ed3 - Add mock test for IPv4/IPv6 route add/delete (sonic-net#3839) (3 days ago) [meghtony] * 47df807 - [portsorch] Fixed port comparison logic executed every doTask for every port (sonic-net#3821) (3 days ago) [Stepan Blyshchak] * 0c60bdb - [ssw][ha] use endpoint IP to for tunnel term acl (sonic-net#3897) (3 days ago) [Jing Zhang] * 80c742c - [muxorch] Fix handling mux neighbors learned after route (sonic-net#3937) (4 days ago) [Nikola Dancejic] * bd47953 - [Vnetorch] Ecmp vnet local routes (sonic-net#3935) (7 days ago) [Leyza] * 5de5922 - [FC] Set FC delay in command line parameters (sonic-net#3814) (8 days ago) [Stepan Blyshchak] * 85a0615 - [ssw][ha] set `SAI_ENI_ATTR_IS_HA_FLOW_OWNER` & `SAI_ENI_ATTR_HA_SCOPE_ID` when creating eni (sonic-net#3881) (11 days ago) [Jing Zhang] * bc40a04 - Skip flush if ring buffer is not empty or thread is not in idle (sonic-net#3895) (11 days ago) [Eddie Ruan] * ab96400 - [trim]: Update log level severity to avoid errors during attribute/enum capabilities query (sonic-net#3916) (2 weeks ago) [Nazarii Hnydyn] * 582eed0 - [vs]: Fix trimming test cases: avoid config consolidation (sonic-net#3939) (2 weeks ago) [Nazarii Hnydyn] * 34b9f36 - [vs]: Fix trimming test cases: avoid NULL OID polling (sonic-net#3943) (2 weeks ago) [Nazarii Hnydyn] * 8b8918a - [ACL] Populate SAI tunnel term correctly (sonic-net#3924) (2 weeks ago) [Vivek] * fb56d6d - Maximum non-zero FEC histogram bin (sonic-net#3919) (2 weeks ago) [Prince George] * c87bf6c - [FC] Reduce sairedis calls by efficient caching (sonic-net#3854) (3 weeks ago) [Vivek] * 287461b - [vs]: Remove non-default objects on dynamic buffer model teardown (sonic-net#3931) (3 weeks ago) [Nazarii Hnydyn] * 36c598c - Make fpmsyncd capable of handling route replace semantics (sonic-net#3872) (3 weeks ago) [venkit-nexthop] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Feng Pan <[email protected]>
xwjiang-ms
pushed a commit
to xwjiang-ms/sonic-buildimage
that referenced
this pull request
Dec 22, 2025
…lly (sonic-net#24266) #### Why I did it src/sonic-swss ``` * 3ccfa62 - (HEAD -> master, origin/master, origin/HEAD) [orchagent] Add FEC frame loss ratio monitoring with predictive analytics (sonic-net#3869) (3 days ago) [Apoorv Sachan] * 2018ed3 - Add mock test for IPv4/IPv6 route add/delete (sonic-net#3839) (3 days ago) [meghtony] * 47df807 - [portsorch] Fixed port comparison logic executed every doTask for every port (sonic-net#3821) (3 days ago) [Stepan Blyshchak] * 0c60bdb - [ssw][ha] use endpoint IP to for tunnel term acl (sonic-net#3897) (3 days ago) [Jing Zhang] * 80c742c - [muxorch] Fix handling mux neighbors learned after route (sonic-net#3937) (4 days ago) [Nikola Dancejic] * bd47953 - [Vnetorch] Ecmp vnet local routes (sonic-net#3935) (7 days ago) [Leyza] * 5de5922 - [FC] Set FC delay in command line parameters (sonic-net#3814) (8 days ago) [Stepan Blyshchak] * 85a0615 - [ssw][ha] set `SAI_ENI_ATTR_IS_HA_FLOW_OWNER` & `SAI_ENI_ATTR_HA_SCOPE_ID` when creating eni (sonic-net#3881) (11 days ago) [Jing Zhang] * bc40a04 - Skip flush if ring buffer is not empty or thread is not in idle (sonic-net#3895) (11 days ago) [Eddie Ruan] * ab96400 - [trim]: Update log level severity to avoid errors during attribute/enum capabilities query (sonic-net#3916) (2 weeks ago) [Nazarii Hnydyn] * 582eed0 - [vs]: Fix trimming test cases: avoid config consolidation (sonic-net#3939) (2 weeks ago) [Nazarii Hnydyn] * 34b9f36 - [vs]: Fix trimming test cases: avoid NULL OID polling (sonic-net#3943) (2 weeks ago) [Nazarii Hnydyn] * 8b8918a - [ACL] Populate SAI tunnel term correctly (sonic-net#3924) (2 weeks ago) [Vivek] * fb56d6d - Maximum non-zero FEC histogram bin (sonic-net#3919) (2 weeks ago) [Prince George] * c87bf6c - [FC] Reduce sairedis calls by efficient caching (sonic-net#3854) (3 weeks ago) [Vivek] * 287461b - [vs]: Remove non-default objects on dynamic buffer model teardown (sonic-net#3931) (3 weeks ago) [Nazarii Hnydyn] * 36c598c - Make fpmsyncd capable of handling route replace semantics (sonic-net#3872) (3 weeks ago) [venkit-nexthop] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: xiaweijiang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
In S5232f platform, transceiver change event in s5232 exits with the following trace.
Process Process-1:
Traceback (most recent call last):
File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
self.run()
File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
self._target(*self._args, **self._kwargs)
File "/usr/bin/xcvrd", line 795, in task_worker
status, port_dict = _wrapper_get_transceiver_change_event(timeout)
File "/usr/bin/xcvrd", line 158, in _wrapper_get_transceiver_change_event
return platform_sfputil.get_transceiver_change_event(timeout)
TypeError: get_transceiver_change_event() takes exactly 1 argument (2 give
- How I did it
Use timeout argument in get_transceiver_change_event() function.
- How to verify it
To fix the issue,use timeout argument as xcvrd uses it.
- Description for the changelog
Check xcvrd throws any error and verify related show command outputs
- A picture of a cute animal (not mandatory but encouraged)