Add support of HwSKU Mellanox-SN2700-C28D8#2690
Merged
lguohan merged 2 commits intosonic-net:201803from Mar 28, 2019
Merged
Conversation
Signed-off-by: Andriy Moroz <[email protected]>
qiluo-msft
approved these changes
Mar 22, 2019
Collaborator
qiluo-msft
left a comment
qiluo-msft
left a comment
There was a problem hiding this comment.
Please also cherry-pick to master and all release branch after 201803
Collaborator
|
it should be other way around. the PR should be generated against master, then cherry-pick into a release branch. |
lguohan
requested changes
Mar 22, 2019
Collaborator
lguohan
left a comment
lguohan
left a comment
There was a problem hiding this comment.
please submit pr into master branch.
Collaborator
Author
|
cannot be directly merged from master because in master qos config is a template while in 201803 it is a json |
Signed-off-by: Andriy Moroz <[email protected]>
lguohan
approved these changes
Mar 25, 2019
Collaborator
|
@andriymoroz-mlnx , can you mark this as ready for review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Moroz [email protected]
- What I did
- How I did it
- How to verify it
(not sure this is really needed, just to make sure it will pick up a new sai prorile)
sudo sfputil show presenceand there is no exception.Ports were created as expected with the speed according to the schema provided by Qi.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)