Skip to content

DellEMC S6000 xcvrd support#2560

Merged
lguohan merged 8 commits intosonic-net:masterfrom
paavaanan:s6000-xcvrd-support
Apr 30, 2019
Merged

DellEMC S6000 xcvrd support#2560
lguohan merged 8 commits intosonic-net:masterfrom
paavaanan:s6000-xcvrd-support

Conversation

@paavaanan
Copy link
Copy Markdown
Contributor

- What I did

  • Added xcvrd support for DellEMC S600 switches.

- How I did it

  • get_transceiver_change_event() in spfputil.py check for default presence registers and if any state-change happens on ports, the difference is updated and propgrated to xcvrd.

- How to verify it

  • sfputil show eeprom

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Copy link
Copy Markdown
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the sleep?

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Mar 2, 2019

code is still buggy.

Copy link
Copy Markdown
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that the function signature for get_transceiver_change_event() should be as follows:

def get_transceiver_change_event(self, timeout=0):

It should accept an optional timeout value. If the value is 0, it should block indefinitely until an event is received, otherwise, it should block until the timeout expires. Please see the comments in the API definition; https://github.com/Azure/sonic-platform-common/blob/92b54b1984db0b71196e4fe68cc5a09796fd185c/sonic_sfp/sfputilbase.py#L1097

@paavaanan
Copy link
Copy Markdown
Contributor Author

Joe, I agree with the standards, but in S6000 we are using polling method so we used a 1 second delay in while loop if no change in transceiver status. Instead, if an OIR change is detected we return updated port_dict to xcvrd. So, the core need for timeout variable is achieved without using that in the code. The code block indefinitely until an OIR change is detected without timeout variable. I modified the function definition as per the API standard.

@paavaanan
Copy link
Copy Markdown
Contributor Author

Joe, added timeout support in xcvrd. Here we used time.time() library which is which is subject to variance as per system clock adjustments. This helps us to detect modified time variations. We handle timeout value and update port_dict within the given timeout value. Only incremental updates are sent to xcvrd. We sleep if there is no change with 1 second granularity..

@jleveque
Copy link
Copy Markdown
Contributor

@lguohan: Please review again.

@lguohan lguohan merged commit 818bbe8 into sonic-net:master Apr 30, 2019
yxieca pushed a commit that referenced this pull request Apr 30, 2019
* DellEMC S6000, xcvrd support

* sleep 1 second to avoid busy looping

* removal of dead code

* Correct typo error to 1 second

* Introduced 1 second sleep

* Revamped script with blocking call support

* get_transceiver_change_event api definition update

* adding timeout support for get_transceiver_change_event
MichelMoriniaux pushed a commit to criteo-forks/sonic-buildimage that referenced this pull request May 28, 2019
* DellEMC S6000, xcvrd support

* sleep 1 second to avoid busy looping

* removal of dead code

* Correct typo error to 1 second

* Introduced 1 second sleep

* Revamped script with blocking call support

* get_transceiver_change_event api definition update

* adding timeout support for get_transceiver_change_event
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Dec 16, 2022
…ule head

utilities:
* f40d82f 2022-12-15 | [db_migrator] Fix migration of Loopback data: handle all Loopback interfaces (sonic-net#2560) (HEAD -> 202205) [Vaibhav Hemant Dixit]
* efd2ab8 2022-12-14 | [muxcable][show] update `show mux tunnel-route` to separate ASIC and kernel into two columns (sonic-net#2553) (HEAD -> 202205) [Jing Zhang]

kernel:
* 085d8cb 2022-12-14 | Merge pull request sonic-net#303 from madhava28/cisco/kernel_config (HEAD -> 202205) [Saikrishna Arcot]

swss:
* d8e46b9 2022-12-16 | [muxorch] Skip programming ACL for standby `active-active` ports (sonic-net#2569) (HEAD -> 202205) [Longxiang Lyu]

dhcprelay:
* 9b30690 2022-12-17 | fix handleSwssNotification crash in dhcp6relay (sonic-net#28) (HEAD, github/master) [jcaiMR]

sairedis:
* abe242a 2022-12-16 | Manage LANES mapping on VOQ system (sonic-net#1127) (HEAD -> 202205) [Bohan Yang]

Signed-off-by: Ying Xie <[email protected]>
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Dec 20, 2022
utilities:
* f0fc333e 2022-12-15 | [db_migrator] Fix migration of Loopback data: handle all Loopback interfaces (sonic-net#2560) (HEAD -> 202012, github/202012) [Vaibhav Hemant Dixit]
* ad7a4d42 2022-11-30 | Support for platforms based on Clounix Networks' device (sonic-net#2108) [songqh2022]

Signed-off-by: Ying Xie <[email protected]>
yxieca added a commit that referenced this pull request Dec 22, 2022
utilities:
* f0fc333e 2022-12-15 | [db_migrator] Fix migration of Loopback data: handle all Loopback interfaces (#2560) (HEAD -> 202012, github/202012) [Vaibhav Hemant Dixit]
* ad7a4d42 2022-11-30 | Support for platforms based on Clounix Networks' device (#2108) [songqh2022]

Signed-off-by: Ying Xie <[email protected]>

Signed-off-by: Ying Xie <[email protected]>
StormLiangMS added a commit that referenced this pull request Jan 14, 2023
#13202

advance sonic-utilities submodule for 202211 branch

34428157 - (HEAD, origin/202211) Revert "Optimize the execution time of the 'show techsupport' script to 5-10%, (Qos config change #2504)" (6 days ago) [stormliang]
c3bd01f6 - Revert "[generate_dump] Optimize the execution time of 'show techsupport' CLI by parallel function execution ([201811][Devices] Add new device CIG CS6436-56P #2512)" (6 days ago) [stormliang]
5a326d8b - [Mellanox] Change severity to NOTICE in Mellanox buffer migrator when unable to fetch DEVICE_METADATA due to empty CONFIG_DB during initialization ([warm boot] cherry-pick PR #2538 and advance related sub-modules in 201811 branch #2569) (2 weeks ago) [Stephen Sun]
50b36ef3 - Fix issue: unconfigured PGs are displayed in watermarkstat ([docker-lldp]: fix several issues in lldpd docker #2556) (2 weeks ago) [Stephen Sun]
a9fd2a79 - [Command Ref] Add doc for syslog rate limit ([sub module] move sairedis and swss to 201811 branch #2508) (2 weeks ago) [Junchao-Mellanox]
80546ff3 - [generate_dump] Optimize the execution time of 'show techsupport' CLI by parallel function execution ([201811][Devices] Add new device CIG CS6436-56P #2512) (2 weeks ago) [Vadym Hlushko]
6649ca8a - [timer.unit.j2] use wanted-by in timer unit ([201803] [services] Restart SwSS service upon unexpected critical process exit #2546) (2 weeks ago) [Stepan Blyshchak]
dd23d0ef - Fixes [Sub-If|VRF] Unbind sub-interface from VRF is failed #12170: Delete subinterface and recreate the subinterface in ([VLAN] "show mac" doesn't work when interface added to vlan as tagged member #2513) (2 weeks ago) [Preetham]
236749d3 - [db_migrator] Fix migration of Loopback data: handle all Loopback interfaces (DellEMC S6000 xcvrd support #2560) (2 weeks ago) [Vaibhav Hemant Dixit]
5762d814 - Optimize the execution time of the 'show techsupport' script to 5-10%, (Qos config change #2504) (2 weeks ago) [Vadym Hlushko]
d3c3e368 - [muxcable][show] update show mux tunnel-route to separate ASIC and kernel into two columns (build errors on branch 201811 for centec platform #2553) (2 weeks ago) [Jing Zhang]
c98648a1 - [show]Fix show route return code on error (Dell SMF driver hwmon number reorder fix for Dell S6100/Z9100 #2542) (2 weeks ago) [Sudharsan Dhamal Gopalarathnam]
01374673 - [route_check]: Ignore ASIC only SOC IPs (Added new SN3700/SN3700C Mellanox platforms #2548) (2 weeks ago) [Lawrence Lee]
d2967805 - YANG Validation for ConfigDB Updates: WARM_RESTART, SFLOW_SESSION, SFLOW, VXLAN_TUNNEL, VXLAN_EVPN_NVO, VXLAN_TUNNEL_MAP, MGMT_VRF_CONFIG, CABLE_LENGTH, VRF tables ([submodule 201811] advance sairedis and swss submodule for 201811 branch #2526) (2 weeks ago) [isabelmsft]
88b01ffd - [db_migrator] Remove import of swsssdk as it is not supported in master ([build]: apply proxy setting to curl. #2544) (2 weeks ago) [Vaibhav Hemant Dixit]
4ae970c6 - Support syslog rate limit configuration for containers and host (Move FRR from 4.0 to 6.0.2 and make new frr version and pkg compile #2454) (2 weeks ago) [Junchao-Mellanox]
608ed147 - [generate_dump] [Mellanox] Fix the duplicate dfw dump collection problem by adding symlinks ('show vlan config' is not displaying the VLAN members, after the clear config and reload with default l2 configuration. #2536) (2 weeks ago) [Vivek]
bdc2599f - [config] Add check in config interface ip command to block if the interface is portchannel member ([sub module] advance sonic-swss sub module #2539) (2 weeks ago) [Sudharsan Dhamal Gopalarathnam]
cff4fed5 - [system-health] Improve code structure of system health CLIs ([sub-module] advance sonic-swss sub-module #2453) (2 weeks ago) [Junchao-Mellanox]
488e5714 - Transceiver eeprom dom CLI modification to show output from TRANSCEIVER_DOM_THRESHOLD table (Fix for KeyError: 'DEVICE_NEIGHBOR' when executing 'show interfaces neighbor expected' command #2535) (2 weeks ago) [mihirpat1]
07ca5def - sonic-utilities: Update config reload() to verify formatting of an input file ([ntp]: Do not disable reader for error ENOBUFS #2529) (2 weeks ago) [Caitlin Choate]
f0f083a2 - [GCU] Add RemoveCreateOnlyDependency Validator/Generator (Enabling Fast-reboot command in s6100 loaded with T0 topo getting Failed unmounting /host error #2500) (2 weeks ago) [jingwenxie]
eca0253c - [QoS] Introduce delay to the qos reload flow (Config reload/load_minigraph not clearing State DB #2503) (2 weeks ago) [DavidZagury]
35158ee0 - Use github code scanning instead of LGTM ([sub module] sub module sonic-swss-common tracking 201811 branch #2530) (2 weeks ago) [Liu Shilong]
682b5cee - Change show kube command default value of insecure key to True ([submodule] update sonic-snmpagent #2517) (2 weeks ago) [lixiaoyuner]
ce19e631 - Add db_migrator_constants.py script to setup.py (Add device data for Arista 7060PX/DX4-32 #2534) (2 weeks ago) [Vaibhav Hemant Dixit]
0d0c2693 - [drop counters] Fix CLI script for unconfigured PGs ([config] Do not fail for minigraphs which do not have neighbors listed in <Devices> section #2518) (2 weeks ago) [Lior Avramov]
2c69d0fd - Update vrf add, del commands for duplicate/non-existing VRFs (solve package build dependency issue #2467) (2 weeks ago) [Muhammad Danish]
efc09280 - Port 202012 DB migration changes to newer branches ([vs]: Force10-S6000 buffer settings for virtual switch #2515) (2 weeks ago) [Vaibhav Hemant Dixit]
70a15aaa - [VXLAN]Fixing traceback in show remotemac when mac moves during command execution ([build] When generating image version, handle case where current commit has no reachable tags #2506) (2 weeks ago) [Sudharsan Dhamal Gopalarathnam]
rabbit-nexthop pushed a commit to nexthop-ai/sonic-buildimage that referenced this pull request Mar 26, 2026
<!-- Please provide the following information: -->

#### Why I did it

TH5-512 was using the same conversion function as TH5-320. This resulted
in the temperature being misreported: ~10C lower than actual.

#### How I did it

Separated the formula for TH5-320 and TH5-512.

#### How to verify it

Verified after the update.

GOLD
```
admin@gold220:~$ show plat temp | head -n 80
                Sensor    Temperature    High TH    Low TH    Crit High TH    Crit Low TH    Warning          Timestamp
----------------------  -------------  ---------  --------  --------------  -------------  ---------  -----------------
          ASIC Diode 0         78.625      120.0       N/A           127.0            N/A      False  20251224 21:42:04
          ASIC Diode 1           79.0      120.0       N/A           127.0            N/A      False  20251224 21:42:04
              ASIC Max         76.566      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC Min         62.428      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm0           68.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm1           67.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm2           71.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm3           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm4           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm5           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm6           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm7           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm8           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm9           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm10           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm11           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm12           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm13           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm14           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm15           72.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm16           72.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm17           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm18           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm19           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm20           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm21           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm22           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm23           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm24           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm25           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm26           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm27           71.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm28           69.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm29           69.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm30           66.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm31           66.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm32           67.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm33           66.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm34           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm35           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm36           72.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm37           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm38           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm39           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm40           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm41           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm42           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm43           75.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm44           75.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm45           75.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm46           75.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm47           76.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm48           76.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm49           76.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm50           75.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm51           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm52           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm53           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm54           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm55           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm56           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm57           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm58           72.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm59           71.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm60           71.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm61           72.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm62           67.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm63           67.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
          ASIC pm_mgmt           64.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon0           65.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon1           67.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon2           65.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon3           67.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon4           63.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon5           64.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon6           67.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon7           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon8           66.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
```

GOLF
```
admin@golf302:~$ show plat temp | head -n 80
                Sensor    Temperature    High TH    Low TH    Crit High TH    Crit Low TH    Warning          Timestamp
----------------------  -------------  ---------  --------  --------------  -------------  ---------  -----------------
          ASIC Diode 0           64.5      120.0       N/A           127.0            N/A      False  20250626 15:06:51
          ASIC Diode 1         64.313      120.0       N/A           127.0            N/A      False  20250626 15:06:51
              ASIC Max         64.884      105.0       N/A           112.0            N/A      False  20250626 15:06:52
              ASIC Min         51.709      105.0       N/A           112.0            N/A      False  20250626 15:06:52
              ASIC pm0           54.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm1           56.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm2           60.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm3           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm4           60.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm5           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm6           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm7           60.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm8           60.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm9           59.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm10           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm11           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm12           62.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm13           65.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm14           65.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm15           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm16           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm17           65.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm18           65.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm19           62.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm20           62.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm21           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm22           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm23           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm24           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm25           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm26           62.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm27           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm28           60.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm29           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm30           57.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm31           56.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm32           55.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm33           56.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm34           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm35           59.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm36           57.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm37           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm38           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm39           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm40           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm41           57.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm42           57.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm43           56.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm44           59.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm45           60.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm46           59.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm47           59.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm48           60.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm49           63.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm50           64.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm51           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm52           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm53           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm54           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm55           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm56           62.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm57           62.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm58           62.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm59           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm60           56.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm61           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm62           54.0      105.0       N/A           112.0            N/A      False  20250626 15:06:52
             ASIC pm63           52.0      105.0       N/A           112.0            N/A      False  20250626 15:06:52
          ASIC pm_mgmt           52.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon0           55.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon1           56.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon2           60.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon3           57.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon4           56.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon5           56.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon6           54.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon7           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon8           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
```

#### Which release branch to backport (provide reason below if selected)

- [x] 202505

#### Tested branch (Please provide the tested image version)

- master

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under
sonic-utilities repo. where, Generic Config and Update feature has been
labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
rabbit-nexthop pushed a commit to nexthop-ai/sonic-buildimage that referenced this pull request Mar 26, 2026
<!-- Please provide the following information: -->

#### Why I did it

TH5-512 was using the same conversion function as TH5-320. This resulted
in the temperature being misreported: ~10C lower than actual.

#### How I did it

Separated the formula for TH5-320 and TH5-512.

#### How to verify it

Verified after the update.

GOLD
```
admin@gold220:~$ show plat temp | head -n 80
                Sensor    Temperature    High TH    Low TH    Crit High TH    Crit Low TH    Warning          Timestamp
----------------------  -------------  ---------  --------  --------------  -------------  ---------  -----------------
          ASIC Diode 0         78.625      120.0       N/A           127.0            N/A      False  20251224 21:42:04
          ASIC Diode 1           79.0      120.0       N/A           127.0            N/A      False  20251224 21:42:04
              ASIC Max         76.566      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC Min         62.428      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm0           68.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm1           67.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm2           71.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm3           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm4           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm5           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm6           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm7           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm8           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
              ASIC pm9           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm10           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm11           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm12           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm13           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm14           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm15           72.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm16           72.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm17           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm18           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm19           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm20           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm21           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm22           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm23           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm24           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm25           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm26           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm27           71.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm28           69.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm29           69.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm30           66.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm31           66.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm32           67.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm33           66.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm34           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm35           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm36           72.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm37           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm38           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm39           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm40           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm41           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm42           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm43           75.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm44           75.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm45           75.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm46           75.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm47           76.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm48           76.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm49           76.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm50           75.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm51           74.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm52           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm53           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm54           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm55           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm56           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm57           73.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm58           72.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm59           71.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm60           71.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm61           72.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm62           67.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
             ASIC pm63           67.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
          ASIC pm_mgmt           64.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon0           65.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon1           67.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon2           65.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon3           67.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon4           63.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon5           64.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon6           67.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon7           70.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
      ASIC top.pvtmon8           66.0      105.0       N/A           112.0            N/A      False  20251224 21:42:04
```

GOLF
```
admin@golf302:~$ show plat temp | head -n 80
                Sensor    Temperature    High TH    Low TH    Crit High TH    Crit Low TH    Warning          Timestamp
----------------------  -------------  ---------  --------  --------------  -------------  ---------  -----------------
          ASIC Diode 0           64.5      120.0       N/A           127.0            N/A      False  20250626 15:06:51
          ASIC Diode 1         64.313      120.0       N/A           127.0            N/A      False  20250626 15:06:51
              ASIC Max         64.884      105.0       N/A           112.0            N/A      False  20250626 15:06:52
              ASIC Min         51.709      105.0       N/A           112.0            N/A      False  20250626 15:06:52
              ASIC pm0           54.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm1           56.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm2           60.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm3           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm4           60.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm5           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm6           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm7           60.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm8           60.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
              ASIC pm9           59.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm10           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm11           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm12           62.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm13           65.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm14           65.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm15           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm16           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm17           65.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm18           65.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm19           62.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm20           62.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm21           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm22           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm23           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm24           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm25           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm26           62.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm27           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm28           60.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm29           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm30           57.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm31           56.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm32           55.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm33           56.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm34           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm35           59.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm36           57.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm37           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm38           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm39           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm40           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm41           57.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm42           57.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm43           56.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm44           59.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm45           60.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm46           59.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm47           59.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm48           60.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm49           63.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm50           64.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm51           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm52           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm53           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm54           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm55           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm56           62.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm57           62.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm58           62.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm59           61.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm60           56.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm61           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
             ASIC pm62           54.0      105.0       N/A           112.0            N/A      False  20250626 15:06:52
             ASIC pm63           52.0      105.0       N/A           112.0            N/A      False  20250626 15:06:52
          ASIC pm_mgmt           52.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon0           55.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon1           56.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon2           60.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon3           57.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon4           56.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon5           56.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon6           54.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon7           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
      ASIC top.pvtmon8           58.0      105.0       N/A           112.0            N/A      False  20250626 15:06:51
```

#### Which release branch to backport (provide reason below if selected)

- [x] 202505

#### Tested branch (Please provide the tested image version)

- master

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under
sonic-utilities repo. where, Generic Config and Update feature has been
labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants