Why is this being added here? Shouldn't this be handled from initramfs?

Fixed it with varlog_size cmdline variable in platform.conf

Missing global declaration for g_board_rev. Line 72 accesses the global variable g_board_rev, but it's not declared as global in the init method (only g_board_id is declared on line 67 in the old code). Since g_board_rev is set as a module-level global in _thermals_available(), it needs to be declared as global here to be accessed correctly. Add 'global g_board_rev' after the existing global g_board_id declaration.

Commented-out code should be removed rather than left in the codebase. If this code might be needed in the future, it should be documented in version control history or added as a TODO comment explaining why it's disabled. Leaving commented code reduces maintainability and creates confusion about whether this functionality is intentional or incomplete.

Use elif instead of two separate if statements. Lines 89 checks a condition on board_rev that is mutually exclusive with the check in the surrounding conditional structure, though the change here uses if. For consistency with the pattern and to make the mutual exclusivity clear, consider using elif for line 89.

Bare except clause catches all exceptions without specifying the exception type. This can mask programming errors and make debugging difficult. Consider catching specific exceptions (e.g., ValueError, IOError) or at minimum use 'except Exception:' to allow KeyboardInterrupt and SystemExit to propagate.

Use elif instead of two separate if statements. Lines 80 and 82 both check conditions on board_rev, but they are mutually exclusive. Using elif makes this intention clearer and slightly more efficient by avoiding the second condition check when the first is true.

Bare except clause catches all exceptions without specifying the exception type. This can mask programming errors and make debugging difficult. Consider catching specific exceptions (e.g., ValueError, IOError) or at minimum use 'except Exception:' to allow KeyboardInterrupt and SystemExit to propagate.

Variable slot_id may be undefined if the exception is raised on line 107. If Chassis().get_my_slot() raises an exception, slot_id is never assigned, but it's used on lines 117 (in setup_platform_components_json call). Initialize slot_id before the try block (e.g., slot_id = -1) or handle the case where it's undefined.

Use elif instead of two separate if statements. Lines 187 checks a condition on board_rev that is mutually exclusive with line 185. Using elif makes the mutual exclusivity clear and avoids the unnecessary second condition check.

Commented-out code should be removed rather than left in the Makefile. The commented line on 102 appears to be an old build command with KBUILD_OUTPUT that has been replaced. If this might be needed in the future, document it in version control history or add a comment explaining why it's disabled.

The combination of generate_ssh_host_keys() and its use in start_polaris() will delete /etc/ssh/ssh_host* and regenerate SSH host keys on every boot, since dpu.init starts in runlevel S before ssh.service is active. This makes the device’s SSH host identity effectively ephemeral, preventing clients from reliably detecting man-in-the-middle attacks because host keys appear to change on each reboot. Limit host key regeneration to first install or the case where no host keys exist (e.g., checking for missing key files or a one-time flag) so SSH host keys remain stable across normal reboots.