Revert dynamic GLOBAL_PARAMS for reliable template passing#25461
Merged
yxieca merged 2 commits intosonic-net:masterfrom Feb 26, 2026
Merged
Revert dynamic GLOBAL_PARAMS for reliable template passing#25461yxieca merged 2 commits intosonic-net:masterfrom
yxieca merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: xiaweijiang <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines failed to run 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates SONiC buildimage Azure Pipelines definitions to stop using the nested GLOBAL_PARAMS mapping when invoking sonic-mgmt’s pr_test_template.yml, and instead pass those values as explicit top-level template parameters to make nested template propagation reliable.
Changes:
- Replace
GLOBAL_PARAMSusage with explicit parameters in the main PR pipeline (azure-pipelines.yml). - Replace
GLOBAL_PARAMSusage with explicit parameters across all baseline test rounds (.azure-pipelines/baseline_test/baseline.test.buildimage.yml).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
azure-pipelines.yml |
Passes PTF_MODIFIED directly to pr_test_template.yml@sonic-mgmt instead of via GLOBAL_PARAMS. |
.azure-pipelines/baseline_test/baseline.test.buildimage.yml |
Passes BUILD_REASON, RETRY_TIMES, STOP_ON_FAILURE, TEST_PLAN_NUM directly to the referenced sonic-mgmt PR test template for each test stage. |
wangxin
approved these changes
Feb 12, 2026
auspham
approved these changes
Feb 12, 2026
Contributor
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines failed to run 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Pterosaur
pushed a commit
to Pterosaur/sonic-buildimage
that referenced
this pull request
Feb 27, 2026
…#25461) What is the motivation for this PR PR sonic-mgmt#21636 imported GLOBAL_PARAMS to refactor pr_test_template.yml, which caused downstream templates to fail to receive parameters reliably. This aims to make parameter passing stable and predictable by replacing dynamic expansion with explicit parameters. How did you do it Reverted dynamic GLOBAL_PARAMS expansion to explicit parameters for reliable template passing. How did you verify/test it Not provided in PR description. Signed-off-by: xiaweijiang <[email protected]> Signed-off-by: Ze Gan <[email protected]>
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…#25461) What is the motivation for this PR PR sonic-mgmt#21636 imported GLOBAL_PARAMS to refactor pr_test_template.yml, which caused downstream templates to fail to receive parameters reliably. This aims to make parameter passing stable and predictable by replacing dynamic expansion with explicit parameters. How did you do it Reverted dynamic GLOBAL_PARAMS expansion to explicit parameters for reliable template passing. How did you verify/test it Not provided in PR description. Signed-off-by: xiaweijiang <[email protected]> Signed-off-by: Feng Pan <[email protected]>
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
What is the motivation for this PR PR sonic-mgmt#21636 imported GLOBAL_PARAMS to refactor pr_test_template.yml, which caused downstream templates to fail to receive parameters reliably. This aims to make parameter passing stable and predictable by replacing dynamic expansion with explicit parameters. How did you do it Reverted dynamic GLOBAL_PARAMS expansion to explicit parameters for reliable template passing. How did you verify/test it Not provided in PR description. Signed-off-by: xiaweijiang <[email protected]> Signed-off-by: dprital <[email protected]>
LuminaScript
pushed a commit
to LuminaScript/sonic-buildimage
that referenced
this pull request
Apr 7, 2026
…#25461) What is the motivation for this PR PR sonic-mgmt#21636 imported GLOBAL_PARAMS to refactor pr_test_template.yml, which caused downstream templates to fail to receive parameters reliably. This aims to make parameter passing stable and predictable by replacing dynamic expansion with explicit parameters. How did you do it Reverted dynamic GLOBAL_PARAMS expansion to explicit parameters for reliable template passing. How did you verify/test it Not provided in PR description. Signed-off-by: xiaweijiang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
PR sonic-net/sonic-mgmt#21636 imported
GLOBAL_PARAMSto refactorpr_test_template.yml, caused downstream templatesrun-test-elastictest-template.ymlto fail to receive the parameters correctly.While the top-level YAML could pass
GLOBAL_PARAMSsuccessfully to the first-level template, nested dynamic expansion inside the template does not reliably propagate key/value pairs, especially when variables or non-static values are involved.PR sonic-net/sonic-mgmt#22369 reverted the change of
GLOBAL_PARAMS.This PR aims to make parameter passing stable and predictable by replacing the dynamic each expansion with explicit parameter definitions.
Work item tracking
How I did it
Revert dynamic GLOBAL_PARAMS expansion to explicit parameters for reliable template passing.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)