[build][ci] Support uploading and pulling slave user docker image#24981
Merged
yejianquan merged 5 commits intosonic-net:masterfrom Jan 15, 2026
Merged
[build][ci] Support uploading and pulling slave user docker image#24981yejianquan merged 5 commits intosonic-net:masterfrom
yejianquan merged 5 commits intosonic-net:masterfrom
Conversation
Signed-off-by: yijingyan2 <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: yijingyan2 <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: yijingyan2 <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| if [[ "$(Build.SourceBranchName)" == "master" ]];then | ||
| docker tag ${image_tag} ${REGISTRY_SERVER}/${image_latest} | ||
| docker push ${REGISTRY_SERVER}/${image_latest} | ||
| docker tag ${user_image_tag} ${REGISTRY_SERVER}/${user_image_latest} |
Contributor
There was a problem hiding this comment.
We don't need these 2 lines. We need:
docker push ${REGISTRY_SERVER}/${user_image_tag}
We need change Makefile try pull ${REGISTRY_SERVER}/${user_image_tag} first.
If not exist, pull ${REGISTRY_SERVER}/${image_tag}. If it also not exist, build locally.
Contributor
Author
There was a problem hiding this comment.
made some changes according to this, can you help review? thanks
Signed-off-by: yijingyan2 <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: yijingyan2 <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yijingyan2
changed the title
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…nic-net#24981) Why I did it Support pulling slave user image first Update pipeline to push related image to ACR Signed-off-by: yijingyan2 <[email protected]> Signed-off-by: Feng Pan <[email protected]>
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
…4981) Why I did it Support pulling slave user image first Update pipeline to push related image to ACR Signed-off-by: yijingyan2 <[email protected]> Signed-off-by: dprital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Work item tracking