Skip to content

Improve GNMI_CLIENT_CERT table to support multiple roles.#21849

Merged
qiluo-msft merged 11 commits intosonic-net:masterfrom
liuh-80:dev/liuh/gnmi_multiple_role
Apr 28, 2025
Merged

Improve GNMI_CLIENT_CERT table to support multiple roles.#21849
qiluo-msft merged 11 commits intosonic-net:masterfrom
liuh-80:dev/liuh/gnmi_multiple_role

Conversation

@liuh-80
Copy link
Copy Markdown
Contributor

@liuh-80 liuh-80 commented Feb 25, 2025

Improve GNMI_CLIENT_CERT table to support multiple roles.

Why I did it

GNMI need support multiple roles.
HLD: sonic-net/SONiC#1967

Work item tracking
  • Microsoft ADO (number only):31561802

How I did it

Change GNMI_CLIENT_CERT table yang model.

How to verify it

Pass all test case.

This PR depends on following PRs:
sonic-net/sonic-gnmi#366
sonic-net/sonic-mgmt#17866

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Improve GNMI_CLIENT_CERT table to support multiple roles.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Feb 26, 2025

/azpw run Azure.sonic-buildimage

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Feb 26, 2025

azpw command does not work, close and reopen to trigger build

@liuh-80 liuh-80 closed this Feb 26, 2025
@liuh-80 liuh-80 reopened this Feb 26, 2025
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Feb 28, 2025

test case in gnmi/test_gnmi_configdb.py failed because yang validation break.
related test case need ignore before apply change then add back after all change merged
maybe ignore test case by yang model schema.

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80 liuh-80 force-pushed the dev/liuh/gnmi_multiple_role branch from 9d04798 to fcfff8d Compare April 6, 2025 02:37
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202411: #23448

@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202405: #23449

@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202311: #23456

@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-buildimage-msft#1420

opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
Why I did it
GNMI service will change to mapping cname to a role list:
sonic-net/sonic-buildimage#21849

To make sure GNMI test case in sonic-mgmt can pass with/without this change, we need improve test case to handle both case.

Work item tracking
Microsoft ADO: 31561802
How I did it
Ignore test case bug github issue: sonic-net#17876
Change GNMI setup code to handle role list by check yang model

How to verify it
Pass all test case.

Signed-off-by: opcoder0 <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
Why I did it
GNMI service will change to mapping cname to a role list:
sonic-net/sonic-buildimage#21849

To make sure GNMI test case in sonic-mgmt can pass with/without this change, we need improve test case to handle both case.

Work item tracking
Microsoft ADO: 31561802
How I did it
Ignore test case bug github issue: sonic-net#17876
Change GNMI setup code to handle role list by check yang model

How to verify it
Pass all test case.

Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
Why I did it
GNMI service will change to mapping cname to a role list:
sonic-net/sonic-buildimage#21849

To make sure GNMI test case in sonic-mgmt can pass with/without this change, we need improve test case to handle both case.

Work item tracking
Microsoft ADO: 31561802
How I did it
Ignore test case bug github issue: sonic-net#17876
Change GNMI setup code to handle role list by check yang model

How to verify it
Pass all test case.

Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
Why I did it
GNMI service will change to mapping cname to a role list:
sonic-net/sonic-buildimage#21849

To make sure GNMI test case in sonic-mgmt can pass with/without this change, we need improve test case to handle both case.

Work item tracking
Microsoft ADO: 31561802
How I did it
Ignore test case bug github issue: sonic-net#17876
Change GNMI setup code to handle role list by check yang model

How to verify it
Pass all test case.

Signed-off-by: Guy Shemesh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants