[chassis-packet][SNMP] Enable SNMP dynamic frequency on packet chassis#21355
Merged
yxieca merged 2 commits intosonic-net:masterfrom Jan 14, 2025
Merged
[chassis-packet][SNMP] Enable SNMP dynamic frequency on packet chassis#21355yxieca merged 2 commits intosonic-net:masterfrom
yxieca merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yejianquan
requested review from
SuvarnaMeenakshi and
qiluo-msft
and removed request for
qiluo-msft
Contributor
Author
|
convert to draft since it depends on https://github.com/sonic-net/sonic-snmpagent/pull/345/files to be merged and sub-module advanced |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 21355 in repo sonic-net/sonic-buildimage |
Contributor
|
One question, why we don't enable this on all platform? Any side impact to enable this dynamic frequency SNMP? @qiluo-msft @SuvarnaMeenakshi to comment. |
Contributor
Author
|
PR build finished, but likely there's status syncing issue.
|
qiluo-msft
approved these changes
Jan 14, 2025
Contributor
Author
|
Please wait for snmp sub-module advanced finished Then we can merge this PR |
Merged
12 tasks
Collaborator
|
Cherry-pick PR to 202405: #21429 |
Merged
12 tasks
Collaborator
|
Cherry-pick PR to 202411: #21430 |
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
sonic-net#21355) Why I did it It's one part of the fixes of sonic-net#21314 SNMP walker request will always timeout when 100% CPU utilization. Work item tracking Microsoft ADO 30112399: How I did it Enable SNMP dynamic frequency on packet chassis. How to verify it snmp/test_snmp_cpu.py(https://github.com/sonic-net/sonic-mgmt/blob/master/tests/snmp/test_snmp_cpu.py) tests the scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
It's one part of the fixes of #21314
SNMP walker request will always timeout when 100% CPU utilization.
Work item tracking
How I did it
Enable SNMP dynamic frequency on packet chassis.
How to verify it
snmp/test_snmp_cpu.py(https://github.com/sonic-net/sonic-mgmt/blob/master/tests/snmp/test_snmp_cpu.py) tests the scenario.
And the test case passes in my local run.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
For issue:
#21314
Change of SNMP-AgentX sonic-net/sonic-snmpagent#345 will fix the issue.
But we want to limit the scope of the change, since we only see this issue on packet-chassis and old devices with low performance CPUs.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)