[minigraph] populate bgp_asn in DEVICE_METADATA only if it is valid.#19413
Merged
rlhui merged 6 commits intosonic-net:masterfrom Jul 2, 2024
Merged
[minigraph] populate bgp_asn in DEVICE_METADATA only if it is valid.#19413rlhui merged 6 commits intosonic-net:masterfrom
rlhui merged 6 commits intosonic-net:masterfrom
Conversation
This reverts commit 598ab99. Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
…)" This reverts commit c11ab02.
Without this it causes Yang Validation failure for Systems that are Pure L2/Chassis Supervisor (no BGP) as Yang expects bgp_asn as valid as_number Signed-off-by: Abhishek Dosi <[email protected]>
arlakshm
previously approved these changes
Jun 28, 2024
Signed-off-by: Abhishek Dosi <[email protected]>
arlakshm
added
the
Chassis for 202205 branch
arlakshm
approved these changes
Jul 1, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jul 5, 2024
…onic-net#19413) What I did:- Populate bgp_asn in DEVICE_METADATA only if is present/valid. Why I did: Without this it causes Yang Validation failure for Systems that are Pure L2/Chassis Supervisor (no BGP) as Yang expects bgp_asn as valid as_number --------- Signed-off-by: Abhishek Dosi <[email protected]>
Collaborator
|
Cherry-pick PR to 202405: #19493 |
mssonicbld
pushed a commit
that referenced
this pull request
Jul 7, 2024
…19413) What I did:- Populate bgp_asn in DEVICE_METADATA only if is present/valid. Why I did: Without this it causes Yang Validation failure for Systems that are Pure L2/Chassis Supervisor (no BGP) as Yang expects bgp_asn as valid as_number --------- Signed-off-by: Abhishek Dosi <[email protected]>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
abdosi
removed
the
Chassis for 202205 branch
gechiang
added
the
Chassis for 202205 branch
10 tasks
gechiang
added
the
Included in Chassis for 202205 Branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:-
Populate bgp_asn in DEVICE_METADATA only if is present/valid.
Why I did:
Without this it causes Yang Validation failure for Systems that are Pure
L2/Chassis Supervisor (no BGP) as Yang expects bgp_asn as valid
as_number
How I verify:
UT updated. Reverted this PR: #9640 which updated graph to pass Yang Validation . Now with this change we don't need to make change in graph.