[service] introducing serial port watchdog service#1743
Merged
yxieca merged 4 commits intosonic-net:masterfrom May 25, 2018
Merged
[service] introducing serial port watchdog service#1743yxieca merged 4 commits intosonic-net:masterfrom
yxieca merged 4 commits intosonic-net:masterfrom
Conversation
Monitor serial port processes. Kill ones stuck for too long. Signed-off-by: Ying Xie <[email protected]>
Signed-off-by: Ying Xie <[email protected]>
Signed-off-by: Ying Xie <[email protected]>
Contributor
Author
|
We have some going discussion on the baud-rate PR. I refactored the rc.local changes, putting infrastructure changes in separate commits. So either one could check in independently and leave minimum change for the other PR. |
lguohan
approved these changes
May 25, 2018
lguohan
pushed a commit
that referenced
this pull request
May 26, 2018
* [rc.local] refactor platform identification code to separate function Signed-off-by: Ying Xie <[email protected]> * [rc.local] infrastructure to take action according to installer.conf * [serial port watchdog] add service to watch serial port processes Monitor serial port processes. Kill ones stuck for too long. Signed-off-by: Ying Xie <[email protected]> * [rc.local] start watchdog on serial port specified by installer.conf Signed-off-by: Ying Xie <[email protected]>
qiluo-msft
reviewed
May 30, 2018
| [Unit] | ||
| Description=Monitor serial port processes, kill stuck ones | ||
| Requires= | ||
| After=rc.local.Service |
Collaborator
There was a problem hiding this comment.
S [](start = 15, length = 1)
lower case S?
qiluo-msft
reviewed
May 30, 2018
| { | ||
| sed -i "s|ttyS.|ttyS$CONSOLE_DEV|g" /etc/systemd/system/serial-port-watchdog.service | ||
| systemctl daemon-reload | ||
| systemctl restart serial-port-watchdog.service |
Collaborator
There was a problem hiding this comment.
serial-port-watchdog.service [](start = 22, length = 28)
Deadlock between rc.local and serial-port-watchdog?
qiluo-msft
added a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
Jun 5, 2018
qiluo-msft
added a commit
that referenced
this pull request
Jun 5, 2018
lguohan
pushed a commit
that referenced
this pull request
Jun 5, 2018
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
…t time (sonic-net#1646)" (sonic-net#1743) This reverts commit ee7a735.
mssonicbld
added a commit
that referenced
this pull request
Jan 31, 2026
…tically (#25251) #### Why I did it src/sonic-sairedis ``` * 8c3d40d5 - (HEAD -> master, origin/master, origin/HEAD) Add PORT_PHY_ATTR flex counter support (#1674) (9 hours ago) [Dhanasekar Rathinavel] * 5966a71b - Update SAI Header to latest (#1742) (2 days ago) [Tejaswini Chadaga] * 2752ad6c - [multi-asic][Mellanox] add support for Mellanox multi-asic (#1683) (3 days ago) [Yakiv Huryk] * c4e3c142 - Fix deadlock between syncd and orchagent syncd during initialization failure (#1723) (7 days ago) [DavidZagury] * 50c5626c - Fix dash meter COUNTERS_DB keys to use VID instead of RID (#1725) (8 days ago) [Mukesh Moopath Velayudhan] * 7632eebb - [Mellanox] Add phcsync activation for mellanox platforms. (#1734) (9 days ago) [Zili Bombach] * 9eeffe38 - fix docker slave name (#1730) (10 days ago) [yijingyan2] * 90670166 - Use matching slave container from the branch we're building against (#1743) (10 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog
xincunli-sonic
pushed a commit
to xincunli-sonic/sonic-buildimage
that referenced
this pull request
Feb 2, 2026
…tically (sonic-net#25251) #### Why I did it src/sonic-sairedis ``` * 8c3d40d5 - (HEAD -> master, origin/master, origin/HEAD) Add PORT_PHY_ATTR flex counter support (sonic-net#1674) (9 hours ago) [Dhanasekar Rathinavel] * 5966a71b - Update SAI Header to latest (sonic-net#1742) (2 days ago) [Tejaswini Chadaga] * 2752ad6c - [multi-asic][Mellanox] add support for Mellanox multi-asic (sonic-net#1683) (3 days ago) [Yakiv Huryk] * c4e3c142 - Fix deadlock between syncd and orchagent syncd during initialization failure (sonic-net#1723) (7 days ago) [DavidZagury] * 50c5626c - Fix dash meter COUNTERS_DB keys to use VID instead of RID (sonic-net#1725) (8 days ago) [Mukesh Moopath Velayudhan] * 7632eebb - [Mellanox] Add phcsync activation for mellanox platforms. (sonic-net#1734) (9 days ago) [Zili Bombach] * 9eeffe38 - fix docker slave name (sonic-net#1730) (10 days ago) [yijingyan2] * 90670166 - Use matching slave container from the branch we're building against (sonic-net#1743) (10 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Xincun Li <[email protected]>
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…tically (sonic-net#25251) #### Why I did it src/sonic-sairedis ``` * 8c3d40d5 - (HEAD -> master, origin/master, origin/HEAD) Add PORT_PHY_ATTR flex counter support (sonic-net#1674) (9 hours ago) [Dhanasekar Rathinavel] * 5966a71b - Update SAI Header to latest (sonic-net#1742) (2 days ago) [Tejaswini Chadaga] * 2752ad6c - [multi-asic][Mellanox] add support for Mellanox multi-asic (sonic-net#1683) (3 days ago) [Yakiv Huryk] * c4e3c142 - Fix deadlock between syncd and orchagent syncd during initialization failure (sonic-net#1723) (7 days ago) [DavidZagury] * 50c5626c - Fix dash meter COUNTERS_DB keys to use VID instead of RID (sonic-net#1725) (8 days ago) [Mukesh Moopath Velayudhan] * 7632eebb - [Mellanox] Add phcsync activation for mellanox platforms. (sonic-net#1734) (9 days ago) [Zili Bombach] * 9eeffe38 - fix docker slave name (sonic-net#1730) (10 days ago) [yijingyan2] * 90670166 - Use matching slave container from the branch we're building against (sonic-net#1743) (10 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Feng Pan <[email protected]>
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
…tically (#25251) #### Why I did it src/sonic-sairedis ``` * 8c3d40d5 - (HEAD -> master, origin/master, origin/HEAD) Add PORT_PHY_ATTR flex counter support (#1674) (9 hours ago) [Dhanasekar Rathinavel] * 5966a71b - Update SAI Header to latest (#1742) (2 days ago) [Tejaswini Chadaga] * 2752ad6c - [multi-asic][Mellanox] add support for Mellanox multi-asic (#1683) (3 days ago) [Yakiv Huryk] * c4e3c142 - Fix deadlock between syncd and orchagent syncd during initialization failure (#1723) (7 days ago) [DavidZagury] * 50c5626c - Fix dash meter COUNTERS_DB keys to use VID instead of RID (#1725) (8 days ago) [Mukesh Moopath Velayudhan] * 7632eebb - [Mellanox] Add phcsync activation for mellanox platforms. (#1734) (9 days ago) [Zili Bombach] * 9eeffe38 - fix docker slave name (#1730) (10 days ago) [yijingyan2] * 90670166 - Use matching slave container from the branch we're building against (#1743) (10 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: dprital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Introducing a serial port watchdog service. The service watches the processes running off the serial
console port. If a process is observed stuck without IO proceeding for too long, the service will
try to kill the process.
- How to verify it
The test was done in a few separate part: