Closed
Conversation
Collaborator
|
can you resolve conflict? kernel has been moved to 4.9 now. |
Collaborator
|
the pr is too old, can you resolve the conflict? is it still needed, if not can we close it? |
Contributor
Author
|
Close this PR due to this is old version |
vivekrnv
added a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Apr 26, 2021
d9f28b6 [SflowMgr] SamplingRate Update by Speed Change Added (sonic-net#1721) 6c02acf [MACsec]: Set macsec to bypass by default (sonic-net#1719) 9720f74 [Monitor Vlan] Fix a typo in hostif (sonic-net#1722) Signed-off-by: Vivek Reddy Karri <[email protected]>
lguohan
pushed a commit
that referenced
this pull request
Apr 27, 2021
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
d9f28b6 [SflowMgr] SamplingRate Update by Speed Change Added (sonic-net#1721) 6c02acf [MACsec]: Set macsec to bypass by default (sonic-net#1719) 9720f74 [Monitor Vlan] Fix a typo in hostif (sonic-net#1722) Signed-off-by: Vivek Reddy Karri <[email protected]>
BasimShalata
added a commit
to BasimShalata/sonic-buildimage
that referenced
this pull request
Aug 4, 2021
This PR contains the following commits: 54b74a2 2021-08-04 [LLDP] Fix lldpshow script to enable display multiple MAC addresses on the same remote physical interface (sonic-net#1657) 0d53b7a 2021-08-03 [sonic_installer] don't print errors when installing an image not supporting app ext (sonic-net#1719) 394e2fb 2021-08-03 Implement script null_route_helper (sonic-net#1737) dd01b56 2021-08-02 disk_check updates: (sonic-net#1736) 8a74d03 2021-07-30 [CLI][show][bgp] Fix the show ip bgp network command (sonic-net#1733) 679a4ba 2021-07-30 [MACsec]: Allow upgrade-docker for macsec container (sonic-net#1716) e9c73e8 2021-07-28 [CLI][MPLS][Show] Added multi ASIC support for 'show mpls command'. Signed-off-by: Basim Shalata <[email protected]>
5 tasks
lguohan
pushed a commit
that referenced
this pull request
Aug 6, 2021
This PR is to update sonic-utilities for master branch Changes including ``` 54b74a2 [LLDP] Fix lldpshow script to enable display multiple MAC addresses on the same remote physical interface (#1657) 0d53b7a [sonic_installer] don't print errors when installing an image not supporting app ext (#1719) 394e2fb Implement script null_route_helper (#1737) ``` Signed-off-by: bingwang <[email protected]>
lguohan
pushed a commit
that referenced
this pull request
Aug 6, 2021
This PR contains the following commits: 54b74a2 2021-08-04 [LLDP] Fix lldpshow script to enable display multiple MAC addresses on the same remote physical interface (#1657) 0d53b7a 2021-08-03 [sonic_installer] don't print errors when installing an image not supporting app ext (#1719) 394e2fb 2021-08-03 Implement script null_route_helper (#1737) dd01b56 2021-08-02 disk_check updates: (#1736) 8a74d03 2021-07-30 [CLI][show][bgp] Fix the show ip bgp network command (#1733) 679a4ba 2021-07-30 [MACsec]: Allow upgrade-docker for macsec container (#1716) e9c73e8 2021-07-28 [CLI][MPLS][Show] Added multi ASIC support for 'show mpls command'. Signed-off-by: Basim Shalata <[email protected]>
judyjoseph
added a commit
that referenced
this pull request
Aug 7, 2021
8b149a3 Load the database global_db only once for show cli (#1712) cd0e560 [config][interface][speed] Fixed the config interface speed in multiasic issue (#1739) b595ba6 [fast-reboot] revert the change of disabling counter polling before fast-reboot (#1744) 8518820 [minigraph] Donot enable PFC watchdog for MgmtTsToR (#1734) 2213774 [CLI][show][bgp] Fix the show ip bgp network command (#1733) 3526507 [configlet] Python3 compatible syntax for extracting a key from the dict (#1721) 5b56b97 [sonic_installer] don't print errors when installing an image not supporting app ext (#1719) a581955 [LLDP] Fix lldpshow script to enable display multiple MAC addresses on the same remote physical interface (#1657)
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
d9f28b6 [SflowMgr] SamplingRate Update by Speed Change Added (sonic-net#1721) 6c02acf [MACsec]: Set macsec to bypass by default (sonic-net#1719) 9720f74 [Monitor Vlan] Fix a typo in hostif (sonic-net#1722) Signed-off-by: Vivek Reddy Karri <[email protected]>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
This PR is to update sonic-utilities for master branch Changes including ``` 54b74a2 [LLDP] Fix lldpshow script to enable display multiple MAC addresses on the same remote physical interface (sonic-net#1657) 0d53b7a [sonic_installer] don't print errors when installing an image not supporting app ext (sonic-net#1719) 394e2fb Implement script null_route_helper (sonic-net#1737) ``` Signed-off-by: bingwang <[email protected]>
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
In adapting to the MACsec driver for Arista 7280Cr3, we found it is necessary to set SAI_MACSEC_ATTR_PHYSICAL_BYPASS_ENABLE to True, to successfully change the MACsec status from enable to disable (expecting that the traffic can pass through without encryption thereafter). The reason behind is that the default value of the attribute is False, if it is False, the driver understands it as the user is not allowing to bypass MACsec, yielding the result of disabling MACsec not as expected.
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
…porting app ext (sonic-net#1719) FIXES: sonic-net#8149 #### What I did Don't print errors if installing app.ext incompatible image. #### How I did it Check for docker.sh existance and take an assumption that if it exists then it is app.ext compatible. #### How to verify it From master image install 202012 image and verify no errors in logs.
noaOrMlnx
pushed a commit
to noaOrMlnx/sonic-buildimage
that referenced
this pull request
Oct 26, 2025
…ng telemetry process (sonic-net#1719) #### Why I did it ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it #### How to verify it Manually tested: 0. temporarily sonic-db-cli STATE_DB del "DEVICE_METADATA|localhost" 1. start telemetry container with extra prameters: `--privileged --pid=host` 2. change config: `sonic-db-cli CONFIG_DB hset 'TELEMETRY|gnmi' client_auth false` 3. `docker load < docker-telemetry-watchdog.gz` 4. `docker run -d --name telemetrywatchdog --privileged --net=host --pid=host -t -e IMAGE_VERSION="{{.TelemetryWatchdogImageVersion}}.kube" -e SYSLOG_TARGET_IP="127.0.0.1" -p 50080:50080/tcp --tmpfs /usr/share/sonic:rw,exec,size=512m -v /usr/share/sonic/device:/usr/share/sonic/device:ro -v /etc/sonic:/etc/sonic:ro -v /etc/localtime:/etc/localtime:ro -v /host/reboot-cause:/host/reboot-cause -v /var/run/redis:/var/run/redis -v /var/run/redis-chassis:/var/run/redis-chassis:ro -v /usr/share/sonic/templates/rsyslog-container.conf.j2:/usr/share/sonic/templates/rsyslog-container.conf.j2:ro docker-telemetry-watchdog` 5. enter into telemetrywatchdog and start the server a. `docker exec -it telemetrywatchdog bash` b. `TELEMETRY_WATCHDOG_SERIALNUMBER_PROBE_ENABLED=true /usr/bin/telemetry_watchdog` 6. `curl http://127.0.0.1:50080` 7. temporarily `sonic-db-cli STATE_DB del "DEVICE_METADATA|localhost"` 8. `curl http://127.0.0.1:50080` Observed expected result for Step 6: ```json { "check_telemetry_port": "OK", "xpath_commands": [ { "xpath": "DEVICE_METADATA/localhost/chassis_serial_number", "success": true, "error": null, "duration_ms": 100 }, ``` Observed expected result for Step 8: ```json { "check_telemetry_port": "OK", "xpath_commands": [ { "xpath": "DEVICE_METADATA/localhost/chassis_serial_number", "success": false, "error": "F1002 00:24:57.809826 163585 gnmi_get.go:145] Get failed: rpc error: code = NotFound desc = No valid entry found on DEVICE_METADATA|localhost|chassis_serial_number with key DEVICE_METADATA|localhost\n (exit code: 1)", "duration_ms": 100 }, ``` #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 202205 - [ ] 202211 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
mssonicbld
added a commit
that referenced
this pull request
Dec 16, 2025
…tically (#24791) #### Why I did it src/sonic-sairedis ``` * 1bf99980 - (HEAD -> master, origin/master, origin/HEAD) changes for vpp release 202510 (#1695) (3 days ago) [aronovic] * 0ecbb5b9 - Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (#1613)" (#1676) (3 days ago) [Nikola Dancejic] * 3ab2f07d - Graceful shutdown vpp to avoid core dump (#1714) (4 days ago) [yue-fred-gao] * a5e0e632 - Revert "Temp workaround for sonic-buildimage issue 23387 (#1629)" (#1700) (4 days ago) [Ze Gan] * b735b473 - Use sonic build pool for building sairedis (#1719) (5 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog
hdwhdw
pushed a commit
to hdwhdw/sonic-buildimage
that referenced
this pull request
Dec 18, 2025
…tically (sonic-net#24791) #### Why I did it src/sonic-sairedis ``` * 1bf99980 - (HEAD -> master, origin/master, origin/HEAD) changes for vpp release 202510 (sonic-net#1695) (3 days ago) [aronovic] * 0ecbb5b9 - Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1613)" (sonic-net#1676) (3 days ago) [Nikola Dancejic] * 3ab2f07d - Graceful shutdown vpp to avoid core dump (sonic-net#1714) (4 days ago) [yue-fred-gao] * a5e0e632 - Revert "Temp workaround for sonic-buildimage issue 23387 (sonic-net#1629)" (sonic-net#1700) (4 days ago) [Ze Gan] * b735b473 - Use sonic build pool for building sairedis (sonic-net#1719) (5 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Dawei Huang <[email protected]>
xwjiang-ms
pushed a commit
to xwjiang-ms/sonic-buildimage
that referenced
this pull request
Dec 22, 2025
…tically (sonic-net#24791) #### Why I did it src/sonic-sairedis ``` * 1bf99980 - (HEAD -> master, origin/master, origin/HEAD) changes for vpp release 202510 (sonic-net#1695) (3 days ago) [aronovic] * 0ecbb5b9 - Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1613)" (sonic-net#1676) (3 days ago) [Nikola Dancejic] * 3ab2f07d - Graceful shutdown vpp to avoid core dump (sonic-net#1714) (4 days ago) [yue-fred-gao] * a5e0e632 - Revert "Temp workaround for sonic-buildimage issue 23387 (sonic-net#1629)" (sonic-net#1700) (4 days ago) [Ze Gan] * b735b473 - Use sonic build pool for building sairedis (sonic-net#1719) (5 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: xiaweijiang <[email protected]>
jasonbridges
pushed a commit
to jasonbridges/sonic-buildimage
that referenced
this pull request
Jan 22, 2026
…tically (sonic-net#24791) #### Why I did it src/sonic-sairedis ``` * 1bf99980 - (HEAD -> master, origin/master, origin/HEAD) changes for vpp release 202510 (sonic-net#1695) (3 days ago) [aronovic] * 0ecbb5b9 - Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1613)" (sonic-net#1676) (3 days ago) [Nikola Dancejic] * 3ab2f07d - Graceful shutdown vpp to avoid core dump (sonic-net#1714) (4 days ago) [yue-fred-gao] * a5e0e632 - Revert "Temp workaround for sonic-buildimage issue 23387 (sonic-net#1629)" (sonic-net#1700) (4 days ago) [Ze Gan] * b735b473 - Use sonic build pool for building sairedis (sonic-net#1719) (5 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…tically (sonic-net#24791) #### Why I did it src/sonic-sairedis ``` * 1bf99980 - (HEAD -> master, origin/master, origin/HEAD) changes for vpp release 202510 (sonic-net#1695) (3 days ago) [aronovic] * 0ecbb5b9 - Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1613)" (sonic-net#1676) (3 days ago) [Nikola Dancejic] * 3ab2f07d - Graceful shutdown vpp to avoid core dump (sonic-net#1714) (4 days ago) [yue-fred-gao] * a5e0e632 - Revert "Temp workaround for sonic-buildimage issue 23387 (sonic-net#1629)" (sonic-net#1700) (4 days ago) [Ze Gan] * b735b473 - Use sonic build pool for building sairedis (sonic-net#1719) (5 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Feng Pan <[email protected]>
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
…tically (#24791) #### Why I did it src/sonic-sairedis ``` * 1bf99980 - (HEAD -> master, origin/master, origin/HEAD) changes for vpp release 202510 (#1695) (3 days ago) [aronovic] * 0ecbb5b9 - Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (#1613)" (#1676) (3 days ago) [Nikola Dancejic] * 3ab2f07d - Graceful shutdown vpp to avoid core dump (#1714) (4 days ago) [yue-fred-gao] * a5e0e632 - Revert "Temp workaround for sonic-buildimage issue 23387 (#1629)" (#1700) (4 days ago) [Ze Gan] * b735b473 - Use sonic build pool for building sairedis (#1719) (5 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: dprital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Add ti support as7326-32x
- How I did it
Add driver code
- How to verify it
Test sysfs node
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)