[action] [PR:16114] Remove depot_tools repo#16408
Merged
mssonicbld merged 1 commit intosonic-net:202305from Sep 3, 2023
Merged
[action] [PR:16114] Remove depot_tools repo#16408mssonicbld merged 1 commit intosonic-net:202305from
mssonicbld merged 1 commit intosonic-net:202305from
Conversation
It appears that this was initially added to provide the git-retry command (which doesn't appear to be used today). However, this repo is now also providing bazel (which is actually used in our build today), and this command (along with git-retry) expects some vpython3 binary to be set up/installed. Rather than going through that, just get rid of this repo.
Collaborator
Author
|
Original PR: #16114 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
It appears that this was initially added to provide the
git-retrycommand (which doesn't appear to be used today). However, this repo is now also providingbazel(which is actually used in our build today), and this command (along withgit-retry) expects somevpython3binary to be set up/installed. The sonic-p4rt code runsbazel, which means this depot_tools version would get called instead of the regular system-installed version.Rather than going through the process of setting up/installing vpython3, just get rid of this repo.
Fixes #16087.
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)