Remove the divide by 4 operation to the under the hood SAI#1532
Merged
yxieca merged 18 commits intosonic-net:masterfrom Sep 25, 2019
Merged
Remove the divide by 4 operation to the under the hood SAI#1532yxieca merged 18 commits intosonic-net:masterfrom
yxieca merged 18 commits intosonic-net:masterfrom
Conversation
This is to avoid the need and thus the confusion for application program to know the mmu internal architecture This change must have support from SAI change to reach the correct config Signed-off-by: Wenda <[email protected]>
yxieca
requested changes
Mar 27, 2018
Contributor
yxieca
left a comment
There was a problem hiding this comment.
Wenda,
You need to change 7260, 7060, and 6100 at the same time. Basically, any TH, TH2 platform with buffer configuration needs to be updated. And you also need to wait until the sai update is in place before merging it.
Contributor
Author
|
retest this please |
lossless pool Extend to 7060 and 6100 Signed-off-by: Wenda <[email protected]>
yxieca
approved these changes
Mar 30, 2018
Contributor
yxieca
left a comment
There was a problem hiding this comment.
Please let me merge it.
I need to get SAI upgraded first.
Thanks,
Ying
Signed-off-by: Wenda Ni <[email protected]>
Signed-off-by: Wenda Ni <[email protected]>
Signed-off-by: Wenda Ni <[email protected]>
Signed-off-by: Wenda Ni <[email protected]>
- Broadcom SAI 3.5 GA release 20190924. Signed-off-by: Ying Xie <[email protected]>
Contributor
|
retest this please |
yxieca
pushed a commit
that referenced
this pull request
Sep 25, 2019
* Remove the divide by 4 operation to the under the hood SAI This is to avoid the need and thus the confusion for application program to know the mmu internal architecture This change must have support from SAI change to reach the correct config Signed-off-by: Wenda <[email protected]> * Relegate the divide by 4 operation to the under the hood SAI for egress lossless pool Extend to 7060 and 6100 Signed-off-by: Wenda <[email protected]> * Add more TH/TH2 hwskus Signed-off-by: Wenda Ni <[email protected]> * Update config test Signed-off-by: Wenda Ni <[email protected]> * Add TH2 ingress lossy profile Signed-off-by: Wenda Ni <[email protected]> * Move the divide by 4 operation to SAI internal Signed-off-by: Wenda Ni <[email protected]> * [bcm SAI] Upgrade Broadcom SAI to version 3.5.3.1-15 - Broadcom SAI 3.5 GA release 20190924. Signed-off-by: Ying Xie <[email protected]>
3 tasks
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Dec 8, 2020
Including folowing changes: - [portsorch] adjust port initialized event back to notice (sonic-net#1532) Signed-off-by: Ying Xie <[email protected]>
yxieca
added a commit
that referenced
this pull request
Dec 10, 2020
- Why I did it Advance swss submodule to pick up latest changes. - How I did it Including folowing changes: [portsorch] adjust port initialized event back to notice (#1532) Signed-off-by: Ying Xie [email protected]
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
) Signed-off-by: Ying Xie <[email protected]>
mssonicbld
added a commit
that referenced
this pull request
Feb 20, 2025
…tically (#21773) #### Why I did it src/sonic-sairedis ``` * ec8b3c30 - (HEAD -> 202411, origin/202411) Fix pipeline errors related to rsyslogd and libswsscommon installation (#1535) (16 hours ago) [mssonicbld] * 6b263b8e - [FC] Support Policer Counter (#1533) (28 hours ago) [mssonicbld] * e53489e5 - [syncd] Update log level for bulk api (#1532) (33 hours ago) [Jianyue Wu] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
to DavidZagury/sonic-buildimage
that referenced
this pull request
Apr 28, 2025
…D automatically (sonic-net#1016) #### Why I did it src/sonic-sairedis ``` * 86d1413 - (HEAD -> 202412, origin/HEAD, origin/202412) Merge pull request #45 from r12f/code-sync-202412 (31 minutes ago) [Riff] * 0fcc968 - Merge remote-tracking branch 'base/202411' into code-sync-202412 (13 hours ago) [r12f] * 4048483 - Revert "Optimize counter polling interval by making it more accurate (sonic-net#1457) …" (sonic-net#1570) (2 weeks ago) [Kumaresh Perumal] * 420d92f - Update build_and_install_module.sh to match newer Linux kernel version (sonic-net#1561) (4 weeks ago) [mssonicbld] * e2d2ca6 - [vslib] SAI_KEY_VS_OPER_SPEED_IS_CONFIGURED_SPEED, SAI_PORT_ATTR_HOST_TX_READY_STATUS support (sonic-net#1553) (5 weeks ago) [mssonicbld] * 8c17d4b - Revert "Do not enter vendor SAI critical section for counter polling/clearing operations (sonic-net#1450)" (sonic-net#1541) (7 weeks ago) [mssonicbld] * 3df03e1 - Optimize counter polling interval by making it more accurate (sonic-net#1457) (sonic-net#1534) (7 weeks ago) [Stephen Sun] * d884ff9 - [syncd] Move logSet logGet under mutex to prevent race condition (sonic-net#1520) (sonic-net#1538) (8 weeks ago) [Kamil Cudnik] * ec8b3c3 - Fix pipeline errors related to rsyslogd and libswsscommon installation (sonic-net#1535) (8 weeks ago) [mssonicbld] * 6b263b8 - [FC] Support Policer Counter (sonic-net#1533) (8 weeks ago) [mssonicbld] * e53489e - [syncd] Update log level for bulk api (sonic-net#1532) (8 weeks ago) [Jianyue Wu] * 7ae00e5 - Define bulk chunk size and bulk chunk size per counter ID (sonic-net#1528) (9 weeks ago) [mssonicbld] * f35e743 - [nvidia] Skip SAI discovery on ports (sonic-net#1524) (2 months ago) [mssonicbld] * bf049ed - Use sonictest pool instead of sonic-common and fix arm64 issue. (sonic-net#1516) (2 months ago) [mssonicbld] * ffe371d - [syncd] Support bulk set in INIT_VIEW mode (sonic-net#1517) (2 months ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
vmittal-msft
pushed a commit
to vmittal-msft/sonic-buildimage
that referenced
this pull request
Oct 20, 2025
…_64-arista_7060x6_64pe_b (sonic-net#1532) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md ** Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it Add HwSku Arista-7060X6-64PE-B-P32V128 for x86_64-arista_7060x6_64pe_b The config.bcm is modified based on existing one for Arista-7060X6-64PE-B-O128S2 ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it #### How to verify it <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 202205 - [ ] 202211 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to avoid the need and thus the confusion for application program to know
the mmu internal architecture
This change must have support from SAI change to reach the correct
config
Signed-off-by: Wenda [email protected]
- What I did
Delegate the divide-by-4 operation in setting the static threshold of egress queue for lossless traffic to the underneath SAI.
- How I did it
Change the buffers config json.
- How to verify it
Change the config_db.json on a7260 and dump the config after the change for verification.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)