Skip to content

[action] [PR:13497] system-health service_checker should check containers based on asic presence#13857

Merged
mssonicbld merged 1 commit intosonic-net:202211from
mssonicbld:cherry/202211/13497
Feb 17, 2023
Merged

[action] [PR:13497] system-health service_checker should check containers based on asic presence#13857
mssonicbld merged 1 commit intosonic-net:202211from
mssonicbld:cherry/202211/13497

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

No description provided.

…onic-net#13497)

Why I did it
On a supervisor card in a chassis, syncd/teamd/swss/lldp etc dockers are created for each Switch Fabric card. However, not all chassis would have all the switch fabric cards present. In this case, only dockers for Switch Fabrics present would be created.

system-health indicates errors in this scenario as it is expecting dockers for all Switch Fabrics (based on NUM_ASIC defined in asic.conf file).

system-health process error messages were also altered to indicate which container had the issue; multiple containers may run processes with the same name, which can result in identical system-health error messages, causing ambiguity.

How I did it
Port container_checker logic from sonic-net#11442 into service_checker for system-health.

How to verify it
Bringup Supervisor card with one or more missing fabric cards. Execute 'show system-health summary'. The command should not report failure due to missing dockers for the asics on the fabric cards which are not present.
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #13497

@mssonicbld mssonicbld merged commit c672e30 into sonic-net:202211 Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants