Fix rsyslog_plugin UT with timestamp formatter#13241
Merged
qiluo-msft merged 5 commits intosonic-net:masterfrom Jan 4, 2023
Merged
Fix rsyslog_plugin UT with timestamp formatter#13241qiluo-msft merged 5 commits intosonic-net:masterfrom
qiluo-msft merged 5 commits intosonic-net:masterfrom
Conversation
8 tasks
zbud-msft
added
Request for 202111 Branch
renukamanavalan
approved these changes
Jan 3, 2023
Contributor
renukamanavalan
left a comment
renukamanavalan
left a comment
There was a problem hiding this comment.
Please add a comment, on why we need this explicit declaration ?
It helps anyone new reading the code.
renukamanavalan
approved these changes
Jan 3, 2023
renukamanavalan
approved these changes
Jan 3, 2023
qiluo-msft
approved these changes
Jan 3, 2023
richardyu-ms
approved these changes
Jan 4, 2023
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 13241 in repo sonic-net/sonic-buildimage |
xumia
pushed a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Jan 5, 2023
#### Why I did it Timestamp formatter inside UT was failing due to new year change #### How I did it Use a const stored year that will used as expected value #### How to verify it Run UT
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jan 5, 2023
#### Why I did it Timestamp formatter inside UT was failing due to new year change #### How I did it Use a const stored year that will used as expected value #### How to verify it Run UT
Collaborator
|
Cherry-pick PR to 202211: #13263 |
mssonicbld
pushed a commit
that referenced
this pull request
Jan 5, 2023
#### Why I did it Timestamp formatter inside UT was failing due to new year change #### How I did it Use a const stored year that will used as expected value #### How to verify it Run UT
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
DavidZagury
pushed a commit
to DavidZagury/sonic-buildimage
that referenced
this pull request
Jan 12, 2023
#### Why I did it Timestamp formatter inside UT was failing due to new year change #### How I did it Use a const stored year that will used as expected value #### How to verify it Run UT
liorghub
pushed a commit
to liorghub/sonic-buildimage
that referenced
this pull request
Jan 23, 2023
#### Why I did it Timestamp formatter inside UT was failing due to new year change #### How I did it Use a const stored year that will used as expected value #### How to verify it Run UT
7 tasks
ec-michael-shih
added a commit
to ec-michael-shih/ec-sonic-buildimage
that referenced
this pull request
Dec 12, 2023
Apply community PR : sonic-net/sonic-buildimage#14293 Detail: sonic-net/sonic-buildimage#14292 as4630-54npe already merge(at commit id: 4be14f0) the PRs below: sonic-net/sonic-buildimage#13241 sonic-net/sonic-buildimage#13288 sonic-net/sonic-buildimage#15002 sonic-net/sonic-buildimage#13685 sonic-net/sonic-buildimage#14475 sonic-net/sonic-buildimage#14993 sonic-net/sonic-buildimage#14919 sonic-net/sonic-buildimage#15461 sonic-net/sonic-buildimage#16114 sonic-net/sonic-buildimage#334
7 tasks
8 tasks
tigerfu000
pushed a commit
to tigerfu000/ec-sonic-buildimage
that referenced
this pull request
Jul 4, 2024
Apply community PR : sonic-net/sonic-buildimage#14293 Detail: sonic-net/sonic-buildimage#14292 as4630-54npe already merge(at commit id: 4be14f0) the PRs below: sonic-net/sonic-buildimage#13241 sonic-net/sonic-buildimage#13288 sonic-net/sonic-buildimage#15002 sonic-net/sonic-buildimage#13685 sonic-net/sonic-buildimage#14475 sonic-net/sonic-buildimage#14993 sonic-net/sonic-buildimage#14919 sonic-net/sonic-buildimage#15461 sonic-net/sonic-buildimage#16114 sonic-net/sonic-buildimage#334
vincentchiang-ec
pushed a commit
to vincentchiang-ec/sonic-buildimage-vincentchiang
that referenced
this pull request
Aug 16, 2024
Apply community PR : sonic-net/sonic-buildimage#14293 Detail: sonic-net/sonic-buildimage#14292 as4630-54npe already merge(at commit id: 4be14f0) the PRs below: sonic-net/sonic-buildimage#13241 sonic-net/sonic-buildimage#13288 sonic-net/sonic-buildimage#15002 sonic-net/sonic-buildimage#13685 sonic-net/sonic-buildimage#14475 sonic-net/sonic-buildimage#14993 sonic-net/sonic-buildimage#14919 sonic-net/sonic-buildimage#15461 sonic-net/sonic-buildimage#16114 sonic-net/sonic-buildimage#334
vincentchiang-ec
pushed a commit
to edge-core/sonic-buildimage
that referenced
this pull request
Aug 16, 2024
Apply community PR : sonic-net/sonic-buildimage#14293 Detail: sonic-net/sonic-buildimage#14292 as4630-54npe already merge(at commit id: 4be14f0) the PRs below: sonic-net/sonic-buildimage#13241 sonic-net/sonic-buildimage#13288 sonic-net/sonic-buildimage#15002 sonic-net/sonic-buildimage#13685 sonic-net/sonic-buildimage#14475 sonic-net/sonic-buildimage#14993 sonic-net/sonic-buildimage#14919 sonic-net/sonic-buildimage#15461 sonic-net/sonic-buildimage#16114 sonic-net/sonic-buildimage#334
tigerfu000
pushed a commit
to tigerfu000/ec-sonic-buildimage
that referenced
this pull request
Jan 22, 2025
Apply community PR : sonic-net/sonic-buildimage#14293 Detail: sonic-net/sonic-buildimage#14292 as4630-54npe already merge(at commit id: 4be14f0) the PRs below: sonic-net/sonic-buildimage#13241 sonic-net/sonic-buildimage#13288 sonic-net/sonic-buildimage#15002 sonic-net/sonic-buildimage#13685 sonic-net/sonic-buildimage#14475 sonic-net/sonic-buildimage#14993 sonic-net/sonic-buildimage#14919 sonic-net/sonic-buildimage#15461 sonic-net/sonic-buildimage#16114 sonic-net/sonic-buildimage#334
tigerfu000
pushed a commit
to tigerfu000/ec-sonic-buildimage
that referenced
this pull request
Feb 7, 2025
Apply community PR : sonic-net/sonic-buildimage#14293 Detail: sonic-net/sonic-buildimage#14292 as4630-54npe already merge(at commit id: 4be14f0) the PRs below: sonic-net/sonic-buildimage#13241 sonic-net/sonic-buildimage#13288 sonic-net/sonic-buildimage#15002 sonic-net/sonic-buildimage#13685 sonic-net/sonic-buildimage#14475 sonic-net/sonic-buildimage#14993 sonic-net/sonic-buildimage#14919 sonic-net/sonic-buildimage#15461 sonic-net/sonic-buildimage#16114 sonic-net/sonic-buildimage#334
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Timestamp formatter inside UT was failing due to new year change
How I did it
Use a const stored year that will used as expected value
How to verify it
Run UT
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)