[system-health] Remove subprocess with shell=True#12572
Merged
maipbui merged 2 commits intosonic-net:masterfrom Nov 2, 2022
Merged
[system-health] Remove subprocess with shell=True#12572maipbui merged 2 commits intosonic-net:masterfrom
maipbui merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: maipbui <[email protected]>
Signed-off-by: maipbui <[email protected]>
qiluo-msft
approved these changes
Nov 1, 2022
Pirunchy64
approved these changes
Jan 25, 2023
| output = utils.run_command(['some', 'invalid', 'command']) | ||
| assert not output | ||
|
|
||
| output = utils.run_command('ls') |
qiluo-msft
pushed a commit
that referenced
this pull request
Jan 25, 2023
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jan 26, 2023
…12572)" (sonic-net#13505) This reverts commit b3a8167. Due to issue sonic-net#13432
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 6, 2023
…12572)" (sonic-net#13505) This reverts commit b3a8167. Due to issue sonic-net#13432
mssonicbld
pushed a commit
that referenced
this pull request
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: maipbui [email protected]
Why I did it
subprocessis used withshell=True, which is very dangerous for shell injection.How I did it
remove
shell=True, useshell=FalseHow to verify it
Pass UT
Manual test
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)